Mahara

PHPStan Level 1 bugs

Bug #1955101 reported by Doris Tam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Doris Tam
Mahara 22.04.0

Bug Description

 PHPStan Level 1 bugs - might not be defined errors

Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12316

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12317

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12318

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12320

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12324

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12325

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12326

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
milestone: none → 22.04.0
Doris Tam (doristam)
summary: - PHPStan Level 1 bugs - might not be defined errors
+ PHPStan Level 1 bugs
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12308
Committed: https://git.mahara.org/mahara/mahara/commit/7b4887c0c6e0ede4396415ce9c2bec850a4d41d4
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 7b4887c0c6e0ede4396415ce9c2bec850a4d41d4
Author: Doris Tam <email address hidden>
Date: Fri Dec 17 14:57:37 2021 +1300

Bug 1955101: PHPStan Level 1 bugs

Error types covered:
- variable ... might not be defined

Folders covered in htdocs:
- account
- admin
- artefact

Change-Id: I3c81196d8986d22f38a0a922029e77daa8abe7c2

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12324
Committed: https://git.mahara.org/mahara/mahara/commit/c6952349f46b1791d4e770fcfdcd59cbd0ce1b71
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit c6952349f46b1791d4e770fcfdcd59cbd0ce1b71
Author: Doris Tam <email address hidden>
Date: Fri Dec 24 11:27:48 2021 +1300

Bug 1955101: PHPStan Level 1 bugs in htdocs/view

Change-Id: I3ddc3005e31c00e3f313ed1478fdb97609ca7e1d

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12325
Committed: https://git.mahara.org/mahara/mahara/commit/86a379d9ed4355ecd5a246d9948003a345f805ed
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 86a379d9ed4355ecd5a246d9948003a345f805ed
Author: Doris Tam <email address hidden>
Date: Fri Dec 24 13:38:47 2021 +1300

Bug 1955101: PHPStan Level 1 bugs in htdocs/auth

Errortypes:
- Result of function <> (void) is used
- Method should return string...
- Variable <> might not be defined
- Constructor of class <> has an unsused parameter

Change-Id: I8cf192c4b8a84b2d177db70178194d43109c1e20

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12442

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12443

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12444

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12326
Committed: https://git.mahara.org/mahara/mahara/commit/0b2fa9f28dd461ef620d93e5ae04839039fb9460
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 0b2fa9f28dd461ef620d93e5ae04839039fb9460
Author: Doris Tam <email address hidden>
Date: Fri Dec 24 18:17:34 2021 +1300

Bug 1955101: PHPStan Level 1 bugs in htdocs/module

Errortypes:
- Result of function <> (void) is used
- Method should return string...
- Variable <> might not be defined
- Constructor of class <> has an unsused parameter
- Method) <> invoked with 1 parameter, 0 required
- Variable <> in isset() always exists and is not nullable.
Change-Id: Ia13b386800ad54b71228a6a9e95d9192b8f48913

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12327
Committed: https://git.mahara.org/mahara/mahara/commit/8110d1c9a5a74f710602b00fe78d9fa4451d33db
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 8110d1c9a5a74f710602b00fe78d9fa4451d33db
Author: Dianne Tennent <email address hidden>
Date: Thu Jan 6 16:58:48 2022 +1300

Bug 1955101: PHPStan Level 1 bugs in htdocs/blocktype

Change-Id: I10befdc2b076c76c50c94c18a8a00797d063c76c

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12442
Committed: https://git.mahara.org/mahara/mahara/commit/ab8681db741369c15dfb070ac612629a14739fd2
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit ab8681db741369c15dfb070ac612629a14739fd2
Author: Doris Tam <email address hidden>
Date: Mon Feb 21 16:45:55 2022 +1300

Bug 1955101: PHPStan Level 1 bugs in htdocs/api

Change-Id: I37ae6a64929b161728f63caa3b9d2026577eb147

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12317
Committed: https://git.mahara.org/mahara/mahara/commit/450203854f70744c742b6a0097ad368cb041cb9a
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 450203854f70744c742b6a0097ad368cb041cb9a
Author: Doris Tam <email address hidden>
Date: Wed Dec 22 15:43:14 2021 +1300

Bug 1955101: PHPStan Level 1 bugs in htdocs/collection

Errors: Might not be defined

Change-Id: Ic6d17767cce0761b92c070410362e20459479956

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12320
Committed: https://git.mahara.org/mahara/mahara/commit/c830632494ef914ae26a07142e7ee35cb8074483
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit c830632494ef914ae26a07142e7ee35cb8074483
Author: Doris Tam <email address hidden>
Date: Thu Dec 23 12:43:57 2021 +1300

Bug 1955101: PHPStan Level 1 bugs in htdocs/lib

Errortypes:
- Result of function <> (void) is used
- Method should return string...
- Variable <> might not be defined
- Constructor of class <> has an unsused parameter

Change-Id: Ib2ece12e1e737f40aafaadf8a9c30774b42687f2

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.