Need fwupd in focal to support Quectel's modem(EM120/160) firmware update

Bug #1954965 reported by Jerry Lee
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Committed
Critical
Yuan-Chen Cheng
fwupd (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Hirsute
Won't Fix
Undecided
Unassigned
Impish
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned

Bug Description

** We found that modemmanger SRU also needed to support the fw update. Plan to close this one as is.

** Feel free to create another bug for tracking that task if you want.

SRU document goes to lp:1949412

The current fwupd packages in focal does not support Quectel's modem(EM120/160) firmware update through LVFS.

The following commits on the upstream project are needed :

https://github.com/fwupd/fwupd/commit/da895169a7a04da3713dece1be487267be128674
https://github.com/fwupd/fwupd/commit/5e04fae8f219d0cc2710af6c76d12be0d54eee3c
https://github.com/fwupd/fwupd/commit/db8a9927f4a52b917705132170dbe6b4f88c4643
https://github.com/fwupd/fwupd/commit/bd6adc8bebddff753fc2715cca46a55efd872765

tags: added: oem-priority
Changed in oem-priority:
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
Mario Limonciello (superm1) wrote :

This will require upgrading to fwupd 1.7.3. This upgrade is staged in packaging, and the plan is as follows:
1. Wait for 1.7.1 to clear Debian binary NEW queue (it has new libfwupdplugin binary package)
2. Upgrade Debian to 1.7.3.
3. Wait for 1.7.3 to clear Debian binary NEW queue (it has new libfwupdplugin binary package)
3. Sync from Debian to Ubuntu

Changed in fwupd (Ubuntu Jammy):
status: New → Fix Committed
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

@Jerry could you confirm if we need 1.7.3 or 1.7.1 is already fine for this?

Revision history for this message
Jerry Lee (jerry-lee-tpe) wrote :

@YC

The customer confirmed that fwupd >= 1.7.1 is good enough.

Revision history for this message
Mario Limonciello (superm1) wrote :

1.7.3 is in Jammy anyway now.

Changed in fwupd (Ubuntu Jammy):
status: Fix Committed → Fix Released
Changed in oem-priority:
assignee: nobody → Yuan-Chen Cheng (ycheng-twn)
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

I create test ppa for focal and impish.

Ref: #11, #12 of lp:1949412

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Jerry, or anyone else affected,

Accepted fwupd into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.4-1~21.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in fwupd (Ubuntu Impish):
status: New → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Jerry, or anyone else affected,

Accepted fwupd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.4-1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in fwupd (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed-focal
Changed in fwupd (Ubuntu Focal):
status: Fix Committed → Confirmed
Changed in fwupd (Ubuntu Impish):
status: Fix Committed → Confirmed
tags: removed: verification-needed verification-needed-focal verification-needed-impish
Revision history for this message
Jerry Lee (jerry-lee-tpe) wrote :

I have not found new version of fwupd in focal-proposed.
It looks like there is some issued in LP#1949412 so the package is removed ?

description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Jerry, or anyone else affected,

Accepted fwupd into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.5-3~21.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in fwupd (Ubuntu Impish):
status: Confirmed → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Jerry, or anyone else affected,

Accepted fwupd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.5-3~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in fwupd (Ubuntu Focal):
status: Confirmed → Fix Committed
tags: added: verification-needed-focal
Changed in oem-priority:
status: Confirmed → In Progress
Revision history for this message
Jerry Lee (jerry-lee-tpe) wrote :

The package fwupd v1.7.5-3~20.04.1 in focal-proposed was tested.
This built package v1.7.5-3~20.04.1 can't let the modem's firmware to be updated via modemmanager.
That is, "fwupdmgr get-devices" does not list the Quectel modem to be firmware update supported on the tested machine.

The root cause is: the plugin code inside the fwupd is modemmanager version dependent.
For ex., the following conditional compiled code will not be included if the installed modemmanager version is less than the required version (> 1.17.1) while building.

plugins/modem-manager/fu-mm-device.c:

        static const MMModemFirmwareUpdateMethod supported_combinations[] = {
                MM_MODEM_FIRMWARE_UPDATE_METHOD_FASTBOOT,
                MM_MODEM_FIRMWARE_UPDATE_METHOD_QMI_PDC | MM_MODEM_FIRMWARE_UPDATE_METHOD_FASTBOOT,
#if MM_CHECK_VERSION(1, 17, 1)
                MM_MODEM_FIRMWARE_UPDATE_METHOD_MBIM_QDU,
#endif /* MM_CHECK_VERSION(1,17,1) */
#if MM_CHECK_VERSION(1, 17, 2)
                MM_MODEM_FIRMWARE_UPDATE_METHOD_FIREHOSE,
#endif
        };

The Quectel modem requires the method MM_MODEM_FIRMWARE_UPDATE_METHOD_FIREHOSE to be supported.
Currently, the latest version of modemmanager in Focal is 1.16.6-2~20.04.1 .

If the modemmanager is upgraded to the required versions, we might request for a no-change-rebuild SRU in focal.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

** We found that modemmanger SRU also needed to support the fw update. Plan to close this one as is.

** Feel free to create another bug for tracking that task if you want.

description: updated
description: updated
Changed in oem-priority:
status: In Progress → Fix Committed
tags: added: verification-done verification-done-focal verification-done-impish
removed: verification-needed verification-needed-focal verification-needed-impish
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, thank you for the information. What I would recommend is to re-open this bug after we release the fwupd updates, since otherwise people might think this is already 'fixed' - while it's not. But I don't think this should be a blocker.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

Sure, will do.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwupd - 1.7.5-3~21.10.1

---------------
fwupd (1.7.5-3~21.10.1) impish; urgency=medium

  * Backport 1.7.5-3 from jammy to impish.
  * Support several new devices (LP: #1949412, LP: #1954965, LP: #1953573)
  * fwupd / fwupd-efi source package split (LP: #1955386)
  * Don't install new fwupd-unsiged by default. (LP: #1960783)

 -- Yuan-Chen Cheng <email address hidden> Mon, 21 Feb 2022 00:12:49 +0000

Changed in fwupd (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for fwupd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwupd - 1.7.5-3~20.04.1

---------------
fwupd (1.7.5-3~20.04.1) focal; urgency=medium

  * Backport 1.7.5-3 from jammy to focal.
  * Support several new devices (LP: #1949412, LP: #1954965, LP: #1953573)
  * fwupd / fwupd-efi source package split (LP: #1955386)
  * Don't install new fwupd-unsiged by default. (LP: #1960783)
  * Disable flashrom in focal as it was not enabled in focal.
  * Downgrade libgusb from 0.3.5 to 0.3.4 which used in focal after
    checking through all commits between. Just what we did on previous
    focal version 1.5.11.

 -- Yuan-Chen Cheng <email address hidden> Mon, 21 Feb 2022 11:06:00 +0800

Changed in fwupd (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

as modemmanager is SRU, we need a rebuilt. track in lp:1980334

Changed in oem-priority:
status: Fix Committed → Confirmed
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

per test on jammy / fwupd 1.7.5, I can see EM160R GL in the
output of fwupdmgr get-devices.

So we only need to fix this issue in focal.

tags: added: fwupd
Changed in oem-priority:
status: Confirmed → In Progress
Changed in fwupd (Ubuntu Hirsute):
status: New → Won't Fix
Changed in oem-priority:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.