PHPStan errors in htdocs/lib/adodb - level 0

[Dianne Tennent]

Fix errors uncovered by PHPStan in ADOdb library (Error log output attached to this bug)

Once all the fixes are made, a pull request should be made to ADOdb.

Reviews of that pull request should also be applied to this patch before merging with Mahara main.

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12302

[Dianne Tennent (dianne-t)]

Info about xmlschema: https://adodb.org/dokuwiki/doku.php?id=v5:dictionary:xmlschema&s[]=xmlschema

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12310

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12310
Committed: https://git.mahara.org/mahara/mahara/commit/807965adbf8c8e6fa59e8bcf137f3ab461daf688
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 807965adbf8c8e6fa59e8bcf137f3ab461daf688
Author: Dianne Tennent <email address hidden>
Date: Mon Dec 20 10:42:01 2021 +1300

Bug 1954869: PHPStan errors in ADOdb

New patch to replace previous patch with a
smaller set of fixes that don't stop the page
loading.

This reverts commit 7c0027e7291de0bd648590abca9d1b2a9b0d20dc.

Change-Id: Ic0948016ac46fcd3f83914e051cf782f84c9a9a1