Angular acq funds: Remove year auto-filter

[Tiffany Little]

Testing 3.8 on production dataset.

With the new angular acq funds, we got the feature of auto-filtering on a pre-specified value (fiscal year, in this case). I think this is a fantastic feature, but the more I use it the less I like it being used with the funds interface.

Right now, Evergreen can't distinguish what the actual fiscal year being used is. It just goes for calendar year. So for half of the fiscal year, it's wrong. Like as of today, it auto-filters to 2021 funds even though all of my libraries are in FY22.

So that means two things:

1. It's not as in your face visible as it was before what fiscal year you're in. If you're really paying attention, you'll see the grid filter is on. Also if you're really paying attention, you'll look at your funds and see the 2021 year (assuming you have that column visible). Because we propagate funds, they often have the same names between years, so it's very easy to just see the name/codes of your funds and go about your business and not realize you're in a previous FY. (See bug 1948946)

2. When you change the filter to your correct fiscal year, the grid reloads. And there's a *lot* of grid reloading going on in this interface right now (I'll link some related bugs in a subsequent comment). And it's not sticky, so if I navigate to the funding sources tab then it loses my filter and I have to reset it again.

So my proposal is to return fiscal year to a visible selector beside the org family unit selector, and remove the auto-filter that it's currently using. If fiscal year was in its own selector box at the top, maybe we could also set it as a LocalItem and make it sticky, which would even be an enhancement since we didn't have that in Dojo.

Also to clarify, year should still be a column that's filterable/sortable in the grid. I'm just talking about the auto-filter and creating a more visible combobox.

[Lindsay Stratton (lstratton)]

The hard coded calendar year filter (since non-calendar year fiscal years are not supported) is a huge problem.

All of my libraries using ACQ have non-calendar year FYs. As I am testing 3.8 (mid FY, 2021-22) it took me way too long to figure out why none of my my funds were appearing. I actually thought it was a permission error.

Because I happen to think that differentiating filtered vs. non-filtered columns is a general issue I created a separate ticket for that - https://bugs.launchpad.net/evergreen/+bug/1962620

[Jennifer Pringle (jpringle-u)]

Agree with Lindsay, this is a huge problem for us too as we have many libraries with non-calendar fiscal years.

[Christine Morgan (cmorgan-z)]

+1 to Tiffany's proposal and Lindsay and Jennifer's comments.

[Tiffany Little (tslittle)]

I have a possible patch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1953181_Acqfundsyearfilter

Returns the year as a selector dropdown on the page and removes the autofilter on the Year column. The top commit on the branch also adds an optional input to eg-combobox for a LabelText, similar to the eg-org-family-select component.

[Mary Llewellyn (mllewell)]

I like having the date in a selector box. It's a lot clearer about what years are being displayed.

With that, it appears the filter on year serves no purpose. If the year in the drop down is 2022, then I can't add a filter to see 2022 and earlier. Though it restores the function we've been used to, is there any need for a library to be able to list the funds from all years? The year filter allowed this before.

[Christine Morgan (cmorgan-z)]

I agree with Mary that having the date selector box with the year is a lot clearer to users as to what funds are being displayed. The setting being sticky is a much needed feature.

I think it is useful to be able to filter the grid to see multiple fund years. So I don't think we want to lose that. Using the fund name or code filter, along with the year filter for example, allows you to quickly compare expenditures in a fund over multiple years.

Is it possible to have the filter override the fiscal year that is set in the selector box when the filter is in use?

[Mary Llewellyn (mllewell)]

+1 to a filter override.