Inactive funds should not be able to make allocations/transfers

[Tiffany Little]

In the funds interface, we only show a dropdown list of active funds to try to minimize transferring monies between inactive funds.

However, if you go into the funds interface into a particular fund, the Create Allocation and Transfer Money buttons are both active. So you can still successfully create allocations from a funding source into an inactive fund.

This came up because the fiscal year selector always goes to the current calendar year, even though you may be in a new fiscal year. So not remembering to change the fiscal year selector means that you might accidentally click on last year's fund and try to create an allocation.

So the request is that the Create Allocation and Transfer Money buttons should be greyed out whenever you're opening up an inactive fund.

[Jennifer Pringle (jpringle-u)]

Confirmed this behaviour on 3.8.0

I agree that it shouldn't be possible to allocate to or transfer from/to an inactive fund.

I can see a situation where you may want to transfer remaining funds from an inactive fund to another fund. In this situation I think the workflow of set the fund as active, make the transfer, and then de-activate the fund makes sense more sense than allowing transfers with an inactive fund.

[Tiffany Little (tslittle)]

Here's a fix: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1948946_Block_inactivefund_transfers

[Mary Llewellyn (mllewell)]

I created a fund for 2021, added some money, then deactivated it. The buttons for Create Allocation and Transfer Money are no longer active. They are not grayed out but you can't click on them and get a response.

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>

[Jane Sandberg (sandbergja)]

Thanks, Tiffany and Mary! And compliments on the use of the optional chaining operator, Tiffany! Such a nice addition to the language, I'm glad to see it getting used more in eg2.

Merged for inclusion in 3.10.