graphmonkey: Upgrade to new upstream release (1.7)

[David Futcher]

Binary package hint: graphmonkey

A new upstream version of Graphmonkey has been released, version 1.7.

The sourceforge.net release notes say these changes have been made: "zoom capabilities, area under the curve, average value, graph of derivative, menu bar, trace mouse pointer, save graph to .png file and fix some bugs "

[Cesare Tirabassi (norsetto)]

This would have to wait for intrepid.
It would speed up if you can require an upgrade in the Debian bts so that we can simply autosync.

[David Futcher (bobbo)]

Attaching the patch i submitted in Debian (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467492)

[Luca Falavigna (dktrkranz)]

A Feature Freeze exception is required: http://wiki.ubuntu.com/FreezeExceptionProcess.
If you think new upstream version should be available in Hardy, please attach the informations required and subscribe motu-release. Thanks!

[David Futcher (bobbo)]

Diffstat for FFe

[David Futcher (bobbo)]

Buildlog for FFe

[Scott Kitterman (kitterman)]

This is still not a complete FFe request. See https://wiki.ubuntu.com/FreezeExceptionProcess#head-9523bc4076ff011324d67cddc97969ec609618d6 for details.

[David Futcher (bobbo)]

Will not make this an FFe. At this stage in Hardy i cant see an update doing much good. Will wait until Intrepid for this.

[Scott Kitterman (kitterman)]

Please make this invalid.

[David Futcher (bobbo)]

Re-opening for Hardy and subscribing u-u-s.

[Andrea Colangelo (warp10)]

The debdiff is not correct, since debian/changelog latest entry is for unstable. BTW, please first check if we can fix this bug with a merge|sync.

Unsubscribing u-u-s.

[David Futcher (bobbo)]

New debdiff, changes some stuff in debian/changelog. The debdiff is huge though, am I going about this the right way?

[Daniel Holbach (dholbach)]

Can you link to the new upstream tarball and attach the .diff.gz of the source package here?

[David Futcher (bobbo)]

Heres the orig.tar.gz

[David Futcher (bobbo)]

Heres the diff.gz

[Daniel Holbach (dholbach)]

I have a few questions:
 - Why do you add MyWindow.cs and description-pak in the diff.gz?
 - Can you change "(1.7-1) unstable" to "(1.7-0ubuntu1) intrepid"?
 - Can you follow https://wiki.ubuntu.com/DebianMaintainerField ?

[David Futcher (bobbo)]

MyWindow.cs was accidentally carried over from 1.6, removed it. FIxed the version number and Maintainer field. Builds fine in an Intrepid pbuilder.

[Cesare Tirabassi (norsetto)]

1) Please add a watch file and/or a get-orig-source target in debian/rules.
2) It DOESN'T (!!) build for me in an intrepid pbuilder (see attached log)
   seems there is this change in Makefile which needs patching:

   SHARE=/usr/local/share
   BIN=/usr/local/bin

3) Its not lintian clean (W: graphmonkey source: debian-rules-ignores-make-clean-error)
4) copyright has been changed, it should now be "Copyright (C) 2006" in debian/copyright
5) headers in source files contain wrong FSF address
6) wrapper content has changed (I believe wrongly) to: mono /usr/local/share/graphmonkey/GraphMonkey.exe
7) by looking at HELP it seems that there are a couple of modifications to be made to the man page
8) please add a .desktop file
9) pls. get rid of the linda override

[Cesare Tirabassi (norsetto)]

10) Pls. use a patch system, don't make inline changes (most probably the reason for my build failure).
11) What is the purpose of description-pak?

[David Futcher (bobbo)]

Thanks for your feedback norsetto. Will work on this more.

[Cesare Tirabassi (norsetto)]

I have some more comments:

12) The following are not removed by the clean target:
graphmonkey
description-pak
Makefile

They are already covered by comments 10 and 11.

13) I'm not very familiar with CLI applications, but http://pkg-mono.alioth.debian.org/cli-policy/ch-packaging.html#s-file-locations seems to imply that your .exe should be in /usr/lib/graphmonkey not /usr/share/graphmonkey/. You should perhaps ask to somebody more knowledgeable than me about CLI packaging for Debian.

14) apps/math in the menu file seems to be obsolete (see http://lists.debian.org/debian-devel-announce/2007/07/msg00000.html). Should now be Applications/Science/Mathematics.

15) Since you have moved the homepage to its own section, you should delete it from the description.

[David Futcher (bobbo)]

Sorry for the lack of activity on this recently, been very busy with school. Here is a new version that should fix all the issues you outlined above. I dont think i have missed any, if i have feel free to shout at me.

Fully builds from source in my PPA http://launchpadlibrarian.net/15200315/buildlog_ubuntu-intrepid-i386.graphmonkey_1.7-0ubuntu1_FULLYBUILT.txt.gz and the resulting binary installs and runs.

[David Futcher (bobbo)]

Forgot to add bug number to changelog. Here is a fixed diff.gz

[David Futcher (bobbo)]

Added a get-orig-source directive to debian/rules.

[Andrea Colangelo (warp10)]

Good work David! You are almost there.
Please, fix these easy issues:

1) "Apps" is deprecated in the menu file. Please, move it to "Applications"
2) Current Standards-Version is 3.8.0.
3) Could you check this lintian warning: "W: graphmonkey: manpage-has-errors-from-man usr/share/man/man1/graphmonkey.1.gz 76: warning: `b' not defined"?

Other than that, the package looks ready for the archives. Please, resubscribe u-u-s once done.

[Cesare Tirabassi (norsetto)]

I should also mention that the get-orig-source target doesn't work.
I'd rather use a simpler uscan --force-download --rename;
you then have to make sure that the tarball unrolls to graphmonkey-1.7 not GraphMonkey-1.7-src

[Cesare Tirabassi (norsetto)]

It seems you have also forgotten the .desktop file, having a debian menu and not a desktop file doesn't make much sense for Ubuntu.
I would also update the date for the man page (now July 4, 2005) since you modified it in line with HELP.
IMHO, we don't need to include HELP at this point (it just replicates whats in the man page).
For my comment 5 above, I know there is nothing we can do, but at least I would send an email upstream?
There is also some clean-up (extra lines and blank spaces) to do in debian/control and debian/watch.
I agree with Andrea, this is pretty much ready for archiving.

[David Futcher (bobbo)]

Here is the new version. Does everything that you commented about above. The get-orig-source isnt brilliant because upstream package their tarballs in a strange way, so you have to hardcode the new release number into debian/rules for the get-orig-source to work, which obviously isnt ideal but is what i was told to do in #-motu.

Builds fine in an intrepid pbuilder.

[David Futcher (bobbo)]

Woops typo in the last diff.gz

[Cesare Tirabassi (norsetto)]

Can you please make sure the desktop file is compliant with the latest freedesktop spec?
You can find the latest spec here:

http://standards.freedesktop.org/desktop-entry-spec/latest/

or use the most recent desktop-file-validate script.

[David Futcher (bobbo)]

The .desktop had a few errors flagged up by desktop-file-validate. Heres a revised diff.gz. Thanks for spending all the time on this!

[Cesare Tirabassi (norsetto)]

The get-orig-source target still doesn't work:

uscan --verbose --force-download --rename
-- Scanning for watchfiles in .
-- Found watchfile in ./debian
-- In debian/watch, processing watchfile line:
   http://sf.net/graphmonkey/GraphMonkey-(.+)-src\.tar\.gz
-- Found the following matching hrefs:
     GraphMonkey-0.9-src.tar.gz
     GraphMonkey-1.0-src.tar.gz
     GraphMonkey-1.1-src.tar.gz
     GraphMonkey-1.2-src.tar.gz
     GraphMonkey-1.3-src.tar.gz
     GraphMonkey-1.4-src.tar.gz
     GraphMonkey-1.5-src.tar.gz
     GraphMonkey-1.6-src.tar.gz
     GraphMonkey-1.7-src.tar.gz
Newest version on remote site is 1.7, local version is 1.7
 => Package is up to date
Newest version on remote site is 1.7, local version is 1.7
 => Forcing download as requested
-- Downloading updated package GraphMonkey-1.7-src.tar.gz
-- Successfully downloaded updated package GraphMonkey-1.7-src.tar.gz
    and renamed it as graphmonkey_1.7.orig.tar.gz
-- Scan finished
cd ..
tar -xvf graphmonkey_1.7.orig.tar.gz
tar: graphmonkey_1.7.orig.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
make: *** [get-orig-source] Error 2

The problem is that in Mafiles, each single command has its own shell script. With the rule as you have written it, the first command calls uscan and the package is downloaded and renamed, the second command goes up a directory, the 3rd command is executed, but in the original directory (since the previous shell terminated!).
Also note that the final directory you create will be named graphmonkey_1.7, while it should be graphmonkey-1.7.
But you will already have such a directory, and you can't touch it since it is where you have your debian/rules.
So, what you are trying to do just doesn't make any sense to me, I think you should just get rid of this.

[David Futcher (bobbo)]

Ok, now I understand why things weren't working properly! Have removed the get-orig-source directive from debian/rules and will email upstream to see if they will consider changing their tarballs to extract in a more 'standard' way.

[Cesare Tirabassi (norsetto)]

Setting status to confirmed to have it correctly visible in sponsor's list.

[Luca Falavigna (dktrkranz)]

Looks good, uploading.

[Launchpad Janitor (janitor)]

This bug was fixed in the package graphmonkey - 1.7-0ubuntu1

---------------
graphmonkey (1.7-0ubuntu1) intrepid; urgency=low

  * New upstream release (LP: #195196)
  * debian/control:
    - Bump Debian standards version
    - Add Homepage field
    - Change Maintainer field to match DebianMaintainerField specification
    - Remove homepage from description
    - Add 'dpatch' to Build-Depends
    - Bump Debian standards version to 3.8.0
  * Change installation directory for .exe files to /usr/lib/graphmonkey to
    follow Debian cli-policy
  * debian/rules:
    - Fix Lintian debian-rules-ignores-make-clean-error
    - Change graphmonkey.exe install directory to install into /usr/lib/
    - Add icon and .desktop file installation
  * debian/dirs:
    - Add /usr/lib/, /usr/share/applications and /usr/share/pixmaps
    - Remove /usr/share/ as it isnt needed anymore
  * debian/watch: Add watchfile
  * debian/copyright: Update copyright years
  * debian/linda.override, debian/rules: Remove Linda override
  * debian/menu: Change section to "Applications/Science/Mathematics"
  * debian/patches/*: Add dpatch patchsys
  * debian/docs: Remove docs file as all information is provided in the man page
  * debian/graphmonkey.1: Add new information (taken from HELP)
  * description-pak: Remove unneeded file
  * Makefile, graphmonkey: Move inline changes to 01-Change-install-dir.dpatch
  * debian/graphmonkey.desktop: Add .desktop file

 -- David Futcher <email address hidden> Mon, 25 Feb 2008 20:11:39 +0000