Update to 1.21-0ubuntu1~18.04 FTBFSes libvirt in-release
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dwarves-dfsg (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bionic |
Won't Fix
|
Undecided
|
Unassigned | ||
libvirt (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
SRU-Template for a libvirt upload to this bug
[Impact]
* The SRU of the new dwarves made libvirt an FTBFS
due to changed behavior of pdwtags
* The change in libvirt will continue to ignore pdwtags
as it did before to match former builds.
[Test Plan]
* Has to build successfully again
* This has no other impact as we really make
it "as it was" before dwarves changed. Nevertheless we will
do a general regression test once in -proposed
[Where problems could occur]
* As I said this makes the changes in dwarves a no-op, thereby
no changes are expected. Therefore I can't point to a specific
area and will test generically.
[Other Info]
* n/a
---
Hi,
I faced an regression-
I found this to be related to the recent release of https:/
It is locally reproducible in sbuild if you build it in bionic right now.
It will break checking some structs.
Example:
(bionic-
...
enum remote_auth_type {
- REMOTE_AUTH_NONE = 0,
- REMOTE_AUTH_SASL = 1,
+ REMOTE_AUTH_NONE = 0,
+ REMOTE_AUTH_SASL = 1,
};
There are much more, but all of them just differ in whitespace.
As if some tool was updated now breaking all the tests while the content that
matters is actually fine.
One element of this comparison lives in the source
like src/remote_
enum remote_auth_type {
};
But the generated content was changed to be aligned.
I found this to use pdwtags from dwarves which is
# apt-cache policy dwarves
dwarves:
Installed: 1.21-0ubuntu1~18.04
Candidate: 1.21-0ubuntu1~18.04
Version table:
*** 1.21-0ubuntu1~18.04 500
500 http://
500 http://
100 /var/lib/
1.10-2.1build1 500
500 http://
Going back to the release version
$ apt install dwarves=
=> fixes the FTBFS.
Formerly the too old pdwtags was detected as broken in libvirt.
But the new one is accepted and fails as the output mismatches.
Old:
(bionic-
die__process_unit: DW_TAG_
New:
(bionic-
enum remote_auth_type {
REMOTE_AUTH_NONE = 0,
REMOTE_AUTH_SASL = 1,
REMOTE_AUTH_POLKIT = 2,
}; /* size: 4 */
Other use cases had valid output before, but now ware aligned - they might face similar FTFBS issues now.
For libvirt I might fix the expected result or skip the test (as it always was skipped).
But this update of dwarves has the potential to break much more users of it since not
only the functionality but even the output style has changed by this update.
Related branches
- Sergio Durigan Junior (community): Approve
- Canonical Server: Pending requested
- git-ubuntu import: Pending requested
-
Diff: 176 lines (+148/-0)4 files modifieddebian/changelog (+9/-0)
debian/patches/series (+2/-0)
debian/patches/ubuntu/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch (+71/-0)
debian/patches/ubuntu/skip-new-pdwtags.patch (+66/-0)
Changed in libvirt (Ubuntu): | |
status: | New → Invalid |
Changed in libvirt (Ubuntu Bionic): | |
status: | New → In Progress |
tags: | added: regression-update |
FYI - tested and uploaded the libvirt fix along the SRU upload for bug 1927519.
This bug will need an SRU template for that as well, adding it now.