Enable spellcheck for angular MARC edit screens

[Steve Callender]

3.7+

When using the new angular interface to search for a record and then edit the MARC, we are purposely disabling spellcheck in the code.

ng-container *ngIf="bigText">
  <div contenteditable
    id='{{randId}}'
    spellcheck="false"

Spellcheck should be enabled for at least subfield inputs.

[Stephanie Leary (stephanieleary)]

Patch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP1947906-restore-marc-spellcheck

However, I'm marking this as needsdiscussion in case the attribute was there for reasons I'm not aware of.

[Elaine Hardy (ehardy)]

I think the main reason it was disabled was because of the potential number of false hits. Especially for those records with 6XXs in multiple languages.

[Stephanie Leary (stephanieleary)]

Thanks, Elaine. You've reminded me that I meant to file a bug on adding language attributes to the bib fields for screen reader support purposes. That won't help us here, though. I did some digging on browser support for spellcheck in multiple languages, and it appears that none of them automatically switch dictionaries based on the input's lang attribute as they should. However, it is possible for the user to install multiple dictionaries and choose the appropriate one (or turn off spellcheck) by right-clicking the input.

I feel like documenting this would be better than disabling spellcheck entirely for everyone.

[Brenda Gale Beasley-Forrest (brendagael24)]

Please remove me from your contacts.

I am not on Evergreen.

The manage notifications link at the bottom is ambiguous.

Thanks!

BrendaGael Beasley~Forrest, MA, MSLS
Catalog Librarian               843.255.6436
Beaufort County Library ~ Beaufort Branch
311 Scott Street, Beaufort, SC 29902
http://www.beaufortcountylibrary.org/

-----Original Message-----
From: <email address hidden> <email address hidden> On Behalf Of Stephanie Leary
Sent: Friday, August 18, 2023 4:37 PM
To: Beasley-Forrest, Brenda <email address hidden>
Subject: [Bug 1947906] Re: Enable spellcheck for angular MARC edit screens

[EXTERNAL EMAIL] Please report any suspicious attachments, links, or requests for sensitive information to the Beaufort County IT Division at <email address hidden> or to 843-255-7000.

** Tags removed: needsdiscussion
** Tags added: pullrequest

--
You received this bug notification because you are subscribed to a duplicate bug report (1988222).
<a href="https://urldefense.com/v3/__https://bugs.launchpad.net/bugs/1947906__;!!H5U1HoZiDaw1SX31!AgXjZEKBw8Wlnc_cAENZG3SS_TQldbNGx8QDMxifIgzGoqjKITDeY9aPFJc13Ho7CRslBMw7CfcZslbyLkrW2S2L$">https://bugs.launchpad.net/bugs/1947906</a>

Title:
  Enable spellcheck for angular MARC edit screens

Status in Evergreen:
  Confirmed

Bug description:
  3.7+

  When using the new angular interface to search for a record and then
  edit the MARC, we are purposely disabling spellcheck in the code.

  ng-container *ngIf="bigText">
    <div contenteditable
      id='{{randId}}'
      spellcheck="false"

  Spellcheck should be enabled for at least subfield inputs.

To manage notifications about this bug go to:
https://bugs.launchpad.net/evergreen/+bug/1947906/+subscriptions

[Garry Collum (gcollum)]

I tested and it works perfectly. A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/LP1947906-restore-marc-spellcheck-signoff

[Terran McCanna (tmccanna)]

Before committing - Jane and I noticed when looking at the MARC Enhanced Editor tab it works great, but in the Flat Text Editor tab there are a lot of false positives - see "$aStories" for example.

Perhaps it could be enabled for the MARC Enhanced Editor tab but not for the Flat Text Editor tab? Or is there cataloger consensus that the false positives are acceptable on the Flat Text tab?

[Britta Dorsey (bdorsey-isl)]

I worry that enabling the spellcheck in the flat text editor will make the screen way too difficult to manage. There would be false positives in nearly all of the fields because there is no separation between the field rows, the subfield code and the entry.

Here's an example of the 6XX fields in the Flat Text Editor:

=600 00$aBarbie$c(Fictitious character)$vDrama.
=650 \0$aDolls$vDrama.
=650 \0$aImaginary places$vDrama.
=650 \0$aReality$vDrama.
=650 \0$aWomen$xSocial life and customs$vDrama.
=650 \0$aExistentialism$vDrama.
=650 \0$aFeminism$vDrama.
=655 \7$aComedy films.$2lcgft$0(DLC)1141678

It might be easier to manage in the Enhanced MARC Editor because each field and subfield are in their own separate "grid".

I personally prefer to work in the Flat Text Editor because it's faster to use and copying from other records is possible.

[Kathryn Riedener (kriedener)]

I agree with everything Britta has said. I also prefer using the flat text editor.

[Carol Witt (carolwitt)]

I almost always use the flat text editor and agree with Britta.

[Terran McCanna (tmccanna)]

Removing pullrequest & signoff due to feedback about flat text editor.

[Stephanie Leary (stephanieleary)]

I've updated the branch to allow spellcheck only on the rich editor inputs. Rebased and squashed: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP1947906-restore-marc-spellcheck

[Mackenzie Johnson (mtjohnsonupei)]

Following Terran's email to the EG cataloguer's listserv seeking feedback re: flat text vs. enhanced MARC editor, I mainly use the flat text editor, and really only use the enhanced editor to quickly add or adjust the LDR or 008 characters with the dropdowns.

[Terran McCanna (tmccanna)]

Works perfectly! Thanks to Stephanie, Garry, and all of the catalogers who provided feedback here, by email, and in the Catalogers Interest Group!

Pushed to main, 3.12, 3.11, and 3.10.