'Edit group membership' screen has overlapping text with long group names

Bug #1947625 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

Reported at https://mahara.org/interaction/forum/topic.php?id=8939

It looks like there is no provision to handle long group names gracefully, i.e. wrap them when you try to add them via 'Edit group membership' on Main menu -> Engage -> People.

To replicate:

1. Upload the attached CSV file with group names.
2. Add at least one other person to the site.
3. As site admin, go to Main menu -> Engage -> People and click 'Edit group membership' next to the other person.

Expected result: The modal displays all groups under 'Add members' and 'Invite' in a readable fashion.
Actual result: The group names overlap. See the screenshot on the forum topic.

The group names should wrap because they tend to be the same at the start and only differ towards the end. That's why an ellipses wouldn't be a good option.

There are also a couple of accessibility issues:

1. There are two buttons with 'btn-primary'. Since there is no real primary button, they should both have the normal grey button color.
2. Both buttons are called 'Apply changes' without any additional marker (I think) to indicate which one is which. I think it would be better to call the first one 'Add to group' and the second one 'Invite to group'.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
description: updated
tags: added: acces
tags: added: accessibility
removed: acces
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12171

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12171
Committed: https://git.mahara.org/mahara/mahara/commit/5377061bde55d9ae3e101760946ab3bb53b13f2d
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 5377061bde55d9ae3e101760946ab3bb53b13f2d
Author: Evonne <email address hidden>
Date: Thu Oct 21 11:45:19 2021 +1300

Bug 1947625 'Edit group membership' overlapping long text

behatnotneeded

Change-Id: Iabc29814ef6915dff516e0c92f90a98733568bea

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12173

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12173
Committed: https://git.mahara.org/mahara/mahara/commit/d527f268e8f9938a1ce9a6ef2b41d9be01084201
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit d527f268e8f9938a1ce9a6ef2b41d9be01084201
Author: Evonne <email address hidden>
Date: Thu Oct 21 11:45:19 2021 +1300

Bug 1947625 'Edit group membership' overlapping long text

behatnotneeded

Change-Id: Iabc29814ef6915dff516e0c92f90a98733568bea
(cherry picked from commit 5377061bde55d9ae3e101760946ab3bb53b13f2d)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
milestone: 22.04.0 → 21.10.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.