Click actions "previews" and "minimize-or-previews" are broken

[Sebastian Haderecker]

[ Impact ]

Since upgrading to Ubuntu 21.10 the "previews" and "minimize-or-previews" options no longer work as expected.

[ Test case ]

1. gsettings set org.gnome.shell.extensions.dash-to-dock click-action "previews"
 - Open multiple windows for an application
 - Click on the icon, previews should be shown

2. gsettings set org.gnome.shell.extensions.dash-to-dock click-action "minimize-or-previews"
  - Open multiple windows for an application
  - Click on the icon, previews should be shown

[ Regression potential ]

Wrong action is taken if an application has urgent windows

----

For "previews":
No previews are shown when clicking on the app icon.

For "minimize-or-previews":
When multiple windows of the same application are open and I click on the app icon, no previews are shown anymore.

Schema: org.gnome.shell.extensions.dash-to-dock
Name: click-action
Value: "minimize-or-previews"
Value: "previews"

Description: Ubuntu 21.10
Release: 21.10

gnome-shell-extension-ubuntu-dock:
  Installed: 70~ubuntu3

ProblemType: BugDistroRelease: Ubuntu 21.10
Package: gnome-shell-extension-ubuntu-dock 70~ubuntu3
ProcVersionSignature: Ubuntu 5.13.0-19.19-generic 5.13.14
Uname: Linux 5.13.0-19-generic x86_64
ApportVersion: 2.20.11-0ubuntu70
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Sat Oct 16 11:32:51 2021
EcryptfsInUse: Yes
InstallationDate: Installed on 2018-10-21 (1090 days ago)
InstallationMedia: Ubuntu 18.04 LTS "Bionic Beaver" - Release amd64 (20180426)
PackageArchitecture: allSourcePackage: gnome-shell-extension-ubuntu-dock
UpgradeStatus: Upgraded to impish on 2021-10-14 (1 days ago)

[Paul White (paulw2u)]

Can confirm. In order to see the previews you have to right-click on the application icon and then click on 'All Windows' in order to see the window preview. Previously the previews would be shown when left clicking on the application icon.

The latest version of Dash to Dock released on 17th October retains the expected functionality so an issue specific to Ubuntu Dock.

[Paul White (paulw2u)]

Upstream report:
https://github.com/micheleg/dash-to-dock/issues/1545

[Pepijn Bogaard (pbgrd)]

Here is the solution ( and the cause of the bug ):

In /<email address hidden>/appIcons.js at line 472:

change
const singleOrUrgentWindows = windows.length === 1 || !hasUrgentWindows;
to
const singleOrUrgentWindows = windows.length === 1 || hasUrgentWindows;

(basically removing the ! sign before hasUrgentWindows)

Then log-out & log-in again.

[Paul White (paulw2u)]

Thanks Pepijn, that small deletion does seem to fix the issue.

[Pepijn Bogaard (pbgrd)]

I committed the solution here:

https://git.launchpad.net/~pbgrd/ubuntu/+source/gnome-shell-extension-ubuntu-dock/commit/?h=ubuntu/devel&id=d64317c4faa07a7c42b478db2027561c7933aa13

How does this 'fix proposing' work exactly?

Thanks in advance.

[Marco Trevisan (Treviño) (3v1n0)]

Sorry Pepijn, the code of the dock is managed via github at https://github.com/micheleg/dash-to-dock/tree/ubuntu-dock

Should do a PR there, but I will handle it in next upload.

Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 72~ubuntu1

---------------
gnome-shell-extension-ubuntu-dock (72~ubuntu1) jammy; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * Revert "extension: Disable starting in the overview"
  * locations: Do not manually dispose objects (LP: #1949352, LP: #1951599)
  * po/es.po: Remove duplicated entry for Quit translation
  * docking: Delay dash animation callback at actual completion
  * utils: Fix variable in error template string
  * appIcons: In case we have no window to activate, let's just present it
  * docking: Do not try to re-add a Meta.Later if one is already queued
  * docking: Optionally disable animation to overview on startup
  * dash: Track hover on separator item so that it can contribute to scrolling
  * dash: Remove the scroll view visibility idle if triggering actor is
    destroyed
  * docking: Handle monitoring of discrete GPU not to leak signals
  * appIcons: Random cleanups to use more relevant variable names
  * appIcons: Compare workspaces instead of their indexes
  * appIcons: Ensure we only consider as urgent the ones respecting our rules
  * appIcons: Use new-window action only when requested, avoiding duplication
  * appIcons: Fixed logic on handling preview click actions (LP: #1947445)
  * stylesheet: Use some better naming for start marging value
  * stylesheet: Use scss generation for overview-icon background
  * stylesheet: Set the dash-separator color in both horizontal and vertical
    mode
  * windowPreview: Try generating previews clones on meta later only if have
    valid size (LP: 1949572)
  * utils: Remove handlers in reversed order
  * Dash: Update appIcon geometry on parent geometry changes
  * docking: Reduce the space used by the window picker / app grid
  * cleanup: Use cached settings values instead of doing C calls
  * locations: Use shell domain to translate reused strings
  * locations: Use native GIcon as location Apps-icons (LP: #1874578)
  * locations: Use native Gio.FileMonitor rate limit instead of a custom idle
  * locations: Fix typo on FileManager app (un)wrapping functions
  * locations: Fix handling of location apps on isolated workspaces mode
  * locations: Also destroy all removable devices on Removables manager
    destruction
  * locations: Only emit changed signal if a monitored device has been removed
  * locations: Only update Trash icon on changes
  * locations: Remove unmounted locations by value
  * locations: Use native AppInfo's and Shell mount operations
  * metadata: Add support for gnome-shell 42
  * fileManager1API: Cleanup the code to get windows from location path
  * fileManager1API: Keep windows paths cached so we can monitor changes
  * utils: Add support for (un)blocking signals handlers
  * locations: Smart managing wrapped windows backed applications signal
    connections
  * locations: Use proxy properties to expose private items to public object
  * locations: Chain up to parent destroy() function if any
  * locations: Manage sources as part of DtdData
  * locations: Manage windows changes in base class
  * cleanup: Move shellAppCompare under Utils as it's a generic tool
  * locations: Keep...

[Brian Murray (brian-murray)]

Hello Sebastian, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/70~ubuntu3.21.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sebastian Haderecker (shaderecker)]

Hello Brian,

I tested the new package with version "70~ubuntu3.21.10.1".
With this the preview bug has been fixed.

I performed both tests from the bug description:

1. gsettings set org.gnome.shell.extensions.dash-to-dock click-action "previews"
 - Open multiple windows for an application
 - Click on the icon, previews should be shown

2. gsettings set org.gnome.shell.extensions.dash-to-dock click-action "minimize-or-previews"
  - Open multiple windows for an application
  - Click on the icon, previews should be shown

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for gnome-shell-extension-ubuntu-dock has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 70~ubuntu3.21.10.1

---------------
gnome-shell-extension-ubuntu-dock (70~ubuntu3.21.10.1) impish; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * locations: Do not manually dispose objects (LP: #1949352, #1951599)
  * windowPreview: Try generating previews clones on meta later only if have valid size
    (LP: #1949572)
  * locations: Use native GIcon as location Apps-icons (LP: #1874578)
  * debian: Update branch info for impish

  [ nename0 ]
  * Cleanup nautilus listeners (LP: #1949352)

  [ Pepijn Bogaard ]
  * appIcons: Fixed logic on handling preview click actions (LP: #1947445)

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 25 Jan 2022 01:08:43 +0100