To support goodix fp device [27C6:63BC]

Bug #1945298 reported by Andy Chi
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Critical
Andy Chi
libfprint (Ubuntu)
Fix Released
Medium
Unassigned
Focal
Fix Released
Medium
Marco Trevisan (Treviño)
Impish
Fix Released
Medium
Marco Trevisan (Treviño)

Bug Description

https://gitlab.freedesktop.org/libfprint/libfprint/-/blob/master/libfprint/drivers/goodixmoc/goodix.c#L1507

This ID is included in upstream.

[Impact]

 * Devices have goodix [27c6:639c] fingerprint component will get
   supported.

 * This sru contains lots of fingerprint id which is not supported before, below is the comparison with impish -updates.

 * Elan:
   #impish: 0x0c4d

   Synaptics:
   #impish and focal does not have difference.

   Goodix:
   #0x609C, 0x639C, 0x63AC, 0x63BC and 0x6A94 are include in focal but not
   in impish

 * Add Synaptics fingerprint device to test in this SRU.
   VID: 06CB
   PID: 00DF

 * If user name is too short, fingerprint cannot enroll successfully
   https://gitlab.freedesktop.org/libfprint/libfprint/-/issues/428

[Test Plan]

 * Find a machine with this fingerprint device

 * set a very short user name such as "u".

 * Launch `settings` and enable `Fingerprint Login`

 * Enroll finger and then logout

 * Login system with enrolled finger

[Where problems could occur]

 * A lot of fingerprint ids is supported in this version, we didn't test
   all combination.

Andy Chi (andch)
summary: - To support goodix fp device [27C6:63bc]
+ To support goodix fp device [27C6:63BC]
Andy Chi (andch)
tags: added: oem-priority originate-from-1943207 somerville
Changed in oem-priority:
assignee: nobody → Andy Chi (andch)
importance: Undecided → Critical
Revision history for this message
Robie Basak (racb) wrote :

There's an upload for Focal in the queue, but this bug is missing SRU information. If you intend to complete that then please let us know. Otherwise we'll reject the upload from the queue.

Revision history for this message
Andy Chi (andch) wrote :

Hello @racb,
sorry for wrong context, please help to continue SRU process. Thanks.

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.7+git20210222+tod1-0ubuntu4

---------------
libfprint (1:1.90.7+git20210222+tod1-0ubuntu4) jammy; urgency=medium

  * debian/patches: Add support for new elan, goodix and synaptics drivers.
    Most of the drivers only need to list new product IDs to work with new
    devices, and including other changes that new devices may require.
    (LP: #1945296, #1945298)
  * debian/patches: Fix template struct in goodix drivers (LP: #1945296)

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 26 Oct 2021 21:24:40 +0200

Changed in libfprint (Ubuntu):
status: New → Fix Released
Andy Chi (andch)
description: updated
Andy Chi (andch)
description: updated
Changed in libfprint (Ubuntu Focal):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in libfprint (Ubuntu Impish):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in libfprint (Ubuntu Focal):
status: New → In Progress
Changed in libfprint (Ubuntu Impish):
status: New → In Progress
Andy Chi (andch)
tags: added: originate-from-1934719
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Andy, or anyone else affected,

Accepted libfprint into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.7+git20210222+tod1-0ubuntu4~21.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libfprint (Ubuntu Impish):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Andy, or anyone else affected,

Accepted libfprint into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.2+tod1-0ubuntu1~20.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libfprint (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Andy Chi (andch) wrote :

Test on machine with goodix ID [27c6:63bc]
[lsb_release]
Impish

[libfprint]
1:1.90.7+git20210222+tod1-0ubuntu4~21.10.1

[steps]
* Find a machine with this fingerprint device

* set a very short user name such as "u".

* Launch `settings` and enable `Fingerprint Login`

* Enroll finger and then logout

* Login system with enrolled finger

Test passed.

Revision history for this message
Andy Chi (andch) wrote :

Test on machine with goodix ID [27c6:63bc]
[lsb_release]
Focal

[libfprint]
1:1.90.2+tod1-0ubuntu1~20.04.5

[steps]
* Find a machine with this fingerprint device

 * set a very short user name such as "u".

 * Launch `settings` and enable `Fingerprint Login`

 * Enroll finger and then logout

 * Login system with enrolled finger

Test passed.

Revision history for this message
Andy Chi (andch) wrote :

Test on machine with Synaptics ID [06cb:00df]
[lsb_release]
Impish

[libfprint]
1:1.90.7+git20210222+tod1-0ubuntu4~21.10.1

[steps]
* Find a machine with this fingerprint device

* set a very short user name such as "u".

* Launch `settings` and enable `Fingerprint Login`

* Enroll finger and then logout

* Login system with enrolled finger

Test passed.

Revision history for this message
Andy Chi (andch) wrote :

Test on machine with Synaptics ID [06cb:00df]
[lsb_release]
Focal

[libfprint]
1:1.90.2+tod1-0ubuntu1~20.04.5

[steps]
* Find a machine with this fingerprint device

* set a very short user name such as "u".

* Launch `settings` and enable `Fingerprint Login`

* Enroll finger and then logout

* Login system with enrolled finger

Test passed.

tags: added: verification-done verification-done-focal verification-done-impish
removed: verification-needed verification-needed-focal verification-needed-impish
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.7+git20210222+tod1-0ubuntu4~21.10.1

---------------
libfprint (1:1.90.7+git20210222+tod1-0ubuntu4~21.10.1) impish; urgency=medium

  * debian/patches: Add support for new elan, goodix and synaptics drivers.
    Most of the drivers only need to list new product IDs to work with new
    devices, and including other changes that new devices may require.
    (LP: #1945296, #1945298)
  * debian/patches: Fix template struct in goodix drivers (LP: #1945296)

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 26 Oct 2021 21:40:36 +0200

Changed in libfprint (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for libfprint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libfprint - 1:1.90.2+tod1-0ubuntu1~20.04.5

---------------
libfprint (1:1.90.2+tod1-0ubuntu1~20.04.5) focal; urgency=medium

  * debian/patches: Add support for goodix and new elan and synaptics devices.
    Elan and synaptics drivers only need to list new product IDs to work with
    new devices, and including other changes that new devices may require.
    While adding the new goodix moc driver, that is already part of many
    stable releases now, coming with full unit test and latest supported
    devices. (LP: #1945296, #1945298)
  * debian/patches: Fix template struct in goodix drivers (LP: #1945296)

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 27 Oct 2021 00:07:47 +0200

Changed in libfprint (Ubuntu Focal):
status: Fix Committed → Fix Released
Mathew Hodson (mhodson)
Changed in libfprint (Ubuntu):
importance: Undecided → Medium
Changed in libfprint (Ubuntu Focal):
importance: Undecided → Medium
Changed in libfprint (Ubuntu Impish):
importance: Undecided → Medium
Changed in oem-priority:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.