Installing non-free drives fails due to simple-plugins calling `ubuntu-drivers autoinstall ...`

[Łukasz Zemczak]

[Impact]

Currently installing bionic 18.04.6 candidate images on a system that uses non-free drivers (via ubuntu-drivers) will fail installing those additional drivers. The reason for that is that the call to simple-plugins fails as it tries to execute `ubuntu-drivers autoinstall (...) --package-list (...)`, which is syntax that has been deprecated in the current ubuntu-drivers-common package.

The fix is to use `ubuntu-drivers install ...` as we do for focal+.

[Test Case]

Rebuild images with the -proposed ubiquity (or hack it in manually to an iso), perform installation on a system using ubuntu-drivers (for instance, NVidia GPU), check "Install third-party software...", finish installation and check if the installed system has the required drivers installed.
Additionally a quick browse through the syslog of the ubiquity installation would be a nice double-check.

[Regression Potential]

Currently installing ubuntu-drivers via ubiquity does not work at all, so the only regression here is that the new argument might be somehow incomplete causing not all drivers to be installed.

[Łukasz Zemczak (sil2100)]

Ok, basically this one is fixed with https://git.launchpad.net/ubiquity/commit/?id=28779054c060dea4fe2376b8e7275a634fbfa949 . But then another bug surfaces, possibly this old one?

https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1900888

[Łukasz Zemczak (sil2100)]

...ok, nevermind. This is NOT a regression then!

[Brian Murray (brian-murray)]

Hello Łukasz, or anyone else affected,

Accepted ubiquity into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/18.04.14.17 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Tested 18.04.14.17 from bionic-proposed with the current 18.04.6 candidate images and the ubuntu-drivers call no longer fails.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubiquity - 18.04.14.17

---------------
ubiquity (18.04.14.17) bionic; urgency=medium

  * scripts/simple-plugins: ubuntu-drivers autoinstall is now deprecated, use
    'install' instead (LP: #1943594).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Tue, 14 Sep 2021 15:28:18 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for ubiquity has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.