[SRU] It will take about 90+ seconds to open the 'Nvidia settings' app when 'Power Saving mode' running.

[Shengyao Xue]

[Impact]
On some I+N configs, It will take about 90+ seconds to open the 'Nvidia settings' window when 'Power Saving mode' running.

[Fix]
do not read config file if Nvidia driver did not loaded:

change nvidia-settings/src/nvidia-settings.c

    if (!op->no_load) {
        ret = nv_read_config_file(op, op->config, op->ctrl_display,
                                  p, &conf, &systems);

to
    if (!op->no_load && systems.n != 0) {
        ret = nv_read_config_file(op, op->config, op->ctrl_display,
                                  p, &conf, &systems);

[Test]
1. Install Ubuntu image.
2. Boot and login the system.
3. Open 'Nvidia Settings' app
4. Select the prime is 'Power saving' mode
5. Reboot system and login
6. Open 'Nvidia Settings' app
7. Verify the result

[Where problems will occur]
the "systems.n" gets from
    NvCtrlConnectToSystem(op->ctrl_display, &systems);
If there is a possibility that systems.n is zero and we still need to read nvidia config file, then it will be a problem. I tried and cannot find a situation like that.

[Shengyao Xue (xueshengyao)]

This is the debdiff for Focal, Thanks.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "nvidia-settings_470.57.01-0ubuntu0.20.04.1-to-470.57.01-0ubuntu1.20.04.1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Shengyao Xue (xueshengyao)]

This is the debdiff for Hirsute, Thanks.

[Shengyao Xue (xueshengyao)]

This is the debdiff for Impish, Thanks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-settings - 470.57.01-0ubuntu2

---------------
nvidia-settings (470.57.01-0ubuntu2) impish; urgency=medium

  * debian/patches/17_do_not_read_config_on_power_saving_mode.patch:
    - Do not read config on Power Saving mode. (LP: #1943160).

 -- Shengyao Xue <email address hidden> Fri, 10 Sep 2021 00:42:38 +0800

[Brian Murray (brian-murray)]

Are there any plans to fix this in Ubuntu 21.04 (hirsute)?

[Shengyao Xue (xueshengyao)]

@Brian, Thanks for the concern. #3 is the debdiff for Hirsute. I don't know is there any action left I can do.

[Brian Murray (brian-murray)]

Hello Shengyao, or anyone else affected,

Accepted nvidia-settings into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-settings/470.57.01-0ubuntu0.21.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Shengyao, or anyone else affected,

Accepted nvidia-settings into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-settings/470.57.01-0ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Shengyao Xue (xueshengyao)]

Tested nvidia-settings package in focal-proposed on a ThinkPad P1, this issue was fixed.

[Shengyao Xue (xueshengyao)]

Installed 21.04 on ThinkPad P1 and installed nvidia-settings package in hirsute-proposed, this issue was fixed.

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for nvidia-settings has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-settings - 470.57.01-0ubuntu0.20.04.2

---------------
nvidia-settings (470.57.01-0ubuntu0.20.04.2) focal; urgency=medium

  * debian/patches/17_do_not_read_config_on_power_saving_mode.patch:
    - Do not read config on Power Saving mode. (LP: #1943160).

 -- Shengyao Xue <email address hidden> Fri, 10 Sep 2021 00:42:38 +0800

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-settings - 470.57.01-0ubuntu0.21.04.2

---------------
nvidia-settings (470.57.01-0ubuntu0.21.04.2) hirsute; urgency=medium

  * debian/patches/17_do_not_read_config_on_power_saving_mode.patch:
    - Do not read config on Power Saving mode. (LP: #1943160).

 -- Shengyao Xue <email address hidden> Fri, 10 Sep 2021 00:31:29 +0800