autopkgtest failure (proxy-related)

[Sergio Durigan Junior]

golang-github-google-martian's tests are failing on Ubuntu's autopkgtest because of proxy issues:

=== CONT TestIntegrationHTTP100Continue
    proxy_test.go:277: res.StatusCode: got 503, want 200
2021/05/23 01:04:47 INFO: martian: closing down proxy
2021/05/23 01:04:47 INFO: martian: waiting for connections to close
2021/05/23 01:04:47 INFO: martian: all connections closed
--- FAIL: TestIntegrationHTTP100Continue (0.06s)
=== CONT TestIntegrationHTTP
2021/05/23 01:04:47 INFO: martian: closing down proxy
2021/05/23 01:04:47 INFO: martian: waiting for connections to close
2021/05/23 01:04:47 INFO: martian: all connections closed
--- PASS: TestIntegrationHTTP (0.00s)
FAIL
FAIL github.com/google/martian 28.004s

[Sergio Durigan Junior (sergiodj)]

This debdiff works around the problem. The rationale is the same as the one from LP #1942491: we need to unset $http_proxy before running the tests.

A PPA with the proposed change is here:

https://launchpad.net/~sergiodj/+archive/ubuntu/golang-github-google-martian-autopkgtest-fix

The package is building as I write this; I will post the autopkgtest results once they're available, but I was able to reproduce the problem locally and then confirm that it doesn't manifest with the patch.

[Lucas Kanashiro (lucaskanashiro)]

Thanks for the patch Sergio! LGTM, +1. Just make sure the tests will pass in the autopkgtest infrastructure.

[Sergio Durigan Junior (sergiodj)]

Thanks, Lucas.

autopkgtest is now passing:

https://autopkgtest.ubuntu.com/results/autopkgtest-impish-sergiodj-golang-github-google-martian-autopkgtest-fix/?format=plain

Uploaded:

$ dput golang-github-google-martian_2.1.0+git20181219.d0b5ad3-3ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/golang-github-google-martian/golang-github-google-martian_2.1.0+git20181219.d0b5ad3-3ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/golang-github-google-martian/golang-github-google-martian_2.1.0+git20181219.d0b5ad3-3ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading golang-github-google-martian_2.1.0+git20181219.d0b5ad3-3ubuntu1.dsc: done.
  Uploading golang-github-google-martian_2.1.0+git20181219.d0b5ad3-3ubuntu1.debian.tar.xz: done.
  Uploading golang-github-google-martian_2.1.0+git20181219.d0b5ad3-3ubuntu1_source.buildinfo: done.
  Uploading golang-github-google-martian_2.1.0+git20181219.d0b5ad3-3ubuntu1_source.changes: done.
Successfully uploaded packages.

[Launchpad Janitor (janitor)]

This bug was fixed in the package golang-github-google-martian - 2.1.0+git20181219.d0b5ad3-3ubuntu1

---------------
golang-github-google-martian (2.1.0+git20181219.d0b5ad3-3ubuntu1) impish; urgency=medium

  * d/rules: Override dh_auto_test and unset $http_proxy before invoking
    the target. (LP: #1942639)

 -- Sergio Durigan Junior <email address hidden> Fri, 03 Sep 2021 15:45:53 -0400