test failure with some network configurations

[Dan Bungert]

vip-manager behavior_test can fail, depending on the device network configuration. If the test device has a network device of type ether and a zero hardware address, and it selects this network device as the one to use, the tests will fail.

Example failure:

https://autopkgtest.ubuntu.com/results/autopkgtest-impish/impish/armhf/v/vip-manager/20210901_213607_5779b@/log.gz

2021/09/01 21:35:37 Problems with generating the virtual ip manager: Cannot run vip-manager on the loopback device
as its hardware address is the local address (00:00:00:00:00:00),
which prohibits sending of gratuitous ARP messages

Here is abbreviated output of 'ip link show' for one such test device:

3: gretap0@NONE: <BROADCAST,MULTICAST> mtu 1476 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
44262: eth0@if44263: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1458 qdisc noqueue state UP mode DEFAULT group default qlen 1000
    link/ether 00:16:3e:0f:a3:f7 brd ff:ff:ff:ff:ff:ff link-netnsid 0

In this example, gretap0 will be the chosen network device, but will fail at runtime of vip-manager due to the all-zeros mac address. Instead, eth0 should be chosen.

[Brian Murray (brian-murray)]

 $ dput vip-manager_1.0.1-4ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /tmp/pkgs/impish/vip-manager_1.0.1-4ubuntu1_source.changes: Valid signature from 1E918B66765B3E31
Checking signature on .dsc
gpg: /tmp/pkgs/impish/vip-manager_1.0.1-4ubuntu1.dsc: Valid signature from 1E918B66765B3E31
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading vip-manager_1.0.1-4ubuntu1.dsc: done.
  Uploading vip-manager_1.0.1-4ubuntu1.debian.tar.xz: done.
  Uploading vip-manager_1.0.1-4ubuntu1_source.buildinfo: done.
  Uploading vip-manager_1.0.1-4ubuntu1_source.changes: done.
Successfully uploaded packages.

[Launchpad Janitor (janitor)]

This bug was fixed in the package vip-manager - 1.0.1-4ubuntu1

---------------
vip-manager (1.0.1-4ubuntu1) impish; urgency=medium

  * d/p/lp-1942375-test-device-selection.patch: Improve the behavior test by
    selecting network devices that are both of class ether and have a non-zero
    hardware address (LP: #1942375).

 -- Dan Bungert <email address hidden> Fri, 03 Sep 2021 11:22:42 -0600