openafs dkms: FTBFS for linux-hwe-5.13

[Paolo Pisati]

[Impact]

openafs FTBFS when built for linux-hwe-5.13:

/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_compat.h: In function ‘afs_inode_setattr’:
/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_compat.h:46:26: error: passing argument 1 of ‘inode->i_op->setattr’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   46 | # define f_dentry f_path.dentry

/var/lib/dkms/openafs/1.8.4pre1/build/src/afs/LINUX/osi_compat.h:528:46: note: in expansion of macro ‘f_dentry’
  528 | code = inode->i_op->setattr(afile->filp->f_dentry, newattrs);

[Fix]

Import upstream patches from http://git.openafs.org/git/openafs.git:

c747b15dd2 Linux 5.12: Add user_namespace param to inode ops
5a5d358b02 Linux: Create wrapper for setattr_prepare

[How to test]

$ sudo apt-get install openafs

and check build log/dkms status.

Builds fine with:

openafs, 1.8.4pre1, 5.4.0-83-generic, x86_64: installed
openafs, 1.8.4pre1, 5.8.0-64-generic, x86_64: installed
openafs, 1.8.4pre1, 5.11.0-23-generic, x86_64: installed
openafs, 1.8.4pre1, 5.13.0-14-generic, x86_64: installed

[Where problems could occur]

Potential regressions with old kernels.

[Brian Murray (brian-murray)]

Hello Paolo, or anyone else affected,

Accepted openafs into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.8.4~pre1-1ubuntu2.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

I can confirm that openafs/1.8.4~pre1-1ubuntu2.3 can be installed and built on focal against the linux (5.4), linux-hwe-5.11 and linux-hwe-5.13 kernels.

* linux
- amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/o/openafs/20211019_112122_0a40a@/log.gz
- arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/o/openafs/20211019_114246_ecfc6@/log.gz
- armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/armhf/o/openafs/20211019_114754_0a40a@/log.gz
- ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/o/openafs/20211019_120415_0a40a@/log.gz
- s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/o/openafs/20211019_112255_0a40a@/log.gz

* linux-hwe-5.11
- amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/o/openafs/20211019_112707_685ba@/log.gz
- arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/o/openafs/20211019_115944_8be98@/log.gz
- armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/armhf/o/openafs/20211019_120635_685ba@/log.gz
- ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/o/openafs/20211019_121552_685ba@/log.gz
- s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/o/openafs/20211019_112337_07b53@/log.gz

* linux-hwe-5.13
- amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/o/openafs/20211019_112959_cd575@/log.gz
- arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/o/openafs/20211019_115005_92e8a@/log.gz
- armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/armhf/o/openafs/20211019_121051_2e497@/log.gz
- ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/o/openafs/20211019_125157_2e497@/log.gz
- s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/o/openafs/20211019_112512_92e8a@/log.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package openafs - 1.8.4~pre1-1ubuntu2.3

---------------
openafs (1.8.4~pre1-1ubuntu2.3) focal; urgency=medium

  * Linux 5.13 compatibility fixes (LP: #1941720):
    - debian/patches/0024-Linux-Create-wrapper-for-setattr_prepare.patch
    - debian/patches/0025-Linux-5.12-Add-user_namespace-param-to-inode-ops.patch

 -- Paolo Pisati <email address hidden> Thu, 26 Aug 2021 09:18:09 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for openafs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.