gost-crypto dkms: FTBFS for linux-hwe-5.13

[Paolo Pisati]

[Impact]

gost-crypto FTBFS when built for linux-hwe-5.13:

/var/lib/dkms/gost-crypto/0.3.2/build/testmgr.c:1000:48: error: implicit declaration of function ‘crypto_cipher_tfm’; did you mean ‘crypto_skcipher_tfm’? [-Werror=implicit-function-declaration]:

1000 | const char *algo = crypto_tfm_alg_driver_name(crypto_cipher_tfm(tfm));

[Fix]

Import Impish patch:

0001-crypto-update-crypto-header-and-namespace.patch

as

debian/patches/0002-crypto-update-crypto-header-and-namespace.patch

[How to test]

$ sudo apt-get install gost-crypto-dkms

and check build log/dkms status.

Builds fine with:

gost-crypto, 0.3.2, 5.13.0-14-generic, x86_64: installed
gost-crypto, 0.3.2, 5.11.0-23-generic, x86_64: installed
gost-crypto, 0.3.2, 5.8.0-64-generic, x86_64: installed
gost-crypto, 0.3.2, 5.4.0-83-generic, x86_64: installed

[Where problems could occur]

Potential regressions with old kernels.

[Brian Murray (brian-murray)]

Hello Paolo, or anyone else affected,

Accepted gost-crypto into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gost-crypto/0.3.2-2ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

I can confirm that gost-crypto/0.3.2-2ubuntu0.3 can be installed and built on focal against the linux (5.4), linux-hwe-5.11 and linux-hwe-5.13 kernels.

* linux
- amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/g/gost-crypto/20211019_110836_73bc0@/log.gz
- arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/g/gost-crypto/20211019_110927_47370@/log.gz
- armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/armhf/g/gost-crypto/20211019_111128_1e722@/log.gz
- ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/g/gost-crypto/20211019_111847_73bc0@/log.gz
- s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/g/gost-crypto/20211019_111338_1e722@/log.gz

* linux-hwe-5.11
- amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/g/gost-crypto/20211019_110848_2f1a2@/log.gz
- arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/g/gost-crypto/20211019_111002_2f1a2@/log.gz
- armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/armhf/g/gost-crypto/20211019_111215_b4119@/log.gz
- ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/g/gost-crypto/20211019_112138_4a3bd@/log.gz
- s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/g/gost-crypto/20211019_110922_bf687@/log.gz

* linux-hwe-5.13
- amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/g/gost-crypto/20211019_111448_4534e@/log.gz
- arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/g/gost-crypto/20211019_111809_c140e@/log.gz
- armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/armhf/g/gost-crypto/20211019_111256_c140e@/log.gz
- ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/g/gost-crypto/20211019_120250_c140e@/log.gz
- s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/g/gost-crypto/20211019_111438_c140e@/log.gz

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gost-crypto has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gost-crypto - 0.3.2-2ubuntu0.3

---------------
gost-crypto (0.3.2-2ubuntu0.3) focal; urgency=medium

  * Linux 5.13 compatibility (LP: #1941187)
    - debian/patches/0002-crypto-update-crypto-header-and-namespace.patch

 -- Paolo Pisati <email address hidden> Wed, 25 Aug 2021 13:11:12 +0000