thrift/0.13.0-6 FTBFS in Impish

[Lucas Kanashiro]

thrift/0.13.0-6 failed to build and it is blocked in impish-proposed for a while. See the full build log:

https://launchpadlibrarian.net/549888170/buildlog_ubuntu-impish-amd64.thrift_0.13.0-6_BUILDING.txt.gz

The error is caused by the lack of PHP 8 support in this version. Here is the upstream bug for this:

https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-5318?filter=allissues

It was fixed by this commit:

https://github.com/apache/thrift/commit/b04e39a7e91d7828cce9168c4660b89400930ee5

[Lucas Kanashiro (lucaskanashiro)]

After backporting the upstream commit mentioned in the description, I got another error, but now related to the Go extension. Go 1.16 expects a go.mod file by default and thrift Go extension does not contain that, let's set GO111MODULE to off to avoid this error.

[Lucas Kanashiro (lucaskanashiro)]

The attached debdiff fixes the FTBFS.

[Lucas Kanashiro (lucaskanashiro)]

Added an extra DEP-3 header to the patch.

[Lucas Kanashiro (lucaskanashiro)]

I uploaded the proposed changes to this PPA:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/testing

[Sergio Durigan Junior (sergiodj)]

Thanks, Lucas.

The debdiff LGTM; I built the package locally with it. A couple of minor comments:

1) Don't forget to remove the "~ppa1" suffix from the version string :-).

2) When pointing to an upstream bug, DEP-3 says that we should just use the "Bug:" header (without the "-Upstream" suffix).

+1 with those fixed.

[Lucas Kanashiro (lucaskanashiro)]

Thanks for the review Sergio. I addressed your comments and already uploaded the package.

[Launchpad Janitor (janitor)]

This bug was fixed in the package thrift - 0.13.0-6ubuntu1

---------------
thrift (0.13.0-6ubuntu1) impish; urgency=medium

  * d/p/THRIFT-5318_support_php8.patch: Backport upstream patch to add support
    for PHP 8 (LP: #1940473).
  * d/rules: export GO111MODULE=off, this will make go.mod file not mandatory.

 -- Lucas Kanashiro <email address hidden> Wed, 18 Aug 2021 17:05:38 -0300