1.99.6 tests fail on s390x - byteorder
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Pyspread |
Fix Released
|
Unknown
|
|||
pyspread (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
After fixing bug 1937058 it still is blocked as on s390x there are further fails around code that already tries to handle byteorder but seems to fail on big endian.
Example test log:
https:/
pyspread/
=======
_______
def test_RGB32():
qimg = QtGui.QImage(320, 240, QtGui.QImage.
v = _qimageview(qimg)
> assert_equal(v[10, 12], 0xff123456
pyspread/
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
a = 4279383126, b = 1446253311
def assert_equal(a, b):
> assert a == b
E assert 4279383126 == 1446253311
pyspread/
_______
def test_ARGB32():
qimg = QtGui.QImage(320, 240, QtGui.QImage.
v = _qimageview(qimg)
> assert_equal(v[10, 12], 0xff123456
pyspread/
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
a = 4279383126, b = 1446253311
def assert_equal(a, b):
> assert a == b
E assert 4279383126 == 1446253311
tags: | added: update-excuse |
Changed in pyspread: | |
status: | Unknown → Fix Released |
Reproducible on s390x via:
$ apt install python3-matplotlib python3-numpy python3-pyqt5 python3-pyqt5.qtsvg python3-pytest python3-pytest-xvfb python3-setuptools 1.99.6/ pyspread test_qimageview .py
$ apt build-dep pyspread
$ cd pyspread-
$ py.test-3 lib/test/
It expects
0xff123456
or on big endian
0x563412ff
That is like a full reversed number.
But we get actually what is expected on non big endian.
E assert 4279383126 == 1446253311
And 4279383126 == 0xff123456
So the byte swap seems to be handled elsewhere and here it does NOT come up big-endianized.
If that is a test that was mistakenly made too big endian ready OR if there is an underlying issue that needs to be fixed - I don't know.
I'll fix the test in some Ubuntu delta for now (it does not seem to be a regression, but a new test coverage that was missing before) and report it upstream for a long term resolution.