[SRU] Reenabling toolbar in two-pane view causes the toolbar on each pane to think its two separate nemo main toolbars

[Joshua Peisach]

Ubuntu Cinnamon Remix 20.04.2:

[Impact]

 * When enabling two-pane view (F3, or View -> Extra Pane), and going to
 View and disabling then reenabling the toolbar, all the information that
 was only on one side of the toolbar is now on both sides. This leads to
 some weird congestion.

 * In the attached screenshots you can clearly tell something is wrong. It
 doesn't seem intntional to include a bunch of buttons and whatever thrown
 and cobbled together on both sides. Instead it should be kept on one.

 * The upload fixes the bug by using the same functions used to generate
 the toolbar/panes to check for the active window pane, and that active
 window is where the toolbar will be placed.

[Test Plan]

 * Open Nemo

 * Enable dual-pane view. Press F3 or go to View, and select Extra Pane.

 * You can play around with the different directories in different tabs if
 you so wish.

 * Go to View -> Main Toolbar. Disable it, then re-enable it.

 * Pre-upload: All the buttons are cobbled together at the top.

[Where problems could occur]

 * Dealing with the toolbars and panes can be a little bit dangerous, and
 be a pain (especially with memory leakage)

 * Since Nemo has lots of toolbar and panel customizations and many other
 modes, considering the large amount of patches that continue to come out
 for Nemo it is possible that a minor regression can open, although for
 the most part it is unlikely since this patch has been around for over a
 year.

[Other Info]

 * This is a patch put released after the deadline for package updates
 for focal (4.4.3) and technically this would bump the nemo version.
 However, this is only on the 4.4x maintenance branch and not going
 forward. This would be a focal-only patch.

 * I'll do my research for any regressions this could've possibly caused.

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: nemo 4.4.2-2
ProcVersionSignature: Ubuntu 5.4.0-77.86-generic 5.4.119
Uname: Linux 5.4.0-77-generic x86_64
ApportVersion: 2.20.11-0ubuntu27.18
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: X-Cinnamon
Date: Mon Jul 12 12:02:41 2021
InstallationDate: Installed on 2021-05-17 (56 days ago)
InstallationMedia: ubuntucinnamonremix "@BASECODENAME" (20210204)
SourcePackage: nemo
UpgradeStatus: No upgrade log present (probably fresh install)

[Joshua Peisach (itzswirlz)]

Patch available

[Joshua Peisach (itzswirlz)]

Fixed patch in version

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "nemo_4.4.2-2ubuntu2.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Mathew Hodson (mhodson)]

Fixed in Ubuntu Groovy and later.
---

nemo (4.6.5-1) unstable; urgency=medium

  * New upstream version 4.6.5

 -- Norbert Preining <email address hidden> Fri, 14 Aug 2020 15:20:39 +0900

[Brian Murray (brian-murray)]

Sponsored, thanks for the debdiff.

 $ dput nemo_4.4.2-2ubuntu2_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /tmp/pkgs/focal/nemo_4.4.2-2ubuntu2_source.changes: Valid signature from 1E918B66765B3E31
Checking signature on .dsc
gpg: /tmp/pkgs/focal/nemo_4.4.2-2ubuntu2.dsc: Valid signature from 1E918B66765B3E31
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading nemo_4.4.2-2ubuntu2.dsc: done.
  Uploading nemo_4.4.2-2ubuntu2.debian.tar.xz: done.
  Uploading nemo_4.4.2-2ubuntu2_source.buildinfo: done.
  Uploading nemo_4.4.2-2ubuntu2_source.changes: done.
Successfully uploaded packages.

[Brian Murray (brian-murray)]

Hello Joshua, or anyone else affected,

Accepted nemo into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nemo/4.4.2-2ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted nemo (4.4.2-2ubuntu2) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

filemanager-actions/3.4-2 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#nemo

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Joshua Peisach (itzswirlz)]

So the patch works in Focal - same process except there is no button cobbling at the top. But what does the autopkgtest regression mean now that it is gone? It seems to not have caused an issue-this shouldn't have caused any in the first place. Now all the autopkgtests has passed. Now what?

[Brian Murray (brian-murray)]

Now that the autopkgtest has passed after a retry the only thing blocking the release of the update is somebody marking the verification as having passed.

[Joshua Peisach (itzswirlz)]

Testing again today, and the patch does continue to work. I can no longer reproduce the bug following the same steps as earlier, and I cannot find any regression as a result.

[Łukasz Zemczak (sil2100)]

I assume you tested 4.4.2-2ubuntu2, right? Always be sure to include information about what version of the package you used for testing!

[Launchpad Janitor (janitor)]

This bug was fixed in the package nemo - 4.4.2-2ubuntu2

---------------
nemo (4.4.2-2ubuntu2) focal; urgency=medium

  * Only show the active window-pane's toolbar when toggling
    toolbar visiblity (LP: #1935849)

 -- Joshua Peisach <email address hidden> Mon, 12 Jul 2021 12:36:38 -0400

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for nemo has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.