squid: build failure for Impish RISC-V

[Heinrich Schuchardt]

Building Squid for Impish on RISC-V fails.

Two problems were identified. Upstream merge request have been created:

https://github.com/squid-cache/squid/pull/855 for

tools.cc: In function ‘void enter_suid()’:
tools.cc:585:11: error: ignoring return value of ‘int setuid(__uid_t)’
declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
  585 | setuid(0);
      | ~~~~~~^~~

https://github.com/squid-cache/squid/pull/856 for

/usr/riscv64-linux-gnu/include/c++/10/ostream:611:
undefined reference to __atomic_compare_exchange_1

With suggested patches building succeeds.

Best regards

Heinrich

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Heinrich Schuchardt (xypron)]

Upstream patches have been merged in https://github.com/squid-cache/squid.

[Utkarsh Gupta (utkarsh)]

Hi Heinrich,

Since you've assigned this to yourself and set the status to "In Progress" and attached a debdiff, I am hoping that you're taking care of this and that this would need no help from the Server team side?

[Heinrich Schuchardt (xypron)]

A sponsor taking care of pushing the changes is needed as I have no upload rights.

[Thomas Ward (teward)]

I'll handle the updating and pushing to Impish later today after my errands, which will be when I'm in front of a computer.

[Utkarsh Gupta (utkarsh)]

Thanks, Thomas. I was gonna look at it on Monday but thanks for beating me to it! :D

[Thomas Ward (teward)]

Uploaded to impish-proposed. Should be building, and provided no autopkgtests fail it should migrate to impish repos on its own.

[Thomas Ward (teward)]

Unsubscribing sponsors as I've sponsored this. Server Team: do me a solid and keep an eye out for any autopkgtest failures in case I miss them - I have a lot of mail so sometimes I don't see the failure notices :P

[Utkarsh Gupta (utkarsh)]

> Server Team: do me a solid and keep an eye out for any
> autopkgtest failures in case I miss them - I have a lot
> of mail so sometimes I don't see the failure notices :P

Aye, aye, captain! Will do!

[Heinrich Schuchardt (xypron)]

Build was successful:
https://launchpad.net/ubuntu/+source/squid/4.13-10ubuntu3

[Bryce Harrington (bryce)]

Autopkgtests passed as well. All looks good to go.
squid is blocked due to openldap's transition (which itself is blocked by gnome-shell IIRC).
But looks like squid will go through without issue once all that has cleared.

https://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html#squid

[Launchpad Janitor (janitor)]

This bug was fixed in the package squid - 4.13-10ubuntu3

---------------
squid (4.13-10ubuntu3) impish; urgency=medium

  * Fix failure to build on RISC-V (LP: #1934891)

 -- Heinrich Schuchardt <email address hidden> Wed, 07 Jul 2021 14:11:51 +0200