universal-ctags FTBFS with glibc-2.33

[Athos Ribeiro]

The latest sync from Debian FTBFS [1][2]. This is due to the newer version of glibc (2.33) available in impish and in hirsute.

Since glibc in Debian unstable is at 2.31, the issue does not manifest itself there.

Moreover, this has been fixed upstream [3] and should be included in Debian when the package gets updated after the current freeze. Therefore, I am attaching a patch to unblock Ubuntu's migration, which was not forwarded to Debian. The package builds fine in impish and works as expected.

[1] https://launchpad.net/ubuntu/+source/universal-ctags/0+git20200824-1.1
[2] https://launchpad.net/ubuntu/+source/universal-ctags/0+git20200824-1.1/+build/21478505
[3] https://github.com/universal-ctags/ctags/pull/2990

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "1-0+git20200824-1.1ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Athos Ribeiro (athos-ribeiro)]

I filed [1] in Debian so the issue is known and can be tracked there in case glibc 2.33 lands in unstable before universal-ctags is updated to a new upstream version.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990784

[Athos Ribeiro (athos-ribeiro)]

This following patch deprecates the first one by adding additional information to the changelog.

A PPA with the proposed changes is available at https://launchpad.net/~athos-ribeiro/+archive/ubuntu/universal-ctags-lp1934829-glibc233/+packages

[Sergio Durigan Junior (sergiodj)]

Thanks for the patch, Athos.

A very small nit: would you mind adding a Bug-Ubuntu header to the added patch?

Also, I see that that armhf build is failing on the PPA. I haven't investigated it further to see if it's related to the patch or not.

[Sergio Durigan Junior (sergiodj)]

Ah, something else: I would rewrite the changelog entry to something like:

* d/p/0001-main-add-newfstatat-to-seccomp-rules.patch:
  Add newfstatat seccomp rule for glibc 2.33 builds. (LP: #1934829)

Note that you don't need to mention the d/p/series modification in the changelog.

[Athos Ribeiro (athos-ribeiro)]

I addressed Sergio comments regarding the changelog.

Moreover, I did dig through the armhf failure and I realized the newfstatat system call is not available there. It then falls back to calling statx, which is not in the seccomp rules, leading to failure.

I rebuilt the package with an additional fix in the same PPA, at

https://launchpad.net/~athos-ribeiro/+archive/ubuntu/universal-ctags-lp1934829-glibc233/+packages

I am attaching a new debdiff, with an additional patch to fix the armhf build failure, which I forwarded upstream at https://github.com/universal-ctags/ctags/pull/3125

[Sergio Durigan Junior (sergiodj)]

Thanks for the thorough analysis, Athos.

I noticed that upstream has already approved your PR, and I agree with your fix. I'm now happy with the rest of the debdiff as well (but I took the liberty to update the date of the d/changelog entry), so I'll go ahead and upload the package.

$ dput universal-ctags_0+git20200824-1.1ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/universal-ctags/universal-ctags_0+git20200824-1.1ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/universal-ctags/universal-ctags_0+git20200824-1.1ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading universal-ctags_0+git20200824-1.1ubuntu1.dsc: done.
  Uploading universal-ctags_0+git20200824-1.1ubuntu1.debian.tar.xz: done.
  Uploading universal-ctags_0+git20200824-1.1ubuntu1_source.buildinfo: done.
  Uploading universal-ctags_0+git20200824-1.1ubuntu1_source.changes: done.
Successfully uploaded packages.

[Robie Basak (racb)]

Unsubscribing sponsors as there is nothing left to sponsor.

[Launchpad Janitor (janitor)]

This bug was fixed in the package universal-ctags - 0+git20200824-1.1ubuntu1

---------------
universal-ctags (0+git20200824-1.1ubuntu1) impish; urgency=medium

  * Fix glibc 2.33 builds (LP: #1934829)
    - d/p/0001-main-add-newfstatat-to-seccomp-rules.patch:
      Add newfstatat seccomp rule for glibc 2.33 builds.
    - d/p/0002-main-add-statx-to-seccomp-rules.patch:
      Add statx seccomp rule for glibc 2.33 builds.

 -- Athos Ribeiro <email address hidden> Wed, 18 Aug 2021 21:46:48 -0300