Backport reprepro fixes to focal..hirsute

[Dimitri John Ledkov]

[Impact]

 * Backport 1.3 (hirsute..focal): add support for zstd compressed packages, such that one can build partial mirrors of impish with includedeb command, where the deb being included is zstd compressed one. I.e. hello.deb from impish. This upload also adds autopkgtest to check basic functionality of reprepro.

 * Backport 1.2 bugfix (groovy & focal): log messages maybe lost due to not flushing stdout/stderr. This is racy and not testable, expectation is that reprepro continues to work and prints log messages.

[Test Plan]

 * Create config file and attempt to includedeb of hello.deb downloaded from impish release

 * Check that reprepro log messages are visible.

[Where problems could occur]

 * Support for zstd compressed packages is desired in the current LTS, such that it can be used to maintain mirrors of $devel and the next LTS release. However, this results in installing additional / new zstd package. it may surprise some that a new package installation is needed. In the future, zstd support might be switched from forking zstd binary to using libzstd directly. Also maybe reprepro should switch to libarchive. However support for zstd compressed packages now, outweighs any future development work to use libzstd.

[Brian Murray (brian-murray)]

Hello Dimitri, or anyone else affected,

Accepted reprepro into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/reprepro/5.3.0-1.3~ubuntu21.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Dimitri, or anyone else affected,

Accepted reprepro into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/reprepro/5.3.0-1.3~ubuntu20.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Dimitri, or anyone else affected,

Accepted reprepro into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/reprepro/5.3.0-1.3~ubuntu20.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted reprepro (5.3.0-1.3~ubuntu20.04) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

dgit/9.10 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#reprepro

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Dimitri John Ledkov (xnox)]

(hirsute-amd64)root@ottawa:~/reprepro-5.3.0# sh -x debian/tests/import-hello.sh
+ set -e
+ mktemp -d
+ basedir=/tmp/tmp.SGiN7lfZ7f
+ cd /tmp/tmp.SGiN7lfZ7f
+ mkdir -p conf
+ cat
+ reprepro -b /tmp/tmp.SGiN7lfZ7f createsymlinks
+ pull-lp-debs hello impish
Found hello 2.10-2ubuntu3 in impish
Downloading hello_2.10-2ubuntu3_amd64.deb from archive.ubuntu.com (0.026 MiB)
+ reprepro -b /tmp/tmp.SGiN7lfZ7f includedeb impish hello_2.10-2ubuntu3_amd64.deb
Exporting indices...
(hirsute-amd64)root@ottawa:~/reprepro-5.3.0# echo $?
0
(hirsute-amd64)root@ottawa:~/reprepro-5.3.0# dpkg-query -W reprepro
reprepro 5.3.0-1.3~ubuntu21.04

[Dimitri John Ledkov (xnox)]

(groovy-amd64)root@ottawa:~/reprepro-5.3.0# sh -x debian/tests/import-hello.sh
+ set -e
+ mktemp -d
+ basedir=/tmp/tmp.uPDwCR0LzX
+ cd /tmp/tmp.uPDwCR0LzX
+ mkdir -p conf
+ cat
+ reprepro -b /tmp/tmp.uPDwCR0LzX createsymlinks
+ pull-lp-debs hello impish
Found hello 2.10-2ubuntu3 in impish
Downloading hello_2.10-2ubuntu3_amd64.deb from archive.ubuntu.com (0.026 MiB)
+ reprepro -b /tmp/tmp.uPDwCR0LzX includedeb impish hello_2.10-2ubuntu3_amd64.deb
Exporting indices...
+ dpkg-query -W reprepro
reprepro 5.3.0-1.3~ubuntu20.10

[Dimitri John Ledkov (xnox)]

(focal-amd64)root@ottawa:~/reprepro-5.3.0# sh -x -e debian/tests/import-hello.sh
+ set -e
+ mktemp -d
+ basedir=/tmp/tmp.TUZB6mbjEG
+ cd /tmp/tmp.TUZB6mbjEG
+ mkdir -p conf
+ cat
+ reprepro -b /tmp/tmp.TUZB6mbjEG createsymlinks
+ pull-lp-debs hello impish
Found hello 2.10-2ubuntu3 in impish
Downloading hello_2.10-2ubuntu3_amd64.deb from archive.ubuntu.com (0.026 MiB)
+ reprepro -b /tmp/tmp.TUZB6mbjEG includedeb impish hello_2.10-2ubuntu3_amd64.deb
Exporting indices...
+ dpkg-query -W reprepro
reprepro 5.3.0-1.3~ubuntu20.04

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for reprepro has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package reprepro - 5.3.0-1.3~ubuntu20.04

---------------
reprepro (5.3.0-1.3~ubuntu20.04) focal; urgency=medium

  * Backport Zstd compressed debs support to hirsute. LP: #1933363

reprepro (5.3.0-1.3) experimental; urgency=medium

  * Non-maintainer upload.
  * Add support for Zstd compressed debs. (LP: #1923845)

reprepro (5.3.0-1.2) unstable; urgency=medium

  * Non-maintainer upload.
  * Flush stdout and stderr before execv of an end hook (Closes: #982423)

 -- Dimitri John Ledkov <email address hidden> Wed, 23 Jun 2021 17:01:44 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package reprepro - 5.3.0-1.3~ubuntu20.10

---------------
reprepro (5.3.0-1.3~ubuntu20.10) groovy; urgency=medium

  * Backport Zstd compressed debs support to hirsute. LP: #1933363

reprepro (5.3.0-1.3) experimental; urgency=medium

  * Non-maintainer upload.
  * Add support for Zstd compressed debs. (LP: #1923845)

reprepro (5.3.0-1.2) unstable; urgency=medium

  * Non-maintainer upload.
  * Flush stdout and stderr before execv of an end hook (Closes: #982423)

 -- Dimitri John Ledkov <email address hidden> Wed, 23 Jun 2021 17:01:44 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package reprepro - 5.3.0-1.3~ubuntu21.04

---------------
reprepro (5.3.0-1.3~ubuntu21.04) hirsute; urgency=medium

  * Backport Zstd compressed debs support to hirsute. LP: #1933363

reprepro (5.3.0-1.3) experimental; urgency=medium

  * Non-maintainer upload.
  * Add support for Zstd compressed debs. (LP: #1923845)

 -- Dimitri John Ledkov <email address hidden> Wed, 23 Jun 2021 17:01:44 +0100

[Robie Basak (racb)]

The SRUs already landed related to minor version bumps (eg. 5.3.0-1.1 to 5.3.0-1.3~ubuntu20.04) and the entire set of changes were accounted and considered for SRU purposes by the SRU documentation provided.

This doesn't apply to the Bionic Unapproved upload though, as 5.1.1-1 to 5.3.0-1.3~ubuntu18.04.1 is more of a major change and some of the changes look like they may be functional and unsuitable for SRU (eg. "drop "FILE LOCATION" headers from Contents files").

If you'd like a backport to be considered under the SRU process, please update the SRU description to provide appropriate justification so the SRU team can properly consider this.

[Robie Basak (racb)]

An upload of reprepro to bionic-proposed has been rejected from the upload queue for the following reason: "Includes changes not normally acceptable for an SRU with no explanation.".

[Chris Halse Rogers (raof)]

Hello Dimitri, or anyone else affected,

Accepted reprepro into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/reprepro/5.1.1-1ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Dan Streetman (ddstreet)]

ubuntu@lp1933363-b:~/reprepro-5.3.0$ sh -x ./debian/tests/import-hello.sh
+ set -e
+ mktemp -d
+ basedir=/tmp/tmp.Xo2xvriO7R
+ cd /tmp/tmp.Xo2xvriO7R
+ mkdir -p conf
+ cat
+ reprepro -b /tmp/tmp.Xo2xvriO7R createsymlinks
+ pull-lp-debs hello impish
Found hello 2.10-2ubuntu3 in impish
Downloading hello_2.10-2ubuntu3_amd64.deb from archive.ubuntu.com (0.026 MiB)
+ reprepro -b /tmp/tmp.Xo2xvriO7R includedeb impish hello_2.10-2ubuntu3_amd64.deb
Exporting indices...

ubuntu@lp1933363-b:~/reprepro-5.3.0$ dpkg -l|grep reprep
ii reprepro 5.1.1-1ubuntu18.04.1 amd64 Debian package repository producer

[Launchpad Janitor (janitor)]

This bug was fixed in the package reprepro - 5.1.1-1ubuntu18.04.1

---------------
reprepro (5.1.1-1ubuntu18.04.1) bionic; urgency=medium

  * 0003-Add-Zstd-support.patch:
    add support for zstd (LP: #1933363)

 -- Dan Streetman <email address hidden> Mon, 13 Jun 2022 15:51:58 -0400