Revert background key patch removal breaks dependent packages

[fossfreedom]

in the package gnome-desktop3 there is a custom ubuntu patch that tries to write to the draw-background key that has now been removed in gsettings-desktop-schemas 40.0-1ubuntu1

All packages that depend on the gnome-desktop3 library now crash such as budgie-desktop

Suggestion - either re-add the patch again ... or revert the gnome-desktop3 custom patch.

The latter option changes the symbols so probably I'm guessing a so-name version bump is needed and any dependent packages need a rebuild?

I'll try to locally rebuild gnome-desktop3 without the custom ubuntu patch to see what happens with budgie-desktop

ProblemType: Bug
DistroRelease: Ubuntu 21.10
Package: gsettings-desktop-schemas 40.0-1ubuntu1
ProcVersionSignature: Ubuntu 5.11.0-20.21+21.10.1-generic 5.11.21
Uname: Linux 5.11.0-20-generic x86_64
ApportVersion: 2.20.11-0ubuntu67
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: Budgie:GNOME
Date: Mon Jun 14 20:52:16 2021
InstallationDate: Installed on 2021-06-14 (0 days ago)
InstallationMedia: Ubuntu-Budgie 21.10 "Impish Indri" - Alpha amd64 (20210614)
PackageArchitecture: all
SourcePackage: gsettings-desktop-schemas
UpgradeStatus: No upgrade log present (probably fresh install)

[fossfreedom (fossfreedom)]

Just a follow-up - so recompiling budgie-desktop with a rebuilt gnome-desktop3 bumped with a so-name of 20 stops budgie crashing. There are other issues - but highly likely because other packages need to be rebuilt with the bumped so-name package version.

Enclosed a debdiff if the soname change is deemed the way forward

Note - apt-rdepends libgnome-desktop-3-19 (current version) seems to show lots and lots of reverse dependencies

[fossfreedom (fossfreedom)]

As discussed with Marco Trevisan on IRC https://irclogs.ubuntu.com/2021/06/16/%23ubuntu-desktop.html#t14:06 Two potential solutions here.

Attached is a simple debdiff to drop the git-revert patch without amending the so-name

[fossfreedom (fossfreedom)]

From the above - I've attached the alternative solution to remove the read/write of the draw_background key without removing the patch library functions

[Marco Trevisan (Treviño) (3v1n0)]

So the function isn't really used anywhere we care about, so I think we can just drop it

https://paste.ubuntu.com/p/tyN5Vp99Fj/

[fossfreedom (fossfreedom)]

Thanks Marco - Ubuntu Budgie packageset doesnt cover this - please can you sponsor the upload?

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-desktop3 - 3.38.5-1ubuntu3

---------------
gnome-desktop3 (3.38.5-1ubuntu3) impish; urgency=medium

  [ David Mohammed ]
  * d/p/git_revert_draw_background.patch:
    - Drop patch since gnome-settings-schemas v40 has removed the
      draw_background key and nothing uses it in the archive nowadays,
      so there's no need to rename the package nor add breaks (as it's latest
      customer was nautilus 3.26, and so bionic) (LP: #1931901)

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 17 Jun 2021 23:56:29 +0200

[Khurshid Alam (khurshid-alam)]

Unity-settings-daemon is still using that draw-background key.

[Marco Trevisan (Treviño) (3v1n0)]

Yeah, wasn't using the libgnome-desktop3 API though, so we should just drop it from unity-settings-daemon.