Correct skin font

Bug #1931826 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Evonne Cheung
20.10
Fix Released
High
Unassigned
21.04
Fix Released
High
Unassigned

Bug Description

When a custom font is used in a skin, it is not displayed in the header or block heading, potentially due to the fact that we made style changes.

Evonne, please look into the fonts used on a page when a skin is applied and in which areas a particular font declaration should be used. We have the three big areas of header, block heading, and text, but 'Comments' for example, don't change their font based on any of these.

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11832

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11832
Committed: https://git.mahara.org/mahara/mahara/commit/9b2987d0b67e8007df754b2ce2b499388cb503f6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9b2987d0b67e8007df754b2ce2b499388cb503f6
Author: Evonne <email address hidden>
Date: Mon Jun 21 12:29:46 2021 +1200

Bug 1931826 Correct skin font and colours

Rule is everything but the comments at the bottom, modules, contextual
help, forms, buttons, input, menu dropdowns, page updated info, header
and footer.

behatnotneeded

Change-Id: I555335c8248c98e0d8c83330bb2af978ea19bebc

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11833

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11834

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11834
Committed: https://git.mahara.org/mahara/mahara/commit/3fc7bca72fe885f74c14c37c3f09fbae1a77730a
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 3fc7bca72fe885f74c14c37c3f09fbae1a77730a
Author: Evonne <email address hidden>
Date: Mon Jun 21 12:29:46 2021 +1200

Bug 1931826 Correct skin font and colours

Rule is everything but the comments at the bottom, modules, contextual
help, forms, buttons, input, menu dropdowns, page updated info, header
and footer.

behatnotneeded

Change-Id: I555335c8248c98e0d8c83330bb2af978ea19bebc
(cherry picked from commit 9b2987d0b67e8007df754b2ce2b499388cb503f6)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11833
Committed: https://git.mahara.org/mahara/mahara/commit/d5663216d0521e85f611b4a0d1ef979118c85add
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_STABLE

commit d5663216d0521e85f611b4a0d1ef979118c85add
Author: Evonne <email address hidden>
Date: Mon Jun 21 12:29:46 2021 +1200

Bug 1931826 Correct skin font and colours

Rule is everything but the comments at the bottom, modules, contextual
help, forms, buttons, input, menu dropdowns, page updated info, header
and footer.

behatnotneeded

Change-Id: I555335c8248c98e0d8c83330bb2af978ea19bebc
(cherry picked from commit 9b2987d0b67e8007df754b2ce2b499388cb503f6)

no longer affects: mahara/21.10
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.