[apparmor] Segfault in logs with apparmor enabled

[Dariusz Gadomski]

[Impact]

 * With apparmor enabled (and usr.bin.firefox in enforce mode) there is a crash happening every time right after launching Firefox.

[Test Plan]

 * sudo aa-enforce /etc/apparmor.d/usr.bin.firefox

 * launch Firefox

 * See a similar segfault reported in the syslog:
Jun 10 17:25:40 ubuntu kernel: [ 86.775837] firefox[1765]: segfault at 0 ip 00007f724dd06384 sp 00007fffa7aec450 error 6 in libxul.so[7f724a483000+53b2000]
Jun 10 17:25:40 ubuntu kernel: [ 86.775843] Code: 00 0f 1f 44 00 00 50 80 3d f8 56 4c 04 00 74 02 58 c3 c6 05 ed 56 4c 04 01 48 8d 05 24 2c fa 02 48 8b 0d 77 f0 3a 04 48 89 01 <c7> 04 25 00 00 00 00 8d 01 00 00 e8 74 63 78 fc 66 2e 0f 1f 84 00

[Where problems could occur]

The fix adds additional paths to firefox apparmor profile (e.g. affecting /sys/devices/pci* and RealtimeKit1). When using deb version of firefox the browser may chose a different code path to execute than before, so it may affect hw acceleration (the sysfs paths were used by libxul) and audio.
Maybe rendering artifacts and audio sync issues in videos.

[Other Info]

[Iain Lane (laney)]

(Just assigning to clean the report)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Dariusz Gadomski (dgadomski)]

Attaching a fix proposal for jammy.

[Olivier Tilloy (osomon)]

Thanks Dariusz!
Fix committed with https://bazaar.launchpad.net/~mozillateam/firefox/firefox.jammy/revision/1539, it will be in the next upload. I am also going to backport to all supported releases.

[Olivier Tilloy (osomon)]

https://bazaar.launchpad.net/~mozillateam/firefox/firefox.bionic/revision/1498
https://bazaar.launchpad.net/~mozillateam/firefox/firefox.focal/revision/1503
https://bazaar.launchpad.net/~mozillateam/firefox/firefox.hirsute/revision/1531
https://bazaar.launchpad.net/~mozillateam/firefox/firefox.impish/revision/1537

[Launchpad Janitor (janitor)]

This bug was fixed in the package firefox - 94.0.2+build1-0ubuntu1

---------------
firefox (94.0.2+build1-0ubuntu1) jammy; urgency=medium

  * New upstream release (94.0.2+build1)

  [ Dariusz Gadomski ]
  * Prevent crash on launch under AppArmor (LP: #1931602)

  [ Olivier Tilloy ]
  * Do not export MOZ_DBUS_REMOTE in the launcher script, this is no
    longer required since https://bugzilla.mozilla.org/1724242
    - debian/firefox.sh.in

 -- Olivier Tilloy <email address hidden> Wed, 17 Nov 2021 21:13:26 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package firefox - 95.0+build1-0ubuntu0.20.04.1

---------------
firefox (95.0+build1-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream release (95.0+build1)

  [ Rico Tzschichholz ]
  * Bump build-dep on cargo >= 0.54
    - debian/control{,.in}
    - debian/patches/relax-cargo-dep.patch
  * Update patches
    - debian/patches/armhf-rustc-thin-lto.patch
  * Pass --without-wasm-sandboxed-libraries
    - debian/config/mozconfig.in
  * Install more sizes of the firefox application icon
    - debian/build/rules.mk
  * Bump dump_sys to bf7f6bd855eb6ecb233b52bfa7b2c975b7026540 (LP: #1945770)
    - debian/build/create-tarball.py

 -- Olivier Tilloy <email address hidden> Wed, 01 Dec 2021 10:22:52 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package firefox - 95.0+build1-0ubuntu0.18.04.1

---------------
firefox (95.0+build1-0ubuntu0.18.04.1) bionic; urgency=medium

  * New upstream release (95.0+build1)

  [ Rico Tzschichholz ]
  * Bump build-dep on cargo >= 0.54
    - debian/control{,.in}
    - debian/patches/relax-cargo-dep.patch
  * Update patches
    - debian/patches/armhf-rustc-thin-lto.patch
    - debian/patches/unity-menubar.patch
  * Pass --without-wasm-sandboxed-libraries
    - debian/config/mozconfig.in
  * Install more sizes of the firefox application icon
    - debian/build/rules.mk
  * Bump dump_sys to bf7f6bd855eb6ecb233b52bfa7b2c975b7026540 (LP: #1945770)
    - debian/build/create-tarball.py

 -- Olivier Tilloy <email address hidden> Wed, 01 Dec 2021 10:14:46 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package firefox - 95.0+build1-0ubuntu0.21.04.1

---------------
firefox (95.0+build1-0ubuntu0.21.04.1) hirsute; urgency=medium

  * New upstream release (95.0+build1)

  [ Rico Tzschichholz ]
  * Bump build-dep on cargo >= 0.54
    - debian/control{,.in}
    - debian/patches/relax-cargo-dep.patch
  * Update patches
    - debian/patches/armhf-rustc-thin-lto.patch
  * Pass --without-wasm-sandboxed-libraries
    - debian/config/mozconfig.in
  * Install more sizes of the firefox application icon
    - debian/build/rules.mk
  * Bump dump_sys to bf7f6bd855eb6ecb233b52bfa7b2c975b7026540 (LP: #1945770)
    - debian/build/create-tarball.py

 -- Olivier Tilloy <email address hidden> Wed, 01 Dec 2021 10:25:12 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package firefox - 95.0+build1-0ubuntu0.21.10.1

---------------
firefox (95.0+build1-0ubuntu0.21.10.1) impish; urgency=medium

  * New upstream release (95.0+build1)

  [ Rico Tzschichholz ]
  * Bump build-dep on cargo >= 0.54
    - debian/control{,.in}
    - debian/patches/relax-cargo-dep.patch
  * Update patches
    - debian/patches/armhf-rustc-thin-lto.patch
  * Pass --without-wasm-sandboxed-libraries
    - debian/config/mozconfig.in
  * Install more sizes of the firefox application icon
    - debian/build/rules.mk
  * Bump dump_sys to bf7f6bd855eb6ecb233b52bfa7b2c975b7026540 (LP: #1945770)
    - debian/build/create-tarball.py

 -- Olivier Tilloy <email address hidden> Wed, 01 Dec 2021 10:27:23 +0100