Creating FIT images is not supported
Bug #1931278 reported by
Alfonso Sanchez-Beato
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
flash-kernel (Ubuntu) |
Fix Released
|
Undecided
|
Alfonso Sanchez-Beato |
Bug Description
flash-kernel does currently not support creating FIT images method. The attached debdiff (for impish) supports that, and additionally add supports for the Kria SOM platform.
Related branches
~alfonsosanchezbeato/ubuntu/+source/flash-kernel:kria-support
Rejected
for merging
into
~alfonsosanchezbeato/ubuntu/+source/flash-kernel:applied/ubuntu/focal-updates
- Alfonso Sanchez-Beato: Pending requested
-
Diff: 497 lines (+360/-31)9 files modifiedREADME (+9/-0)
bootscript/arm64/bootscr.zynqmp (+119/-0)
db/all.db (+36/-0)
debian/changelog (+12/-0)
debian/rules (+7/-0)
functions (+64/-30)
its/arm64/image-kria.its (+62/-0)
its/arm64/image-zcu.its (+50/-0)
test_db (+1/-1)
To post a comment you must log in.
thanks for the patch!
this might be easier to review as smaller atomic changes, but perhaps I can still follow around the debdiff :)
1) The its files are data, so they should to /usr/share; I wouldn't encourage local customizations by dropping them in /etc unless that's an important function; a way to give control would be to install a local flash-kernel database entry that overrides the shipped defaults for that hardware; this should be possible with /etc/flash- kernel/ db?
2) would you add the new Boot-FIT-Path and Boot-ITS-Path to README?
3) seems "Boot-ITS-Path: /.../foo.its" should be written "U-Boot-ITS-Name: foo.its" and should be searched in the default flash-kernel directory
4) would it be possible to avoid the cp calls for kernel and initrd and just generate the fit image from their locations? the kernels / initrds tend to be big, so I suspect this adds non-trivial time to the run on SD cards
5) mkimage_fit(): why is padding needed? perhaps deserves a comment. Should this be a config?
6) the full path name in DTB-Id is the first one in the database, perhaps this suggests the corresponding deb should be in Required-Packages? would help with d-i usage
6) "cd" looks pretty singular compared to rest of functions; could it be avoided?