container-check 1.0.8 broke overcloud installation

[Sergii Golovatiuk]

Description of problem:

https://logserver.rdoproject.org/88/791988/3/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/2b4b4bb/logs/undercloud/home/zuul/overcloud_prep_containers.log.txt.gz

which was broken by
https://github.com/imain/container-check/commit/6a116845a4be0319e27dd2910ca49f4627f227ef

How reproducible:
Always

Steps to Reproduce:
1. Run overcloud container prepare
2.
3.

Actual results:

2021-06-02 18:54:15 | 2021-06-02 18:54:15,224 INFO: rpm: rubygem-json-2.0.2-2.el7.x86_64
2021-06-02 18:54:15 | 2021-06-02 18:54:15,224 INFO: *** 44 of 44 containers require updates ***
2021-06-02 18:54:15 | Traceback (most recent call last):
2021-06-02 18:54:15 | File "/usr/bin/container-check", line 244, in <module>
2021-06-02 18:54:15 | ret = list(p.map(yum_update_container, process_map))
2021-06-02 18:54:15 | File "/usr/lib64/python2.7/multiprocessing/pool.py", line 250, in map
2021-06-02 18:54:15 | return self.map_async(func, iterable, chunksize).get()
2021-06-02 18:54:15 | File "/usr/lib64/python2.7/multiprocessing/pool.py", line 554, in get
2021-06-02 18:54:15 | raise self._value
2021-06-02 18:54:15 | TypeError: yum_update_container() takes exactly 3 arguments (1 given)

Expected results:
passed container prepare.

Additional info:

We just need to use 1.0.7 in queens.

[Sergii Golovatiuk (sgolovatiuk)]

BZ#1968553

[Alex Schultz (alex-schultz)]

https://github.com/imain/container-check/pull/6

[Rabi Mishra (rabi)]

Yeah, while fixing https://bugs.launchpad.net/tripleo/+bug/1928689 that regression was introduced.

[Bogdan Dobrelya (bogdando)]

Whe do we depend on that external container-check tool?

[Alex Schultz (alex-schultz)]

The legacy container prepare items use it to determine if it needs updating