File "/usr/local/bin/container-check", line 63 def populate_container_rpms_list((container)): SyntaxError: invalid syntax

[wes hayutin]

2021-05-16 08:38:30 | File "/usr/local/bin/container-check", line 63
2021-05-16 08:38:30 | def populate_container_rpms_list((container)):
2021-05-16 08:38:30 | ^
2021-05-16 08:38:30 | SyntaxError: invalid syntax

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_182/periodic/opendev.org/openstack/tripleo-quickstart-extras/master/tripleo-ci-centos-7-containers-multinode-queens/1820831/logs/undercloud/home/zuul/overcloud_prep_containers.log

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0cd/periodic/opendev.org/openstack/tripleo-quickstart/master/tripleo-ci-centos-7-containers-multinode-queens/0cdb5f4/logs/undercloud/home/zuul/overcloud_prep_containers.log

looking for this code now

[Alex Schultz (alex-schultz)]

This is a python2/python3 problem. it's valid in python2 and not in python3

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/791803

[wes hayutin (weshayutin)]

so.. we have python2 on the box..

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0cd/periodic/opendev.org/openstack/tripleo-quickstart/master/tripleo-ci-centos-7-containers-multinode-queens/0cdb5f4/logs/undercloud/var/log/extra/package-list-installed.txt

Let's see what python is used by default in the shell..
https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/791803

[Rabi Mishra (rabi)]

python3 seems to be installed too.

We now have a new version of container-check fixing that syntax issue https://pypi.org/project/container-check/1.0.8/. Let's see if that helps.

IMO, We should get rid of usage of that library.

[wes hayutin (weshayutin)]

https://logserver.rdoproject.org/50/33750/7/check/tripleo-ci-centos-7-containers-multinode-queens-test/42da652/logs/undercloud/home/zuul/overcloud_prep_containers.log.txt.gz

2021-05-17 22:11:21 | + python --version
2021-05-17 22:11:21 | Python 2.7.5

container-check 1.0.8
https://logserver.rdoproject.org/50/33750/7/check/tripleo-ci-centos-7-containers-multinode-queens-test/42da652/logs/undercloud/var/log/extra/pip.txt.gz

to test other patches..
https://review.rdoproject.org/r/c/testproject/+/33750

Current Issue is:

2021-05-17 22:20:18 | 2021-05-17 22:20:18,645 INFO: *** 22 of 22 containers require updates ***
2021-05-17 22:20:18 | Traceback (most recent call last):
2021-05-17 22:20:18 | File "/usr/bin/container-check", line 244, in <module>
2021-05-17 22:20:18 | ret = list(p.map(yum_update_container, process_map))
2021-05-17 22:20:18 | File "/usr/lib64/python2.7/multiprocessing/pool.py", line 250, in map
2021-05-17 22:20:18 | return self.map_async(func, iterable, chunksize).get()
2021-05-17 22:20:18 | File "/usr/lib64/python2.7/multiprocessing/pool.py", line 554, in get
2021-05-17 22:20:18 | raise self._value
2021-05-17 22:20:18 | TypeError: yum_update_container() takes exactly 3 arguments (1 given)

https://logserver.rdoproject.org/50/33750/7/check/tripleo-ci-centos-7-containers-multinode-queens-test/42da652/logs/undercloud/home/zuul/overcloud_prep_containers.log.txt.gz

[Bogdan Dobrelya (bogdando)]

this should not be a high issue, we do not backport to Queens no longer AFAIK. Also, that container-check is CI only, please just drop it off

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Ghanshyam <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/791803
Reason: TrieplO project is retiring now, for details, please see https://review.opendev.org/c/openstack/governance/+/905145 or reach out to OpenStack TC.