Resume attachment can't be downloaded

[Tim Lock]

Using 20.10 or 21.04, when you setup a resume with attachments, the attachment name is listed correctly, but the download link show the error:

MAHARAURL/artefact/file/download.php?file=undefined

A required parameter is missing or malformed

The 'file' parameter is not an integer

This is fixed by:

htdocs/artefact/resume/lib.php:

- var href = self.config.wwwroot + 'artefact/file/download.php?file=' + attachments[i].id;
+ var href = self.config.wwwroot + 'artefact/file/download.php?file=' + attachments[i].attachment;

Regards,
Tim

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11793

[Robert Lyon (robertl-9)]

Hi Tim,

Thank you for spotting this issue and supplying a fix.

In reviewing it I noticed a few more problems nearby, namely the icon not showing and screen reader text being squashed up, so fixed them as part of this fix

[Robert Lyon (robertl-9)]

https://reviews.mahara.org/#/c/11793/

[Tim Lock (timlock)]

Thanks Robert.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11793
Committed: https://git.mahara.org/mahara/mahara/commit/b6880747120d2a2d9c5e9bc54dae98d1d78986c5
Submitter: Gold (<email address hidden>)
Branch: master

commit b6880747120d2a2d9c5e9bc54dae98d1d78986c5
Author: Robert Lyon <email address hidden>
Date: Wed May 19 21:15:06 2021 +1200

Bug 1928908: Resume attachments not styled correctly in resume section

Also the download link is not working

They need to look more like how they render in the single resume block

Change-Id: I3cd210a2fc25392764895ec8ea7e1df629f3af60
Signed-off-by: Robert Lyon <email address hidden>