FTBFS on all architectures except i386, amd64, and lpia

[Ryan Mulder]

Binary package hint: wxformbuilder

version 3.0.54

[Ryan Mulder (ryanjmulder)]

wxFormBuilder uses a build file generator called premake (http://premake.sf.net), which helps it be platform independent.
The original source package (version 3.0.54-0ubuntu1) used included prebuilt premake binaries to generate Makefiles in the configure step.
These prebuilt premake binaries only worked on i386, amd64, and lpia.

Because the Makefiles for all architectures are the same, the upstream tarball should include the Makefiles, not premake.
I've attached a new upstream tarball that does just that, in addition to fixing some bugs in the upstream source.

[Ryan Mulder (ryanjmulder)]

You'll notice that this diffstat indicates the addition of a wxFlatNotebook directory.
This is the explanation for that:
 wxFormBuilder has used a notebook control that is not part of the official wxWidgets library, this third-party control is called wxFlatNotebook.
 When packaging for Ubuntu, I realized that wxFlatNotebook's source did not include copyright statements, and switched the notebooks to use a notebook control that is included in the official wxWidgets library.
 I contacted the author of wxFlatNotebook, and he has since updated his source to include copyright statements - wxFlatNotebook is released under the wxWindows license. This made it safe to include wxFlatNotebook, so I did, as I'm sure that the switch to the other notebook control introduced bugs.

The other changes are the addition of Makefiles, the removal of premake and its supporting scripts, some rework in the packaging files to use the Makefiles directly, and some bugfixes in the upstream source - see the attached diff of the Upstream Changelog.

[Ryan Mulder (ryanjmulder)]

This changelog refers to bugs that can be found on this issue tracker:
http://issues.wxformbuilder.org

[Cesare Tirabassi (norsetto)]

It seems that we are mixing two issues here, the ftbfs and the new upstream release.
According to http://wxformbuilder.org the new upstream release is Version 3.00.54 (RC6) from 02/01/2008 so it seems that you are using an svn snapshot?
You should really report the differences between what you propose and the version we have in ubuntu.
Beside this, could we not just fix the build for the version we currently have in hardy?

[Ryan Mulder (ryanjmulder)]

Cesare,
 Thank you for looking at this.
 You are correct, there are two issues here.
 To fix the FTBFS bugs, the orig.tar.gz should include the Makefiles, rather than including premake. But a change in the orig.tar.gz forces an uprev. Traditionally, an uprev for wxformbuilder would change the version number from 3.0.54 to 3.0.55, this would imply actual changes in wxformbuilder, not just in the build.
So, I was attempting to release a bug-fix uprev of wxformbuilder at the same time as fixing the FTBFS issues.

 I am both a developer of wxformbuilder upstream, and the package mainter, so I am still trying to figure out the best approach to these problems.

 It seems that I should break from wxformbuilder's traditional versioning scheme, and uprev to 3.0.54.1, or leave the orig.tar.gz alone and put the Makefiles in the diff.gz for now. Which way would be better?

[StefanPotyra (sistpoty)]

Since the new upstream release is a bug fix only release, it makes sense to me to bring it in. Hence ACK #1 from me.

Others than that, I'd include the Makefiles in the .diff.gz, if it weren't a bugfix only release.

[Cesare Tirabassi (norsetto)]

Ack #2 and approved.

[Ryan Mulder (ryanjmulder)]

Please, forgive my ignorance, but what is the process to take this bug from Confirmed to Fixed?

[Cesare Tirabassi (norsetto)]

You need a sponsor for that, since you did not request it yourself ScottK subscribed u-u-s for you yesterday.

[Stephan Rügamer (sruegamer)]

I'll take care.

[Launchpad Janitor (janitor)]

This bug was fixed in the package wxformbuilder - 3.0.55-0ubuntu1

---------------
wxformbuilder (3.0.55-0ubuntu1) hardy; urgency=low

  * Fixed build on architectures other than i386 and amd64. (LP: #192818)

 -- Ryan Mulder <email address hidden> Wed, 13 Feb 2008 20:06:25 -0400