SPICE support broken with 6.0

[Firecode95]

Using latest relase 6.0.0 while using Intel GVT-G DMA-BUF and SPICE for usb redirection Qemu won't start:

qemu-system-x86_64: The console requires display DMABUF support.

However just patching ui/console.c:

if (flags & GRAPHIC_FLAGS_DMABUF &&
        !displaychangelistener_has_dmabuf(dcl)) {
        error_setg(errp, "The console requires display DMABUF support.");
        return false;
}

to always return true for dmabuf part works just fine:

if (flags & GRAPHIC_FLAGS_DMABUF &&
        !displaychangelistener_has_dmabuf(dcl)) {
        error_setg(errp, "The console requires display DMABUF support.");
        return true;
}

This behavior wasn't in qemu 5.x version.

To reproduce this bug need to use:

/usr/bin/qemu-system-x86_64 \
-machine q35 \
-enable-kvm \
-no-user-config \
-nodefaults \
-no-hpet \
-display gtk,gl=on \
-device pcie-root-port,port=0x0,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1 \
-device vfio-pci,id=hostdev2,driver=vfio-pci-nohotplug,romfile=/sys/devices/pci0000:00/0000:00:02.0/gvt_firmware,sysfsdev=/sys/bus/mdev/devices/1ae40c36-b180-4af0-8fab-c27de21f597d,x-igd-opregion=on,ramfb=on,display=on,xres=1920,yres=1080,bus=pcie.0,multifunction=on,addr=0x2 \
-spice port=5900,addr=127.0.0.1,disable-ticketing=on

[Firecode95 (firecode95)]

Also just removing spice part makes it bootable:
-spice port=5900,addr=127.0.0.1,disable-ticketing=on

[elmarco (marcandre-lureau)]

Hi

On Mon, May 3, 2021 at 4:07 PM Firecode95 <email address hidden>
wrote:

> Also just removing spice part makes it bootable:
> -spice port=5900,addr=127.0.0.1,disable-ticketing=on
>
> --
> You received this bug notification because you are a member of qemu-
> devel-ml, which is subscribed to QEMU.
> https://bugs.launchpad.net/bugs/1926952
>
> Title:
> SPICE support broken with 6.0
>
> Status in QEMU:
> New
>
> Bug description:
> Using latest relase 6.0.0 while using Intel GVT-G DMA-BUF and SPICE
> for usb redirection Qemu won't start:
>
> qemu-system-x86_64: The console requires display DMABUF support.
>
> However just patching ui/console.c:
>
> if (flags & GRAPHIC_FLAGS_DMABUF &&
> !displaychangelistener_has_dmabuf(dcl)) {
> error_setg(errp, "The console requires display DMABUF support.");
> return false;
> }
>
> to always return true for dmabuf part works just fine:
>
> if (flags & GRAPHIC_FLAGS_DMABUF &&
> !displaychangelistener_has_dmabuf(dcl)) {
> error_setg(errp, "The console requires display DMABUF support.");
> return true;
> }
>
> This behavior wasn't in qemu 5.x version.
>
> To reproduce this bug need to use:
>
> /usr/bin/qemu-system-x86_64 \
> -machine q35 \
> -enable-kvm \
> -no-user-config \
> -nodefaults \
> -no-hpet \
> -display gtk,gl=on \
> -device
> pcie-root-port,port=0x0,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1
> \
> -device
> vfio-pci,id=hostdev2,driver=vfio-pci-nohotplug,romfile=/sys/devices/pci0000:00/0000:00:02.0/gvt_firmware,sysfsdev=/sys/bus/mdev/devices/1ae40c36-b180-4af0-8fab-c27de21f597d,x-igd-opregion=on,ramfb=on,display=on,xres=1920,yres=1080,bus=pcie.0,multifunction=on,addr=0x2
> \
> -spice port=5900,addr=127.0.0.1,disable-ticketing=on
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1926952/+subscriptions
>
>

Did you actually get the dmabuf update displayed over spice? If not, then
it is not a bug, it's a bug fix :) But I might be missing something.. I
don't see how this could happen without egl-headless though.

--
Marc-André Lureau

[Firecode95 (firecode95)]

After launching qemu I have qemu display from intel gpu(gvt-g), terminal output of launched script. After that launching in terminal separate instance remote-viewer for spice to passthru usb devices - spice dislay is blank, that was also in 5.x versions, but just now to get spice running I need to patch check to always return true. As I understood I have egl-headless window as there is fully aclerated guest video output:

Full comand that I am running is as follow:

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cp /home/firecode95/.config/pulse/cookie /root/.config/pulse/cookie
/usr/bin/qemu-system-x86_64 \
-name guest=windows10 \
-machine q35,accel=kvm,vmport=off,kernel_irqchip=on \
-cpu host,hv_time,kvm=off,hv-relaxed,hv-vapic,kvm-asyncpf-int,topoext,host-cache-info=on,check,hv_stimer,hv_synic,hv_vpindex,-hypervisor,hv_spinlocks=0x1fff,hv_vapic \
-enable-kvm \
-drive if=pflash,format=raw,readonly=on,file=$DIR/OVMF_CODE.fd \
-drive if=pflash,format=raw,file=$DIR/OVMF_VARS.fd \
-smp 12,sockets=1,dies=1,cores=6,threads=2 \
-mem-path /dev/hugepages \
-m 8G \
-uuid e7d44285-507b-48da-bfe2-2eba415016bd \
-no-user-config \
-nodefaults \
-no-hpet \
-rtc base=localtime \
-global PIIX4_PM.disable_s3=0 \
-global ICH9-LPC.disable_s3=1 \
-global ICH9-LPC.disable_s4=1 \
-global isa-debugcon.iobase=0x402 \
-debugcon file:/tmp/windows_10.ovmf.log \
-monitor stdio \
-boot menu=on,strict=on \
-device pcie-root-port,port=0x0,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1 \
-device pcie-root-port,port=0x9,chassis=2,id=pci.2,bus=pcie.0,addr=0x1.0x1 \
-device pcie-root-port,port=0xa,chassis=3,id=pci.3,bus=pcie.0,addr=0x1.0x2 \
-device pcie-root-port,port=0xb,chassis=4,id=pci.4,bus=pcie.0,addr=0x1.0x3 \
-device pcie-root-port,port=0xc,chassis=5,id=pci.5,bus=pcie.0,addr=0x1.0x4 \
-device pcie-root-port,port=0xd,chassis=6,id=pci.6,bus=pcie.0,addr=0x1.0x5 \
-device i82801b11-bridge,id=pci.7,bus=pcie.0,addr=0x1e \
-device pci-bridge,chassis_nr=8,id=pci.8,bus=pci.7,addr=0x0 \
-device ich9-usb-ehci1,id=usb,bus=pcie.0,addr=0x1d.0x7 \
-device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pcie.0,multifunction=on,addr=0x1d \
-device ich9-usb-uhci2,masterbus=usb.0,firstport=2,bus=pcie.0,addr=0x1d.0x1 \
-device ich9-usb-uhci3,masterbus=usb.0,firstport=4,bus=pcie.0,addr=0x1d.0x2 \
-device virtio-serial-pci,id=virtio-serial0,bus=pci.3,addr=0x0 \
-object iothread,id=iothread0 \
-device virtio-scsi-pci,iothread=iothread0,num_queues=8,id=scsi0,bus=pcie.0,addr=0x3 \
-drive file=$DIR/virtio-win-0.1.185.iso,media=cdrom,bus=2 \
-drive if=none,id=hd1,file=$DIR/$1.qcow2,format=qcow2,cache.direct=on,discard=unmap,aio=threads \
-device scsi-hd,drive=hd1 \
-object input-linux,id=kbd1,evdev=/dev/input/by-path/platform-i8042-serio-0-event-kbd,grab_all=on,repeat=on \
-acpitable file=$DIR/SSDT1.dat \
-msg timestamp=on \
-netdev type=tap,id=net0,ifname=tap1,script=$DIR/tap_ifup,downscript=$DIR/tap_ifdown,vhost=on \
-device virtio-net-pci,netdev=net0,mac=52:54:BE:EF:A1:67,bus=pci.5,addr=0x0 \
-spice port=5902,addr=127.0.0.1,disable-ticketing=on \
-device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=channel0,name=com.redhat.spice.0 \
-displ...

[elmarco (marcandre-lureau)]

> launching in terminal separate instance remote-viewer for spice to passthru usb devices - spice dislay is blank, that was also in 5.x versions,

That was really a hack. I mean, Spice client shouldn't have a blank display. You shouldn't have to run both qemu display and remote-viewer. What you wanted actually is usb redirection with qemu, or you should simply use spice with gl=on to enable the dmabuf support. In the meantime, you could patch qemu to keep your hack solution "working".

Btw, we are moving to gitlab for bug tracking (https://gitlab.com/qemu-project/qemu).

[Firecode95 (firecode95)]

But is there any option to dynamically add/remove usb devices like from spice client to vm that is powered up without using spice? As far I have found there is no such option.

[Thomas Huth (th-huth)]

The QEMU project is currently moving its bug tracking to another system.
For this we need to know which bugs are still valid and which could be
closed already. Thus we are setting the bug state to "Incomplete" now.

If the bug has already been fixed in the latest upstream version of QEMU,
then please close this ticket as "Fix released".

If it is not fixed yet and you think that this bug report here is still
valid, then you have two options:

1) If you already have an account on gitlab.com, please open a new ticket
for this problem in our new tracker here:

    https://gitlab.com/qemu-project/qemu/-/issues

and then close this ticket here on Launchpad (or let it expire auto-
matically after 60 days). Please mention the URL of this bug ticket on
Launchpad in the new ticket on GitLab.

2) If you don't have an account on gitlab.com and don't intend to get
one, but still would like to keep this ticket opened, then please switch
the state back to "New" or "Confirmed" within the next 60 days (other-
wise it will get closed as "Expired"). We will then eventually migrate
the ticket automatically to the new system (but you won't be the reporter
of the bug in the new system and thus you won't get notified on changes
anymore).

Thank you and sorry for the inconvenience.

[Launchpad Janitor (janitor)]

[Expired for QEMU because there has been no activity for 60 days.]