unleashed fails to boot of sd-card with u-boot-sifive from hirsute

[Dimitri John Ledkov]

[Impact]

 * With the bug in u-boot-sifive, the Unleashed boards will be unable to boot

[Test Plan]

 * Flash an Unleashed image to an SD card and attempt to boot

 * Ensure that with the version of u-boot-sifive in -proposed the Unleashed can still boot

[Where problems could occur]

 * Because u-boot runs on many different devices, there is a possibility
   of regression on some of them. Many tests are being used to ensure
   this does not happen, and the changes to fix the Unleashed boot
   are very minor.

[Original Description]
unleashed fails to boot off sd-card with u-boot-sifive from hirsute

1) focal's u-boot-sifive on loader1/loader2 boots hirsute's 5.11 kernel fine.

2) upgrading loader1/loader2 to u-boot-sifive from hirsute makes the sd-card boot of sifive fail with

This is a banner for port con1(telnet(rfc2217),tcp,3000)
Error 0x0100000000000002

Unless we can fix this unleashed images should not be released.

[Launchpad Janitor (janitor)]

This bug was fixed in the package u-boot - 2021.01+dfsg-3ubuntu7

---------------
u-boot (2021.01+dfsg-3ubuntu7) hirsute; urgency=medium

  * Unapply unmatched patches, whilst building unleashed platform. Fixes
    failure to boot from sd-card on Unleashed. LP: #1924761

 -- Dimitri John Ledkov <email address hidden> Fri, 16 Apr 2021 14:07:49 +0100

[Łukasz Zemczak (sil2100)]

An upload of u-boot to focal-proposed has been rejected from the upload queue for the following reason: "Please see https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/1923162/comments/13 for the rationale. Might need some more work or re-upload.".

[Brian Murray (brian-murray)]

Hello Dimitri, or anyone else affected,

Accepted u-boot into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/u-boot/2021.01+dfsg-3ubuntu0~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[William Wilson (jawn-smith)]

The verification passed for focal.

I submitted the following job to testflinger:

job_queue: unleashed
provision_data:
  url: http://cdimage.ubuntu.com/ubuntu-server/focal/daily-preinstalled/current/focal-preinstalled-server-riscv64+unleashed.img.xz
test_data:
  test_cmds: |
    ssh ubuntu@$DEVICE_IP cat /proc/cpuinfo

And it succeeded with:

2\nisa\t\t: rv64imafdc\nmmu\t\t: sv39\nuarch\t\t: sifive,u54-mc\n\nprocessor\t: 2\nhart\t\t: 3\nisa\t\t: rv64imafdc\nmmu\t\t: sv39\nuarch\t\t: sifive,u54-mc\n\nprocessor\t: 3\nhart\t\t: 4\nisa\t\t: rv64imafdc\nmmu\t\t: sv39\nuarch\t\t: sifive,u54-mc\n\n2021-07-26 23:21:34,951 hifive_001 INFO: DEVICE AGENT: END testrun\n",
    "test_serial": "\u0003\u0001\u0001\u0000\u0000,This is a banner for port con1(telnet(rfc2217),tcp,3000)\n",
    "test_status": 0

Which notably has a status of 0 and successfully ran the `cat /proc/cpuinfo` command. The Login service with "Ubuntu 20.04.2" was also displayed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package u-boot - 2021.01+dfsg-3ubuntu0~20.04.1

---------------
u-boot (2021.01+dfsg-3ubuntu0~20.04.1) focal; urgency=medium

  * SRU of 2021.01+dfsg-3 from hirsute to enable booting on HiFive Unmatched
    LP: #1934791, LP: #1925267, LP: #1923162

  [ Dimitri John Ledkov ]
  * Import meta-sifive u-boot patches.
  * Enable sifive_hifive_unmatched_fu740 target.
  * Build-depend on opensbi with fu740 errata fix.
  * Set default FDT files for the sifive boards.
  * Set USE_PREBOOT on unmatched board too (just like unleashed & qemu),
    otherwise u-boot's fdtfile from itb is not used (i.e. when
    extlinux.conf does not specify fdtdir). LP: #1923162
  * Unapply unmatched patches, whilst building unleashed platform. Fixes
    failure to boot from sd-card on Unleashed. LP: #1924761
  * sifive-unleashed-default-fdt-files.patch: split into unleashed &
    unmatched separate patches, for ease of upstreaming to meta-sifive and
    u-boot upstreams. Also this ensures that unleashed target is built
    with fdtfile= set, as unleashed target unapplies lots of patches.
  * Apply upstreamed patch "cmd: pxe_utils: sysboot: fix crash if either
    board or soc are not set." This fixes a crash booting any
    extlinux.conf with fdtdir specified, and dtbfile not set and
    "soc"/"board" not set in the environment LP: #1923162

  [ William 'jawn-smith' Wilson ]
  * Re-added d/p/lzo-to-lzno.patch as lzop is in universe prior to Groovy
  * Updated d/targets for compatibility with focal arm-trusted-firmware
  * Updated d/control for compatibility with focal debhelper
  * Reinstate rpi-config-migration script for focal
  * Prevent stripping of qemu binaries under focal where strip doesn't
    recognize the format

  [ Dave Jones ]
  * In d/control update opensbi dependency for focal

 -- William 'jawn-smith' Wilson <email address hidden> Fri, 25 Jun 2021 18:21:47 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for u-boot has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.