[sos41][sos-collect]"unsupported operand type(s)" error during report generation

[Garrett Neugent]

[Impact]

[Test Case]

[Where problem could occur]

[Other information]

https://github.com/sosreport/sos/issues/2488
https://github.com/TurboTurtle/sos/commit/598ead20effaf657f6946fce5b7abccefe0a126d

[Original description]

When trying out the new version (4.1), I get an error during report generation.

Both the remote and local machines are using the latest version of soreport:

$ apt-cache policy sosreport
sosreport:
  Installed: 4.1-1ubuntu0.20.04.1
  Candidate: 4.1-1ubuntu0.20.04.1
  Version table:
 *** 4.1-1ubuntu0.20.04.1 500
        500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     3.9-1ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages

Both the remote and local machines are using 20.04.2 (From cat /etc/os-release)

Here's the full output (node and user have been redacted), including the debug flag:

$ sos collect --batch -a --all-logs --clean --nodes $node --ssh-user $user --debug

sos-collector (version 4.1)

This utility is used to collect sosreports from multiple nodes simultaneously.
It uses OpenSSH's ControlPersist feature to connect to nodes and run commands
remotely. If your system installation of OpenSSH is older than 5.6, please
upgrade.

An archive of sosreport tarballs collected from the nodes will be generated in
/tmp/sos.fie0k2xs and may be provided to an appropriate support representative.

The generated archive may contain data considered sensitive and its content
should be reviewed by the originating organization before being passed to any
third party.

No configuration changes will be made to the system running this utility or
remote systems that it connects to.

sos-collector ASSUMES that SSH keys are installed on all nodes unless the
--password option is provided.

Local sos report generation forcibly skipped due to lack of root privileges.
Either use --nopasswd-sudo, run as root, or do not use --batch so that you will be prompted for a password

Cluster type set to Pacemaker High Availability Cluster Manager
Cluster status could not be determined. Is the cluster running on this node?

The following is a list of nodes to collect from:
        $node

Connecting to nodes...

Beginning collection of sosreports from 1 nodes, collecting a maximum of 4 concurrently

$node : Generating sosreport...
[$node:execute_sos_command] Error running sosreport: unsupported operand type(s) for +: 'bool' and 'str'
Error running sosreport: unsupported operand type(s) for +: 'NoneType' and 'str'
No sosreports were collected, nothing to archive...

[Eric Desrochers (slashd)]

Hi Garrett,

Since current 4.1 is at upstream src code base level. Could you please report this upstream as well ?

https://github.com/sosreport/sos/issues

- Eric

[Garrett Neugent (thogarre)]

sure thing! this has been created - https://github.com/sosreport/sos/issues/2488

[Launchpad Janitor (janitor)]

This bug was fixed in the package sosreport - 4.1-1ubuntu2

---------------
sosreport (4.1-1ubuntu2) impish; urgency=medium

  * d/p/series:
    - Re-order patches in numerical order.

  * d/p/0003-ubuntu-policy-fix-upload.patch:
    - Fix sos archive upload to UA Canonical server
      (LP: #1923209)

  * d/p/0004-chrony-configuration-can-now-be-fragmented.patch:
    - Chrony 4.0, first introduced in Hirsute, support
      fragmented configuration.

  * d/p/0005-global-drop-plugin-version.patch:
    - Removal of plugins versionning features as it generate
      unhelpful noise. (LP: #1922925)

  * d/p/0006-networking-check-presence-of-devlink.patch:
    - On certain kernel configuration, devlink cmds may
      trigger the module to load automatically. This will
      also prevent simple.sh, part of the autopkgtest, in
      Bionic to fail due to devlink kernel conf in 4.15.
      (LP: #1923661)

  * d/p/0007-sosnode-avoid-checksum-cleanup-if-no-archive.patch:
    - Fixes an exception propagation from `cleanup()`
      where an attempt to look for and remove a checksum
      file was made when an archive was not generated.
      (LP: #1923641)

 -- Eric Desrochers <email address hidden> Mon, 26 Apr 2021 15:34:42 -0400