Can't copy personal locked portfolio

[Kristina Hoeppner]

To replicate:

1. Set up auto-copy collection with a primary statement that locks the portfolio (new functionality for 21.04 of collection template and auto-copy).
2. Create a new account.
3. Run the cron so that the portfolio is copied.
4. Log in as portfolio owner and share the portfolio with a verifier.
5. Log in as verifier and tick the statement.
6. Log back in as portfolio owner.
7. Copy the collection / copy a page within the collection.

Result:

Expected: The copying works.
Actual: Error message:

[WAR] 0a (lib/view.php:432) View::create_from_template: Attempting to create a View from another View that is not marked as a template
Call stack (most recent first):

    View::create_from_template() at /home/kristina/code/mahara/htdocs/lib/collection.php:436
    Collection::create_from_template() at /home/kristina/code/mahara/htdocs/lib/view.php:7775
    copyview() at /home/kristina/code/mahara/htdocs/view/copy.php:34

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11684

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11684
Committed: https://git.mahara.org/mahara/mahara/commit/fbec6279aa00d14c947a3999156689b26d042125
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fbec6279aa00d14c947a3999156689b26d042125
Author: Robert Lyon <email address hidden>
Date: Wed Mar 24 23:15:57 2021 +0000

Bug 1922841: Portfolio locking (personal copy issue)

Change-Id: Ia3205e18f1aee30d54ed2e4bdf0bb17d98ea914d
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11744