SND_PCI_QUIRK for Clevo NH55RZQ and Intel NUC10

Bug #1922759 reported by Werner Sembach
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
Undecided
Unassigned
Groovy
Fix Released
Medium
Unassigned
linux-oem-5.6 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

The Clevo NH55RZQ and Intel NUC10 need SND_PCI_QUIRKs to fix wrong pin setup and enable microphones to work correctly when using via the audio jacks.

Patches that are fixing these problems have already been accepted to current Linux stable releases:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=48698c973e6b4dde94d87cd1ded56d9436e9c97d

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=73e7161eab5dee98114987239ec9c87fe8034ddb

Commit-hash:

48698c973e6b4dde94d87cd1ded56d9436e9c97d

73e7161eab5dee98114987239ec9c87fe8034ddb

Revision history for this message
Werner Sembach (matombo) wrote :
Revision history for this message
Werner Sembach (matombo) wrote :
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1922759

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
Werner Sembach (matombo) wrote :

I don't have the two devices at hand atm, but the patches should be pretty streigt forward so the system log might not be required?

Changed in linux (Ubuntu):
status: Incomplete → Confirmed
tags: added: patch
Revision history for this message
Tim Gardner (timg-tpi) wrote :

Werner Sembach - what release are you running ? These patches are or will soon be in Focal (20.04), and Hirsute (21.04) since they are in linux-stable.

Tim Gardner (timg-tpi)
tags: added: bot-stop-nagging
Changed in linux (Ubuntu Groovy):
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Seth Forshee (sforshee) wrote :

These commits are already included in hirsute, closing the development task.

Changed in linux (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Werner Sembach (matombo) wrote :

Oh I'm sorry I missed that.

I only checked the git for focal hwe-kernel because I thought: hwe-kernel = kernel of the next release.

I was apperently misstaken on that ^^.

Changed in linux (Ubuntu Groovy):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-groovy' to 'verification-done-groovy'. If the problem still exists, change the tag 'verification-needed-groovy' to 'verification-failed-groovy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-groovy
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Hello Werner,

Could you please verify if the latest 20.10 Groovy kernel in -proposed fixes the issue reported? As of now the version of the latest kernel is 5.8.0-51.57.

Thank you.

Revision history for this message
Werner Sembach (matombo) wrote :
Revision history for this message
Werner Sembach (matombo) wrote :
Revision history for this message
Werner Sembach (matombo) wrote :

My colleague tested the Clevo NH55RZQ

However the 5.8.0-51.57 kernel is borked for some reason: Audio setting is only showing a Dummy device, which is worse then unpatched kernel. However the mainline 5.12 kernel which uses the exact same quirk works just fine: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v5.12#n8186

NUC10 will be tested tomorrow

Revision history for this message
Werner Sembach (matombo) wrote :

ubuntu 5.11 kernel will also be tested tomorrow

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Hello Werner,

Thank you for your feedback.

If with these patches it is worse than with the unpatched kernel we might need some prerequisite commits.

I think the best option would be to remove these patches for now until we have identified which are the missing commits. Would you agree?

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Sorry, by "remove these patches" on the previous comment I mean for now only the Clevo quirk. The NUC change is still to be tested and can be kept if we have positive test results.

Revision history for this message
Werner Sembach (matombo) wrote :

NUC 10 also tested, also doesn't work

Since the clevo and the nuc are completly different platforms with different quirks i suspect it's not the quirk causing the issue between 50 and 51.

I'm currently installing ubuntu on a different clevo that should already be working, and let you know my results.

Revision history for this message
Werner Sembach (matombo) wrote :

Tested the clevo NL50RU and it works without issues with both 50 and 51.

Also ubuntu 5.11 kernel works on both nuc10 and clevo NH55RZQ.

I have no other device at hand that usses the ALC269_FIXUP_DMIC quirk and the NUC10 quirk is exclusive for that device.
Both quirks are pretty straight forward and I don't see why only they fail but other quirks work.

I asks my colleague for some additional testing, maybe ist gives a new hint.

tags: added: verification-failed-groovy
removed: verification-needed-groovy
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Hello Werner,

What we understand from your feedback is that it is not sure yet if the failures are caused by the quirks or by other changes applied between kernels -50 and -51, therefore we have decided to remove the proposed quirks from the next re-spin of the 20.10 Groovy kernel (5.8) until we have a confirmation of what is breaking the audio on those platforms and when it would be safe to reintroduce the quirks.

These patches will need to be resubmitted to the mailing-list (<email address hidden>) once we can confirm they fix the issue on the Ubuntu Kernel.

We would also be glad to provide test builds of the kernel if it would help testing those changes.

Thank you and sorry for the inconvenience,
Kleber

Changed in linux (Ubuntu Groovy):
status: Fix Committed → In Progress
Changed in linux (Ubuntu Groovy):
status: In Progress → Fix Committed
Revision history for this message
Werner Sembach (matombo) wrote :

Ok I think I found out what happened: When we tested 5.8-51 on the NUC and the Clevo NH55RZQ we forgot to also update linux-modules-extra (We just installed the linux-image package).

When we tested the Clevo NL50RU we installed/updated the HWE meta package which also updated the modules extra package.

Without the correct version of modules-extra you get only "Dummy" as an audio output option.

So fail at user not at code ^^

The patches where not commited by me over the mailing list but where pulled in via upstream stable update (see #5).

Should i send them to the list regardless?

Revision history for this message
Werner Sembach (matombo) wrote :

tl:dr;
- No issue with linux-image-5.8.0-51.57
- Test devices did not work because we accidentially did not install linux-modules-extra-5.8.0-51-generic

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Hello Werner,

Thank you for the update. The re-spin is not fully completed yet, so we might be able to keep the patches.

tags: added: verification-needed-groovy
removed: verification-failed-groovy
AceLan Kao (acelankao)
no longer affects: linux (Ubuntu Focal)
no longer affects: linux-oem-5.6 (Ubuntu Groovy)
Changed in linux-oem-5.6 (Ubuntu):
status: New → Invalid
Changed in linux-oem-5.6 (Ubuntu Focal):
status: New → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Hello Werner,

If possible, could you please re-test with the latest groovy/linux in -proposed (5.8.0-52.59)?

Thank you.

Revision history for this message
Werner Sembach (matombo) wrote :

Tested and works

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Hello Werner,

Thank you for your tests and feedback.

tags: added: verification-done-groovy
removed: verification-needed-groovy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1056.60

---------------
linux-oem-5.6 (5.6.0-1056.60) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1056.60 -proposed tracker (LP: #1923783)

  * CVE-2021-29646
    - tipc: better validate user input in tipc_nl_retrieve_key()

  * CVE-2021-28375
    - misc: fastrpc: restrict user apps from sending kernel RPC messages

  * CVE-2020-35519
    - net/x25: prevent a couple of overflows

  * CVE-2021-30002
    - media: v4l: ioctl: Fix memory leak in video_usercopy

  * SND_PCI_QUIRK for Clevo NH55RZQ and Intel NUC10 (LP: #1922759)
    - ALSA: hda/realtek: Add quirk for Intel NUC 10
    - ALSA: hda/realtek: Add quirk for Clevo NH55RZQ

  * CVE-2021-29650
    - netfilter: x_tables: Use correct memory barriers.

  * Fix implicit declaration warnings for kselftests/memfd test on newer
    releases (LP: #1910323)
    - selftests/memfd: Fix implicit declaration warnings

 -- Chia-Lin Kao (AceLan) <email address hidden> Tue, 04 May 2021 11:46:25 +0800

Changed in linux-oem-5.6 (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.8.0-53.60

---------------
linux (5.8.0-53.60) groovy; urgency=medium

  * CVE-2021-3491
    - io_uring: fix provide_buffers sign extension
    - io_uring: fix overflows checks in provide buffers
    - SAUCE: proc: Avoid mixing integer types in mem_rw()
    - SAUCE: io_uring: truncate lengths larger than MAX_RW_COUNT on provide
      buffers

  * CVE-2021-3490
    - bpf: Fix a verifier failure with xor
    - SAUCE: bpf: verifier: fix ALU32 bounds tracking with bitwise ops

  * CVE-2021-3489
    - SAUCE: bpf: ringbuf: deny reserve of buffers larger than ringbuf
    - SAUCE: bpf: prevent writable memory-mapping of read-only ringbuf pages

 -- Stefan Bader <email address hidden> Thu, 06 May 2021 07:43:20 +0200

Changed in linux (Ubuntu Groovy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.