Fix build against new runc version

[Lucas Kanashiro]

[Impact]

runc/1.0.0~rc93-0ubuntu1 in Hirsute is going to be backported to Groovy (already in groovy-
proposed) but libpod and golang-github-containers-buildah FTBFS with it (autopkgtest fails as well). Those packages are blocking runc's migration.

Both packages, libpod and golang-github-containers-buildah, have patches to fix the build against a newer runc version but they are disabled (commented out) because we have an older runc in the Groovy release pocket. The fix is basically to uncomment those patches in debian/patches/series of both packages.

[Test Plan]

Make sure libpod and golang-github-containers-buildah build fine and DEP-8 tests are also passing.

[Where problems could occur]

The patches which will be enabled are well tested by Debian (they are not commented out there because they already have a newer runc), but if a problem could occur it would be where the patches are applied which is the implementation of how devices and permissions are managed in a linux system. Check the patches for more info.

[Sergio Durigan Junior (sergiodj)]

Thanks, Lucas.

I was involved in the investigation of the libpod breakage and feel confident that this is the right way to go.

I did try to build both libpod and buildah with equivalent patches locally, and everything succeeds. I'm +1 on both patches.

[Lucas Kanashiro (lucaskanashiro)]

Thanks for helping with the investigation and the review Sergio! The packages were already uploaded.

[Robie Basak (racb)]

SRU +1 for libpod and golang-github-containers-buildah as currently in Groovy Unapproved. I prefer to accept all related packages together to avoid confusion, so I intend to accept these together with containerd and docker.io when they are ready (currently waiting on feedback from my review at https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/1919322/comments/15).

[Robie Basak (racb)]

Hello Lucas, or anyone else affected,

Accepted libpod into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libpod/2.0.6+dfsg1-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robie Basak (racb)]

Hello Lucas, or anyone else affected,

Accepted golang-github-containers-buildah into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-github-containers-buildah/1.15.2-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Lucas Kanashiro (lucaskanashiro)]

The golang-github-containers-buildah package FTBFS because of the new version of the docker.io package in groovy-proposed. The attached debdiff fixes this issue.

[Lucas Kanashiro (lucaskanashiro)]

The libpod package FTBFS because of the new version of the docker.io package in groovy-proposed. The attached debdiff fixes this issue.

[Sergio Durigan Junior (sergiodj)]

FWIW, I've tested both patches and can confirm that they fix the FTBFSes that are happening (I've had a problem trying to build libpod in a container, but then I tested on sbuild and it worked. It may have been something in the container itself).

If someone would like to try these patches: you first need to build golang-github-containers-buildah, and then you have to use the generated package while building libpod.

[Lucas Kanashiro (lucaskanashiro)]

Both packages built fine in this PPA:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/buildah-and-libpod/+packages

[Lucas Kanashiro (lucaskanashiro)]

Packages uploaded.

[Robie Basak (racb)]

Hello Lucas, or anyone else affected,

Accepted golang-github-containers-buildah into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-github-containers-buildah/1.15.2-1ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robie Basak (racb)]

Hello Lucas, or anyone else affected,

Accepted libpod into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libpod/2.0.6+dfsg1-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Lucas Kanashiro (lucaskanashiro)]

The test plan indicates that the build time tests and DEP-8 tests should pass.

- Both packages built fine on LP.
- libpod DEP-8 test is passing but the golang-github-containers-buildah DEP-8 test is failing for a while so I'd ask to ignore it.

golang-github-containers-buildah autopkgtest history:

http://autopkgtest.ubuntu.com/packages/golang-github-containers-buildah

autopkgtest summary output for libpod:

autopkgtest [09:47:06]: @@@@@@@@@@@@@@@@@@@@ summary
dh-golang-autopkgtest PASS

[Launchpad Janitor (janitor)]

This bug was fixed in the package libpod - 2.0.6+dfsg1-1ubuntu1.2

---------------
libpod (2.0.6+dfsg1-1ubuntu1.2) groovy; urgency=medium

  * Fix FTBFS due to new docker version.
    - d/rules: do not symlink the vendored
      golang-github-seccomp-libseccomp-golang-dev in docker.io to the build
      directory in dh_auto_configure. It is not vendored in docker.io package
      as it was before.

libpod (2.0.6+dfsg1-1ubuntu1.1) groovy; urgency=medium

  * Enable patch to fix build against newer runc version (LP: #1921011)
    - d/p/series: uncomment Fix-build-with-new-version-of-runc.patch

 -- Lucas Kanashiro <email address hidden> Tue, 23 Mar 2021 19:03:42 -0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package golang-github-containers-buildah - 1.15.2-1ubuntu2.2

---------------
golang-github-containers-buildah (1.15.2-1ubuntu2.2) groovy; urgency=medium

  * Fix FTBFS due to new docker version.
    - d/control: add dependency on golang-github-seccomp-libseccomp-golang-dev.
      It is not vendored in docker.io package as it was before.
    - d/rules: do not symlink the vendored
      golang-github-seccomp-libseccomp-golang-dev in docker.io to the build
      directory in dh_auto_configure.

golang-github-containers-buildah (1.15.2-1ubuntu2.1) groovy; urgency=medium

  * Enable patch to fix build against newer runc version (LP: #1921011)
    - d/p/series: uncomment build-with-new-runc.patch

 -- Lucas Kanashiro <email address hidden> Tue, 23 Mar 2021 18:45:45 -0300

[Robie Basak (racb)]

The verification of the Stable Release Update for libpod has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.