Bootstrap Opac: More Details button does not change on use

Bug #1920039 reported by Garry Collum
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.7
Fix Released
Medium
Unassigned
3.8
Fix Released
Medium
Unassigned

Bug Description

In the Bootstrap Opac the More Details button on the record page continues to display the text 'More Details' after it is pressed. The expected behavior is that it should toggle to display 'Less Details'.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Garry Collum (gcollum) wrote :
tags: added: pullrequest
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: signedoff
Revision history for this message
John Amundson (jamundson) wrote :

Noting it should say "Fewer Details" instead of "Less Details".

Revision history for this message
Garry Collum (gcollum) wrote :

All the above patch does is fix the code that was not working. I am going to make a note pertaining to the button text on https://bugs.launchpad.net/evergreen/+bug/1919494

Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

This needed a rebase after bug 1919494 was committed. Rebased branch can be found here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1920039_bootstrap_opac_more_or_less_details_button_rebase

user/mmorgan/lp1920039_bootstrap_opac_more_or_less_details_button_rebase

tags: removed: signedoff
Changed in evergreen:
milestone: none → 3.8.1
assignee: Michele Morgan (mmorgan) → nobody
Revision history for this message
John Amundson (jamundson) wrote :

Confirmed text updates when clicked and that "Fewer Details" is being used.

I have tested this code and consent to signing off on it with my name, John Amundson, and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
milestone: 3.8.1 → 3.9-beta
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Works for me! Pushed to master, rel_3_8, and rel_3_7.

Thanks Garry, Terran, John, and Michele!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Jason Stephenson (jstephenson) → nobody
milestone: 3.9-beta → 3.9-rc
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.