The More details button is not translatable

Bug #1919494 reported by Eva Cerninakova
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.7
Fix Released
Undecided
Unassigned

Bug Description

The "More details button" in record page in Bootstrap OPAC (/Open-ILS/src/templates-bootstrap/opac/parts/record/summary.tt2, line 74) is not marked for translation.
The correct contents of the line should be:
                        class="btn btn-action btn-sm my-3"><i class="fas fa-info-circle" aria-hidden="true"></i> [% l("More Details") %]</button>

Evergreen 3.7

Eva Cerninakova (ece)
tags: added: bitesize i18n opac
Garry Collum (gcollum)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Garry Collum (gcollum) wrote :

"Less Details" is also not translatable. See the notes for bug https://bugs.launchpad.net/evergreen/+bug/1920039

It is noted that "Less Details" should display "Fewer Details" instead.

Revision history for this message
Garry Collum (gcollum) wrote :

A proposed fix is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=68510f17eb5ed20cf961b32c70e6292046e1d231

This patch does not rely on the patch from lp1920039. If that patch is not applied the easiest way to test this patch is to see if the text for the buttons display correctly when viewing the page source in the browser.

Garry Collum (gcollum)
tags: added: pullrequest
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
milestone: none → 3.8.1
Revision history for this message
Michele Morgan (mmorgan) wrote :

Pushed to rel_3_7, rel_3_8 and master. Thanks Eva, Garry and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Michele Morgan (mmorgan) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.