Wrong (or no) signals are emitted when icons are added / removed

[Marco Trevisan (Treviño)]

[ Impact ]

When adding and removing signals the indicators extension should emit signals following the protocol
  https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierWatcher/

So we should emit the service name by default when known

[ Test case ]

Run
 dbus-monitor --session "interface='org.kde.StatusNotifierWatcher'"

When an indicator is added, signals such as should be emitted:

signal time=1616029764.911986 sender=:1.34490 -> destination=(null destination) serial=3905 path=/StatusNotifierWatcher; interface=org.kde.StatusNotifierWatcher; member=StatusNotifierItemRegistered
   string ":1.109/org/ayatana/NotificationItem/psensor"
signal time=1616029764.928864 sender=:1.34490 -> destination=(null destination) serial=3991 path=/StatusNotifierWatcher; interface=org.kde.StatusNotifierWatcher; member=StatusNotifierItemRegistered
   string ":1.34459/StatusNotifierItem"

When removed:
signal time=1616033768.529066 sender=:1.34490 -> destination=(null destination) serial=8711 path=/StatusNotifierWatcher; interface=org.kde.StatusNotifierWatcher; member=StatusNotifierItemUnregistered
   string ":1.34649/StatusNotifierItem"

Removed events should be also emitted when the extension is disabled via gnome-shell-extension-prefs

[ Regression potential ]

Some clients won't interpret the events correctly causing the indicator not to work as expected

[Chris Halse Rogers (raof)]

An upload of gnome-shell-extension-appindicator to focal-proposed has been rejected from the upload queue for the following reason: "Please re-upload without the icon-patch + patch reverting the icon-patch in debian/patches. Otherwise looks ok.".

[Chris Halse Rogers (raof)]

Hello Marco, or anyone else affected,

Accepted gnome-shell-extension-appindicator into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-appindicator/33.1-0ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Marco Trevisan (Treviño) (3v1n0)]

Confirmed working:

method call time=1618505915.474415 sender=:1.35592 -> destination=:1.34 serial=17 path=/StatusNotifierWatcher; interface=org.kde.StatusNotifierWatcher; member=RegisterStatusNotifierItem
   string "/org/ayatana/NotificationItem/Hello"
signal time=1618505915.487399 sender=:1.34 -> destination=(null destination) serial=179639 path=/StatusNotifierWatcher; interface=org.kde.StatusNotifierWatcher; member=StatusNotifierItemRegistered
   string ":1.35592/org/ayatana/NotificationItem/Hello"

signal time=1618505925.222270 sender=:1.34 -> destination=(null destination) serial=179654 path=/StatusNotifierWatcher; interface=org.kde.StatusNotifierWatcher; member=StatusNotifierItemUnregistered
   string ":1.35592/org/ayatana/NotificationItem/Hello

gnome-shell-extension-appindicator:
  Installato: 33.1-0ubuntu0.20.04.2
  Candidato: 33.1-0ubuntu0.20.04.2
  Tabella versione:
 *** 33.1-0ubuntu0.20.04.2 400
        400 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        400 http://archive.ubuntu.com/ubuntu focal-proposed/main i386 Packages

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-appindicator - 33.1-0ubuntu0.20.04.2

---------------
gnome-shell-extension-appindicator (33.1-0ubuntu0.20.04.2) focal; urgency=medium

  * debian/patches:
    - Register the StatusNotifierWatcher as soon as possible (LP: #1905370)
    - Handle scroll events on indicator label (LP: #1919924)
    - Emit expected signals / arguments when (un)registering indicators
      (LP: #1919927)
    - Ensure we call proper method during logging

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 18 Mar 2021 03:42:58 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-shell-extension-appindicator has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.