Missing to package ceph-kvstore-tool, ceph-monstore-tool, ceph-osdomap-tool in bionic-train UCA release

[dongdong tao]

ceph-kvstore-tool, ceph-monstore-tool, ceph-osdomap-tool were shipped within ceph-test package,but the ceph-test package was dropped by [0] in bionic-train UCA release.

I believe the reason is that most of the binaries (except those 3 tools) in ceph-test package are meant for just testing and developing, they are not needed for production env, so the idea to drop this package is good, but those 3 tools were also dropped along with this package.

Those 3 tools are very important to troubleshoot production issues, so we need to add them back.

Since Luminous, upstream realized that it doesn't make sense to put them into ceph-test package, so they've moved those 3 tools to different packages in PR[1].

So, to fix this, we should do the same as upstream, which is :

Move ceph-kvstore-tool to ceph-base package
Move ceph-monstore-tool to ceph-mon package
Move ceph-osdomap-tool to ceph-osd package

Worth mentioning that, upstream also added a PR[2] after [1] was landed to fix an upgrade failure, it claims that [1] didn't update the relationship between those packages accordingly, thus caused the upgrade failure

Note that this only affects Train, Ussuri does contain those 3 tools.

[0]https://launchpad.net/ubuntu/+source/ceph/14.2.1-0ubuntu1
[1]https://github.com/ceph/ceph/pull/18289
[2]https://github.com/ceph/ceph/pull/18474

[Dariusz Gadomski (dgadomski)]

I have prepared and tested a build targetting this (available in ppa:dgadomski/ceph-lp1917288).

During the tests I was mainly focusing on the following upgrade paths to make sure everything works as expected:
1. stein -> train - no issues, but old ceph-test was left installed leaving garbage under /usr/lib/ceph/bin
2. train -> ussuri
3. stein -> ussuri
4. stein -> ppa (train)
5. ppa (train) -> ussuri

When using the ppa version upon installing of ceph-base, ceph-osd or ceph-mon a removal of ceph-test was offered (despite no actual conflict due to path differences, but we don't want to leave unnecessary artifacts behind).

[Corey Bryant (corey.bryant)]

Hello dongdong, or anyone else affected,

Accepted ceph into train-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:train-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-train-needed to verification-train-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-train-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Pedro Principeza (pprincipeza)]

Tests on Bionic/Train:

.. While running ceph* packages on 14.2.11-0ubuntu0.19.10.1~cloud4:

$ ceph-kvstore-tool
ceph-kvstore-tool: command not found

.. Upgraded to 14.2.18-0ubuntu0.19.10.1~cloud1 in train-proposed:

$ sudo dpkg -l | grep ceph
ii ceph 14.2.18-0ubuntu0.19.10.1~cloud1 amd64 distributed storage and file system
ii ceph-base 14.2.18-0ubuntu0.19.10.1~cloud1 amd64 common ceph daemon libraries and management tools
ii ceph-common 14.2.18-0ubuntu0.19.10.1~cloud1 amd64 common utilities to mount and interact with a ceph storage cluster
ii ceph-mgr 14.2.18-0ubuntu0.19.10.1~cloud1 amd64 manager for the ceph distributed file system
ii ceph-mon 14.2.18-0ubuntu0.19.10.1~cloud1 amd64 monitor server for the ceph storage system
ii ceph-osd 14.2.18-0ubuntu0.19.10.1~cloud1 amd64 OSD server for the ceph storage system

.. The tools no longer missing:

$ for i in ceph-osdomap-tool ceph-monstore-tool ceph-kvstore-tool; do sudo dpkg -S $(which $i); done
ceph-osd: /usr/bin/ceph-osdomap-tool
ceph-mon: /usr/bin/ceph-monstore-tool
ceph-base: /usr/bin/ceph-kvstore-tool

.. Their basic execution:

$ ceph-kvstore-tool -v
ceph version 14.2.18 (befbc92f3c11eedd8626487211d200c0b44786d9) nautilus (stable)

$ ceph-osdomap-tool -v
ceph version 14.2.18 (befbc92f3c11eedd8626487211d200c0b44786d9) nautilus (stable)

$ ceph-monstore-tool -v
usage: ceph-monstore-tool <store-path> <cmd> [args|options]
...

Adding verification-done tags / removing verification-needed tags. Let me know if further testing is needed.

[James Page (james-page)]

The verification of the Stable Release Update for ceph has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[James Page (james-page)]

This bug was fixed in the package ceph - 14.2.18-0ubuntu0.19.10.1~cloud1
---------------

 ceph (14.2.18-0ubuntu0.19.10.1~cloud1) bionic; urgency=medium
 .
   * d/*.install: restore ceph-*-tool binaries in packages after removal
     of ceph-test binary package (LP: #1917288).