oss4-dkms: build failure with linux 5.11

Bug #1916872 reported by Andrea Righi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oss4 (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

[Impact]

oss4-dkms fails to build on the latest hirsute 5.11 kernel with the following error:

/var/lib/dkms/oss4/4.2-build2010/build/core/oss_core.c:90:10: error: implicit declaration of function ‘get_seconds’ [-Werror=implicit-function-declaration]
   90 | return get_seconds ();
      | ^~~~~~~~~~~

This happens because of commit aba428a0c612bb259891307da12e22efd0fab14c ("timekeeping: Remove unused get_seconds()").

[Test case]

Install oss4-dkms.

[Fix]

Re-introduce in oss4 the get_seconds() interface and use the standard interface ktime_get_real_seconds().

[Regression potential]

The added get_seconds() interface is going to be used only with kernels >= 5.11, so all the previously supported kernels won't be affected by this change. Potential regressions are possible only in kernels >= 5.11.

Tags: patch
Revision history for this message
Andrea Righi (arighi) wrote :

Attached debdiff fixes the build errors.

tags: added: patch
Revision history for this message
Andrea Righi (arighi) wrote :

Edit: update launchpad bug in the changelog.

Seth Forshee (sforshee)
Changed in oss4 (Ubuntu):
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package oss4 - 4.2-build2010-5ubuntu8

---------------
oss4 (4.2-build2010-5ubuntu8) hirsute; urgency=medium

  * Support Linux 5.11 (LP: #1916872):
    - debian/patches/520-Linux-5.11-re-introduce-get-seconds.patch

 -- Andrea Righi <email address hidden> Thu, 25 Feb 2021 11:32:44 +0000

Changed in oss4 (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.