Please merge liburing 0.7-3 (main) from Debian unstable (main)

[Mauricio Faria de Oliveira]

New version (0.7-3) available without our delta (already forwarded upstream), needs merge.

Reverse dependencies [2] need No-Change-Rebuilds to pick up the new ABI,
which unfortunately has been broken between 0.6-3 and 0.7-3 [3]:
- mpd, samba, plocate, qemu

Autopkgtests PASS on amd64/arm64/ppc64el/s390x, not run on riscv64, and fail on armhf (but not a regression); see the latest per-arch log.gz in
[4] for runs against a PPA.

Autopkgtests for the reverse dependencies:
- mpd: PASS (although failing consistently on s390x; will take a look)
- samba: FAIL on cifs-share-access-uring (regression due to ABI breakage;
  passes with no-change-rebuilt samba and new liburing)
- plocate: no tests.
- qemu: no tests.

Merge request: [1]

[1] https://code.launchpad.net/~mfo/ubuntu/+source/liburing/+git/liburing/+merge/397393

[2] Reverse Dependencies:

$ apt-cache rdepends liburing1 | awk '/^ / { print $1 }' | while read rdep; do apt-cache show $rdep | awk '/^Package:/ || /^Source:/ { print $2 }' | tail -n1; done | sort -u
liburing
mpd
plocate
qemu
samba

[3] Debian Bug #972758
https://bugs.debian.org/972758

[4] https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute-mfo-lp1914145?format=plain

[Christian Ehrhardt  (paelzer)]

Thanks for your work on this, I'll have another qemu upload ready soon anyway.
Let us see how the timing works, out - but there likely is no need for a no-change rebuild upload for it.

[Mauricio Faria de Oliveira (mfo)]

liburing built successfully on all archs in hirsute-proposed.

autopkgtests look green (!) on amd64/arm64/ppc64el/s390x and
fail on armhf as seen previously (not a regression.)

autopkgtests for the reverse dependencies, in update_excuses:

- samba: fail consistently in all archs -- this is known and is fixed with the no-change rebuild.

  current: [1]
 smbclient-share-access-uring FAIL non-zero exit status 1

  no-change rebuild: [2]
 smbclient-share-access-uring PASS

- mpd: fail in s390x, even w/ a few retries, i'll take a look.

  however, this is not the version in hirsute-proposed.
  it was blocked on build failure on ppc64el [3], no logs,
  i just retried it, and it finished successfully.

  we'll need the no-change rebuild anyway, on top of -proposed.

[1] https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute-mfo-lp1914145/hirsute/amd64/s/samba/20210202_233735_bb529@/log.gz
[2] https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute-mfo-lp1914145/hirsute/amd64/s/samba/20210203_220550_7e02e@/log.gz

[3]

update_excuses:

mpd (0.22.3-1 to 0.22.4-1)
...
    Issues preventing migration:
    missing build on ppc64el: mpd (from 0.22.3-1)
    arch:ppc64el not built yet, autopkgtest delayed there
...

[Mauricio Faria de Oliveira (mfo)]

Hi Christian,

Attaching the debdiffs with no change rebuilds.

- samba is the most important, since it also fixes an autopkgtest failure to unblock liburing in hirsute-proposed.

- mpd also has autopkgtests, but there's still a version in -proposed as of now, so maybe it needs to wait (but since it's a no change rebuild, maybe it can be overriden if needed?)

- plocate has no autopkgtests, lower priority.

- qemu neither, and is up to you depending on your qemu upload, per our discussion.

Thanks!
Mauricio

[Christian Ehrhardt  (paelzer)]

It is not "hurting" but usually no change rebuilds do not add bug tasks for the packages and ref the bug. Instead they usually mention the version it is for like "No change rebuild to pick up liburing 0.7" or such.

Anyway, this really isn't bad - in case stuff breaks everyone will find this bug as one place to discuss :-)

All four LGTM and I've sponsored them to get the lib transition completed.

[Mauricio Faria de Oliveira (mfo)]

Thanks for the info and the uploads.

That's good to know!

I didn't know it, and just added the bug reference in case it'd
be useful to find out why the no change rebuild was needed.

But I guess that can go in the changelog entry itself, right?

[Launchpad Janitor (janitor)]

This bug was fixed in the package liburing - 0.7-3ubuntu1

---------------
liburing (0.7-3ubuntu1) hirsute; urgency=medium

  * Merge with Debian unstable. (LP: #1914145)
    Remaining changes:
    - Fix build and autopkgtest self tests (LP: 1878006).
      - d/rules: build time tests require root
      - d/rules: fix the DEB_GAIN_ROOT_CMD call to dh_auto_test
      - d/rules: test succeed now, stop passing || true
      - d/t/control: mark unit tests to need root and a VM
      - d/t/test-build: link tests fail in containers
      - d/p/disable-known-failures.patch: disable tests known to fail
  * Dropped changes:
    - d/t/test-build: io_uring-link no more exists as example, but link-cp does
      [in Debian 0.7-1]
  * Added changes:
    - d/t/test-build: io_uring-cp test fails in all archs

liburing (0.7-3) unstable; urgency=medium

  * Switch to Standards-Version 4.5.1 (no changes needed).
  * Add new debian/upstream/metadata file.

liburing (0.7-2) unstable; urgency=medium

  * Bump the minimum version for all symbols in the symbols file, to
    workaround that 0.7 upstream version unintentionally broke the ABI
    without bumping the SONAME. (Closes: #972758)

liburing (0.7-1) unstable; urgency=medium

  * New upstream version.
  * Refactor debian/tests/test-build into two loops to avoid repetition.
  * Use link-cp instead of io_uring-cp as example command to test.
    Reported by Christian Ehrhardt <email address hidden>.

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 03 Feb 2021 09:39:10 -0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package plocate - 1.1.3-1build1

---------------
plocate (1.1.3-1build1) hirsute; urgency=medium

  * No change rebuild to pick up liburing. (LP: #1914145)

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 03 Feb 2021 19:43:24 -0300

[Mauricio Faria de Oliveira (mfo)]

TL;DR: giving it some time (tomorrow AM) for update_excuses to possibly
realize that mpd/samba/qemu deps are satisfiable (or for me to realize
i might be missing something; details below.)

---

liburing migrated after some autopkgtests/triggers tweaks.
plocate migrated.

mpd, samba, qemu are blocked due to unsatisfiable deps (and one uninstallable).

I could not reproduce any of those w/ selective upgrading from -proposed;
installing the mentioned package names just work, and when some deps are
needed from -proposed as well, they're fromt the same source package.

So I'll wait a bit more for perhaps update_excuses.html to update, in case
it's out of date; i've looked at update_output.txt but these packages are
not listed in it.

---

mpd (0.22.3-1 to 0.22.4-1build1)
...
    mpd/amd64 has unsatisfiable dependency

 $ sudo apt install --dry-run mpd/hirsute-proposed >/dev/null 2>&1; echo $?
 0

 $ sudo apt install --dry-run -t hirsute-proposed mpd >/dev/null 2>&1; echo $?
 0
...
    migrating mpd/0.22.4-1build1/amd64 to testing makes libtest-corpus-audio-mpd-perl/1.120990-2.1/amd64 uninstallable

 $ sudo apt install --dry-run libtest-corpus-audio-mpd-perl mpd/hirsute-proposed >/dev/null 2>&1; echo $?
 0

samba (2:4.13.3+dfsg-1ubuntu1 to 2:4.13.3+dfsg-1ubuntu2)
...
    samba-vfs-modules/amd64 has unsatisfiable dependency
...

 $ sudo apt-get install --dry-run samba-vfs-modules/hirsute-proposed >/dev/null 2>&1; echo $?
 100

 $ sudo apt-get install --dry-run -t hirsute-proposed samba-vfs-modules >/dev/null 2>&1; echo $?
 0

 $ sudo apt-get install --dry-run {samba-vfs-modules,samba-libs,libwbclient0}/hirsute-proposed >/dev/null 2>&1; echo $?
 0

qemu (1:5.2+dfsg-3ubuntu1 to 1:5.2+dfsg-3ubuntu2)
...
    qemu-guest-agent/amd64 has unsatisfiable dependency

 $ sudo apt install --dry-run qemu-guest-agent/hirsute-proposed >/dev/null 2>&1; echo $?
 0

 $ sudo apt install --dry-run -t hirsute-proposed qemu-guest-agent >/dev/null 2>&1; echo $?
 0

    qemu-system-x86/amd64 has unsatisfiable dependency

 $ sudo apt-get install --dry-run qemu-system-x86/hirsute-proposed >/dev/null 2>&1; echo $?
 100

 $ sudo apt-get install --dry-run -t hirsute-proposed qemu-system-x86 >/dev/null 2>&1; echo $?
 0

 $ sudo apt-get install --dry-run {qemu-system-x86,qemu-system-common,qemu-system-data,qemu-block-extra}/hirsute-proposed >/dev/null 2>&1; echo $?
 0

[Mauricio Faria de Oliveira (mfo)]

That seemed to be correct; update_excuses is now updated,
and autopkgtests for mpd/samba/qemu are now running.

There were 3 regressions reported, each on a single arch,
which seemed to be unrelated to liburing; so just sent a
rerun request for them.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mpd - 0.22.4-1build1

---------------
mpd (0.22.4-1build1) hirsute; urgency=medium

  * No change rebuild to pick up liburing. (LP: #1914145)

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 03 Feb 2021 19:32:03 -0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package samba - 2:4.13.3+dfsg-1ubuntu2

---------------
samba (2:4.13.3+dfsg-1ubuntu2) hirsute; urgency=medium

  * No change rebuild to pick up liburing, and also
    fix d/t/cifs-share-access-uring. (LP: #1914145)

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 03 Feb 2021 09:14:25 -0300

[Mauricio Faria de Oliveira (mfo)]

Some armhf autopkgtests finally ran, and unblocked mpd and samba.
Now re-running some systemd tests that have (again) been flaky, on amd64 and ppc64el, to unblock qemu; the last piece missing.

[Christian Ehrhardt  (paelzer)]

FYI bug 1915126 for the systemd autopkgtest fails, not related to our uploads IMHO.
But still needs to be resolved before everything completes ...

[Launchpad Janitor (janitor)]

This bug was fixed in the package qemu - 1:5.2+dfsg-6ubuntu2

---------------
qemu (1:5.2+dfsg-6ubuntu2) hirsute; urgency=medium

  * d/p/u/lp-1916705-disas-Fix-build-with-glib2.0-2.67.3.patch: Fix FTFBS due
    to glib2.0 >=2.67.3 (LP: #1916705)

qemu (1:5.2+dfsg-6ubuntu1) hirsute; urgency=medium

  * Merge with Debian unstable, includes fixes for
    - build operates differently if source is a git repo (LP: #1887535)
    Remaining changes:
    - qemu-kvm to systemd unit
      - d/qemu-kvm-init: script for QEMU KVM preparation modules, ksm,
        hugepages and architecture specifics
      - d/qemu-system-common.qemu-kvm.service: systemd unit to call
        qemu-kvm-init
      - d/qemu-system-common.install: install helper script
      - d/qemu-system-common.qemu-kvm.default: defaults for
        /etc/default/qemu-kvm
      - d/rules: call dh_installinit and dh_installsystemd for qemu-kvm
    - Distribution specific machine type (LP: 1304107 1621042)
      - d/p/ubuntu/define-ubuntu-machine-types.patch: distro machine types
      - d/qemu-system-x86.NEWS Info on fixed machine type definitions
        for host-phys-bits=true (LP: 1776189)
      - add an info about -hpb machine type in debian/qemu-system-x86.NEWS
      - provide pseries-bionic-2.11-sxxm type as convenience with all
        meltdown/spectre workarounds enabled by default. (LP: 1761372).
      - ubuntu-q35 alias added to auto-select the most recent q35 ubuntu type
    - Enable nesting by default
      - d/p/ubuntu/enable-svm-by-default.patch: Enable nested svm by default
        in qemu64 on amd
        [ No more strictly needed, but required for backward compatibility ]
    - improved dependencies
      - Make qemu-system-common depend on qemu-block-extra
      - Make qemu-utils depend on qemu-block-extra
      - let qemu-utils recommend sharutils
    - tolerate ipxe size change on migrations to >=18.04 (LP: 1713490)
      - d/p/ubuntu/pre-bionic-256k-ipxe-efi-roms.patch: old machine types
        reference 256k path
      - d/control-in: depend on ipxe-qemu-256k-compat-efi-roms to be able to
        handle incoming migrations from former releases.
    - d/control-in: Disable capstone disassembler library support (universe)
    - d/qemu-system-x86.README.Debian: add info about updated nesting changes
    - d/control*, d/rules: disable xen by default, but provide universe
      package qemu-system-x86-xen as alternative
      [includes compat links changes of 5.0-5ubuntu4]
    - allow qemu to load old modules post upgrade (LP 1847361)
      - Drop d/qemu-block-extra.*.in, d/qemu-system-gui.*.in
      - d/rules: Drop generating package version into maintainer scripts
      - d/qemu-system-gui.prerm: add no-op prerm to overcome upgrade issues on
        the bad old prerm (LP 1906245 1905377)
    - d/p/ubuntu/lp-1907789-build-no-pie-is-no-functional-liker-flag.patch: fix
      ld usage of -no-pie (LP 1907789)
  * Added changes
    - d/p/u/lp-1916230-hw-s390x-fix-build-for-virtio-9p-ccw.patch: fix
      virtio-9p-ccw being missing (LP: #1916230)

qemu (1:5.2+dfsg-6) unstable; urgency=medium

  * deprecate qemu-debootstrap. It is not needed anymore with
    binfmt F flag, since eve...