Add site config options to config-defaults that can be overridden by config.php

Bug #1912121 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Gold

Bug Description

There are a number of site configuration options in Admin menu -> Configure site -> Site options that can be added to the config.php file and then not be changed by a site admin. These are not yet listed in config-defaults.php. That makes it harder to know which options set on the front-end could be added to the config.php file to prevent a site admin to unset them accidentally. Since it requires that code is read to find that out, it's rather cumbersome to achieve without trial and error.

From Robert: It's all the options that have $OVERRIDDEN as part of their markup and use get_config() to fetch their default value as get_config() uses the values in config.php over what is in the db and $OVERIDDEN just makes the filed disabled if using config.php value.

All of these options should be added to lib/config-defaults.php in their own section: Can be set in 'Site options' so it's clear that both ways are possible.

Only brief comments are necessary as the details are in the Mahara manual. The main comment could even be taken from the option's description line for the most part.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11528

Gold (gold.catalyst)
Changed in mahara:
assignee: nobody → Gold (gold.catalyst)
Changed in mahara:
status: Confirmed → In Progress
milestone: none → 21.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11528
Committed: https://git.mahara.org/mahara/mahara/commit/e79117e3bce99746326cbcadc77a852cf4750fd0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e79117e3bce99746326cbcadc77a852cf4750fd0
Author: Gold <email address hidden>
Date: Wed Jan 27 15:28:53 2021 +1300

Bug 1912121 Documenting vars available to config.php in the config-defaults.php file.

behatnotneeded

Change-Id: I1d1c40db2706f342cc9c4ba0aaa50f501c9a64ff

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: manual-update
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.