Mahara

View access sharing to institution needs some adjustment

Series 20.10
Bug #1908858

Bug #1908858 reported by Robert Lyon on 2020-12-21

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Mahara
19.10	Fix Released	High	Unassigned	Mahara 19.10.6
20.04	Fix Released	High	Unassigned	Mahara 20.04.3
20.10	Fix Released	High	Unassigned	Mahara 20.10.1
21.04	Fix Released	High	Unassigned	Mahara 21.04.0

Bug Description

When admin is in an institution then profile page access displays incorrectly - it says 'Shared with' instead of the actual institution name

See attached image

Revision history for this message

Robert Lyon (robertl-9) wrote on 2020-12-21:

Screenshot_2020-12-21 Edit access - Mahara(1).png Edit (8.2 KiB, image/png)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-21: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11507

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-21: A change has been merged

Reviewed: https://reviews.mahara.org/11507
Committed: https://git.mahara.org/mahara/mahara/commit/1c07c4be81eca8d9ac4004b31b5a28ac6d0160d0
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit 1c07c4be81eca8d9ac4004b31b5a28ac6d0160d0
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 18:04:17 2020 +1300

Bug 1908858: Admin's profile page access not correct

When the admin is within an institution.
The institution name is being displayed as 'Shared with'

This is due to an error in the fix for Bug 1501133

Also an issue with stop/start dates - removing obsolete check

Change-Id: Iddf10abfe9b731d5571745811cbd7c3f792f687b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-21:

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11508

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-21:

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11509

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-21: A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11510

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-21: A change has been merged

Reviewed: https://reviews.mahara.org/11508
Committed: https://git.mahara.org/mahara/mahara/commit/4db44ec8085544e4a50025f296bfdd05545e344e
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 4db44ec8085544e4a50025f296bfdd05545e344e
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 18:04:17 2020 +1300

Bug 1908858: Admin's profile page access not correct

When the admin is within an institution.
The institution name is being displayed as 'Shared with'

This is due to an error in the fix for Bug 1501133

Also an issue with stop/start dates - removing obsolete check

Change-Id: Iddf10abfe9b731d5571745811cbd7c3f792f687b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1c07c4be81eca8d9ac4004b31b5a28ac6d0160d0)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-23:

Reviewed: https://reviews.mahara.org/11510
Committed: https://git.mahara.org/mahara/mahara/commit/a3d31c945f434c41ddf0b5052619a1a6e6db4a68
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit a3d31c945f434c41ddf0b5052619a1a6e6db4a68
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 18:04:17 2020 +1300

Bug 1908858: Admin's profile page access not correct

When the admin is within an institution.
The institution name is being displayed as 'Shared with'

This is due to an error in the fix for Bug 1501133

Also an issue with stop/start dates - removing obsolete check

Change-Id: Iddf10abfe9b731d5571745811cbd7c3f792f687b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1c07c4be81eca8d9ac4004b31b5a28ac6d0160d0)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-12-23:

Reviewed: https://reviews.mahara.org/11509
Committed: https://git.mahara.org/mahara/mahara/commit/44075cd26808d42f7408c03ada36a0ccfed8c078
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 44075cd26808d42f7408c03ada36a0ccfed8c078
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 18:04:17 2020 +1300

Bug 1908858: Admin's profile page access not correct

When the admin is within an institution.
The institution name is being displayed as 'Shared with'

This is due to an error in the fix for Bug 1501133

Also an issue with stop/start dates - removing obsolete check

Change-Id: Iddf10abfe9b731d5571745811cbd7c3f792f687b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1c07c4be81eca8d9ac4004b31b5a28ac6d0160d0)

Kristina Hoeppner (kris-hoeppner) on 2022-02-10

no longer affects:

mahara