Angular Staff Catalog Preferences: Exclude Electronic Resources doesn't stick

[Terran McCanna]

In 3.6.1:

If you select the "Add the 'Exclude Electronic Resources' checkbox to the main search form." option in Catalog Preferences, the checkbox appears but then disappears after you do a search or navigate away from the catalog.

[Elaine Hardy (ehardy)]

While the checkbox is not sticky -- nor is the check in Catalog preferences to add the box, excluding eresources is sticky in subsequent searches. User has to return to catalog preferences, check the "Add the 'Exclude Electronic Resources' again so that it becomes visible to be unchecked.

The checkbox should be visible as a filter until user unchecks it in catalog preferences.

[Jennifer Weston (jweston)]

+1 to checkbox being visible as a filter if the box is checked to exclude electronic resources (and only hidden if the preference is unchecked); It is important to display all limiters applied when searching.

[Jennifer Pringle (jpringle-u)]

It looks like this is fixed in 3.7beta.

I checked Exclude Electronic Resources under Catalog Preferences. I've done multiple searches, opened the catalogue in a new tab, logged out and back in and then opened the catalogue and the Exclude checkbox has remained as a search option for Keyword Search.

[Terran McCanna (tmccanna)]

Thanks, Jennifer - I've verified that it is working now on a 3.7ish test server. Marking this one Won't Fix.

[Terran McCanna (tmccanna)]

Reopening this as per discussion on list-serv: It is fixed in 3.7 but not in 3.6.x but I haven't been able to figure out which code changed to fix the problem.

[Andrea Neiman (aneiman)]

I tried to re-add this to 3.7 (just for recordkeeping purposes) but the only targetable 3.7 is 3.7.1 and I don't want to confuse things :)

[Terran McCanna (tmccanna)]

Actually, it looks like it was fixed for 3.6.2 here:

https://bugs.launchpad.net/evergreen/+bug/1885767

[Dan Guarracino (dguarracino)]

We are on 3.6.3 and are still encountering this.

Selecting the "Exclude Electronic Resources" checkbox in Catalog Preferences causes the checkbox to appear on the search form. The checkbox on the search form can then be used to actually exclude electronic resources from the search.

However, the checkbox on the search form disappears as soon as a catalog search is performed. If I select the option to display "Exclude Electronic Resources" in Catalog Preferences, I then get the option (again) on the search form. The option on the search form is still checked if I had just performed a catalog search.

gif attached (sorry for bad quality!)

[Terran McCanna (tmccanna)]

Okay, removed the duplicate flag as there are several reports of it still being a problem in 3.6.3 (but fixed in 3.7).

[Michele Morgan (mmorgan)]

I am not seeing that the state of the checkbox is fixed in 3.7.

To clarify:

I am seeing that the existence of the Exclude Electronic Resources checkbox on the search form is working as expected as controlled by the workstation setting eg.staffcat.exclude_electronic.

However, the state of the checkbox (whether the checkbox is checked or not) is NOT sticky, as expected.

Bug 1885767 added a workstation setting to control whether the Exclude Electronic Resources checkbox appears on the search form, but does not provide a workstation setting to control whether the box should be checked or not.

[Jennifer Weston (jweston)]

Making note of separate suggestion and discussion on bug 1923500 to include checkboxes when search templates are saved as it could be relevant to any changes to the Catalog Preferences

[Garry Collum (gcollum)]

Confirming that this is not fixed in 3.7.1.

[Benjamin Murphy (benjamin.murphy)]

What we see in 3.7.1 is that you click on the Catalog Preferences in the search screen, then click on the "Exclude Electronic Resources" checkbox, the checkbox will appear in the search form, but when we navigate back to the search form from elsewhere, the checkbox has disappeared.

[Mary Llewellyn (mllewell)]

It seems to be OK for us on 3.6, but we're testing 3.6.5 and I just encountered this disappearing checkbox.

[Mary Llewellyn (mllewell)]

No longer an issue for us in 3.6.5.

[Vince Giordano (vgiordano-deactivatedaccount)]

This remains an issue in in 3.7.2

[Galen Charlton (gmc)]

I've tracked down the cause of why the search filter checkbox is not consistently appearing; the relevant workstation setting is not always present depending on how the version upgrade to 3.6 was done. In fact, DB schema revisions 1235 through 1240 may be missing from DBs that were upgraded to 3.6.0 at some point in their history. I'll investigate further.

[Michele Morgan (mmorgan)]

Related: bug 1920826

[Galen Charlton (gmc)]

Note that the fix for this will be in bug 1920826. I had marked this bug as a duplicate of that, but changed my mind.

[Andrea Neiman (aneiman)]

Going ahead and marking as a duplicate of bug 1920826