libfprint may cause fprintd to crash on identification

[Marco Trevisan (Treviño)]

[ Impact ]

When identification is used we may get a crash or a critical error when parsing the prints gallery data

[ Test case ]

Run:

 - fprintd-verify any

With a fingerprint reader supporting identification.
Fprintd should work as expected and journalctl -u fprintd.service should not show any critical error handling GObject's

[ Regression potential ]

Fingerprint structure data could not be free'd, causing a memory leak

[Brian Murray (brian-murray)]

Hello Marco, or anyone else affected,

Accepted libfprint into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.3+tod1-0ubuntu2~20.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Marco, or anyone else affected,

Accepted libfprint into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libfprint/1:1.90.2+tod1-0ubuntu1~20.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Shengyao Xue (xueshengyao)]

@Marco, I tried to test the version(1:1.90.2+tod1-0ubuntu1~20.04.4) in focal-proposed on a ThinkPad P15s, with the Synaptics 06cb:00bd fingerprint reader. I got the logs below, is there something wrong?

u@u-ThinkPad-P15s-Gen-2:~$ dpkg -l|grep libfprint
ii libfprint-2-2:amd64 1:1.90.2+tod1-0ubuntu1~20.04.4 amd64 async fingerprint library of fprint project, shared libraries
u@u-ThinkPad-P15s-Gen-2:~$ fprintd-list u
found 1 devices
Device at /net/reactivated/Fprint/Device/0
Using device /net/reactivated/Fprint/Device/0
Fingerprints for user u on Synaptics Sensors (press):
 - #0: right-index-finger
u@u-ThinkPad-P15s-Gen-2:~$ fprintd-verify u
Using device /net/reactivated/Fprint/Device/0
Listing enrolled fingers:
 - #0: right-index-finger
Verify result: verify-match (done)
u@u-ThinkPad-P15s-Gen-2:~$ fprintd-verify any
Using device /net/reactivated/Fprint/Device/0
ListEnrolledFingers failed: Failed to discover prints
u@u-ThinkPad-P15s-Gen-2:~$ journalctl -u fprintd.service |tail -n 5
1月 26 10:40:16 u-ThinkPad-P15s-Gen-2 systemd[1]: Starting Fingerprint Authentication Daemon...
1月 26 10:40:16 u-ThinkPad-P15s-Gen-2 systemd[1]: Started Fingerprint Authentication Daemon.
1月 26 10:41:06 u-ThinkPad-P15s-Gen-2 systemd[1]: fprintd.service: Succeeded.
1月 26 10:41:40 u-ThinkPad-P15s-Gen-2 systemd[1]: Starting Fingerprint Authentication Daemon...
1月 26 10:41:41 u-ThinkPad-P15s-Gen-2 systemd[1]: Started Fingerprint Authentication Daemon.
u@u-ThinkPad-P15s-Gen-2:~$

[Marco Trevisan (Treviño) (3v1n0)]

So the 'any' argument is broken in various old versions of fprintd, that's expected not to work.

[Marco Trevisan (Treviño) (3v1n0)]

Verified with libfprint 1:1.90.2+tod1-0ubuntu1~20.04.4 and fprintd 1.90.1-1ubuntu1:

(fprintd:61642): fprintd-DEBUG: 14:36:29.714: file_storage_discover_prints() for user 'u' in '/var/lib/fprint/u/synaptics/ea61678c21e3'
(fprintd:61642): fprintd-DEBUG: 14:36:29.717: user 'u' claiming the device: 0
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:29.831: 26275727182: ../libfprint/drivers/synaptics/synaptics.c:1248
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:30.110: sequence number is 4
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:30.110: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 0
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:30.110: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 1
(fprintd:61642): libfprint-device-DEBUG: 14:36:30.129: Device reported open completion
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:30.129: [synaptics] SYNAPTICS_CMD_NUM_STATES completed successfully
(fprintd:61642): libfprint-device-DEBUG: 14:36:30.129: Completing action 2 in idle!
(fprintd:61642): fprintd-DEBUG: 14:36:30.129: claimed device 0
(fprintd:61642): fprintd-DEBUG: 14:36:30.133: file_storage_discover_prints() for user 'u' in '/var/lib/fprint/u/synaptics/ea61678c21e3'
(fprintd:61642): fprintd-DEBUG: 14:36:30.133: adding finger 5 to the gallery
(fprintd:61642): fprintd-DEBUG: 14:36:30.133: file_storage_print_data_load(): loaded '/var/lib/fprint/u/synaptics/ea61678c21e3/5' Success
(fprintd:61642): fprintd-DEBUG: 14:36:30.133: adding finger 10 to the gallery
(fprintd:61642): fprintd-DEBUG: 14:36:30.133: file_storage_print_data_load(): loaded '/var/lib/fprint/u/synaptics/ea61678c21e3/a' Success
(fprintd:61642): fprintd-DEBUG: 14:36:30.133: start identification device 0
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:30.133: data is 0x55af48b83920
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:30.133: data is 0x7f4844001aa0
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:30.133: 26276028653: ../libfprint/drivers/synaptics/synaptics.c:816
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:30.133: sequence number is 5
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:30.133: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 0
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:30.133: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 1
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:30.133: Place Finger on the Sensor!
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:30.133: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 2
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:32.215: interrupt transfer done
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:32.215: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 3
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:32.216: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 4
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:32.216: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 0
(fprintd:61642): libfprint-SSM-DEBUG: 14:36:32.216: [synaptics] SYNAPTICS_CMD_NUM_STATES entering state 1
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:32.216: Finger is now on the sensor
(fprintd:61642): libfprint-synaptics-DEBUG: 14:36:32.216: Received message with 0 sequence number 0x91, ignoring!
(fprintd:61642): libfprint-SSM-DE...

[Marco Trevisan (Treviño) (3v1n0)]

Also tested in groovy with same version of fprintd and libfprint 1:1.90.3+tod1-0ubuntu2~20.10.2

[Launchpad Janitor (janitor)]

This bug was fixed in the package libfprint - 1:1.90.3+tod1-0ubuntu2~20.10.2

---------------
libfprint (1:1.90.3+tod1-0ubuntu2~20.10.2) groovy; urgency=medium

  * debian/patches:
    - image-device: Delay completion until deactivation (LP: #1897613)
    - Support more synaptics devices PIDs (LP: #1905593)
    - Ensure we properly handle references of prints galleries (LP: #1908107)

libfprint (1:1.90.3+tod1-0ubuntu2~20.10.1) groovy; urgency=medium

  * debian/gbp.conf:
    - Include debian's GNOME team preferred settings
    - Prepare for groovy branching
  * debian/patches (upstream cherry-picks):
    - Properly handle aes3k devices, resubmitting commands.
      This also needs proper commands cancellation (LP: #1897613)
    - Add support for new Synaptics devices IDs (LP: #1905593)
    - Fix vfs301 verification using device pointer on callbacks (LP: #1905597)
    - Ensure we do not waste power for unsupported devices (LP: #1905603)
    - Add identification support to synaptics driver.
      It allows to unlock / log-in with any finger. (LP: #1905600)

 -- Marco Trevisan (Treviño) <email address hidden> Mon, 14 Dec 2020 19:19:45 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for libfprint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libfprint - 1:1.90.2+tod1-0ubuntu1~20.04.4

---------------
libfprint (1:1.90.2+tod1-0ubuntu1~20.04.4) focal; urgency=medium

  * debian/patches:
    - image-device: Delay completion until deactivation (LP: #1897613)
    - Support more synaptics devices PIDs (LP: #1905593)
    - Ensure we properly handle references of prints galleries (LP: #1908107)

libfprint (1:1.90.2+tod1-0ubuntu1~20.04.3) focal; urgency=medium

  * debian/patches (upstream cherry-picks):
    - Properly handle aes3k devices, resubmitting commands.
      This also needs proper commands cancellation (LP: #1897613)
    - Add support for new Synaptics devices IDs (LP: #1905593)
    - Fix vfs301 verification using device pointer on callbacks (LP: #1905597)
    - Ensure we do not waste power for unsupported devices (LP: #1905603)
    - Add identification support to synaptics driver.
      It allows to unlock / log-in with any finger. (LP: #1905600)

 -- Marco Trevisan (Treviño) <email address hidden> Mon, 14 Dec 2020 19:28:09 +0100