cinder-backup does not allow to enable 'fast-diff' feature for backup images stored in ceph

[Christian Rohmann]

Problem:
       When backups are created with backend / driver being ceph, there
       currently is no way to enable the image feature, 'fast-diff'.
       Fast-diff adds another property to the object map, which makes it
       much faster to generate diffs between snapshots of an image, and the
       actual data usage of a snapshot much faster.

Features applied to backup images unfortunately do not depend on the regular cinder settings,
each feature is handled explicitly by a config option. Following this approach support for
EXCLUSIVE_LOCK and JOURNALING was implemented with https://review.opendev.org/c/openstack/cinder/+/413178

I created a patch with the proposed changes: https://review.opendev.org/c/openstack/cinder/+/766856/

[Christian Rohmann (christian-rohmann)]

Thank you michael-mcaleer for picking this up.

May I ask how I should go about getting a reviewer for my patch? - https://review.opendev.org/c/openstack/cinder/+/766856/

Who should I assign?

[Sofia Enriquez (lsofia-enriquez)]

Fix merged in W https://review.opendev.org/c/openstack/cinder/+/766856/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/782917
Committed: https://opendev.org/openstack/cinder/commit/cbf9def32b31bcc3d4894d05e6fe665005006492
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit cbf9def32b31bcc3d4894d05e6fe665005006492
Author: Christian Rohmann <email address hidden>
Date: Sun Dec 13 15:07:10 2020 +0100

    Add support for RBD fast-diff feature for backups stored in Ceph

        This change enables the FAST_DIFF feature for backup images stored
        via Ceph RBD. It is enabled together with EXCLUSIVE_LOCK and
        OBJECT_MAP as required.

        With FAST_DIFF enabled, the generation of diffs between images and
        snapshots as well as determining the actual data usage of a snapshot
        is sped up significantly.

    Closes-Bug #1907964

    Change-Id: I5e35de28007558267f9215cbac03a38d7c74612c
    (cherry picked from commit 0e8807388209086ee60e1c9f11a48ed6191e4178)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/782929
Committed: https://opendev.org/openstack/cinder/commit/610b59b272ba6207c3c50bf191d198cc4f4b4118
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 610b59b272ba6207c3c50bf191d198cc4f4b4118
Author: Christian Rohmann <email address hidden>
Date: Sun Dec 13 15:07:10 2020 +0100

    Add support for RBD fast-diff feature for backups stored in Ceph

        This change enables the FAST_DIFF feature for backup images stored
        via Ceph RBD. It is enabled together with EXCLUSIVE_LOCK and
        OBJECT_MAP as required.

        With FAST_DIFF enabled, the generation of diffs between images and
        snapshots as well as determining the actual data usage of a snapshot
        is sped up significantly.

    Closes-Bug #1907964

    Change-Id: I5e35de28007558267f9215cbac03a38d7c74612c
    (cherry picked from commit 0e8807388209086ee60e1c9f11a48ed6191e4178)
    (cherry picked from commit cbf9def32b31bcc3d4894d05e6fe665005006492)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/784041
Committed: https://opendev.org/openstack/cinder/commit/df0e702c10f98754c0f4091a3e36fc284c5d7d69
Submitter: "Zuul (22348)"
Branch: stable/train

commit df0e702c10f98754c0f4091a3e36fc284c5d7d69
Author: Christian Rohmann <email address hidden>
Date: Sun Dec 13 15:07:10 2020 +0100

    Add support for RBD fast-diff feature for backups stored in Ceph

        This change enables the FAST_DIFF feature for backup images stored
        via Ceph RBD. It is enabled together with EXCLUSIVE_LOCK and
        OBJECT_MAP as required.

        With FAST_DIFF enabled, the generation of diffs between images and
        snapshots as well as determining the actual data usage of a snapshot
        is sped up significantly.

    Closes-Bug #1907964

    Change-Id: I5e35de28007558267f9215cbac03a38d7c74612c
    (cherry picked from commit 0e8807388209086ee60e1c9f11a48ed6191e4178)
    (cherry picked from commit cbf9def32b31bcc3d4894d05e6fe665005006492)
    (cherry picked from commit 610b59b272ba6207c3c50bf191d198cc4f4b4118)