Various theme fixes

Bug #1907719 reported by Evonne Cheung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
20.10
Fix Released
High
Unassigned
21.04
Fix Released
High
Evonne Cheung

Bug Description

Profile block header with profile image needs to have a min-height so profile image clears within the space.

Remove all Tag in bold, change to normal weight.

Remove all pull-right and pull-left classes and put in float-right or float-left instead (bootstrap legacy).

Fix outline colour in custom theme, need specific paths as it is css not scss in this case.

Review use of outer-link and inner-link as they were not accessible. Rule is if it is a single link it can an outer-link so that the entire item is outlined on click (nicer visually), but if the item has other links within it then outer-link should not be used.

Remove outer-link hover background as some list items has it and some don't. Rule is no hover background colour for items.

Evonne Cheung (evonne)
Changed in mahara:
assignee: nobody → Evonne Cheung (evonne)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11501

Revision history for this message
Evonne Cheung (evonne) wrote : Re: 20.10 theme bugs

Patch hasn’t resolved all of the outer-links and inner-links as I found a few instances where it was needed, but they don’t involve any textual links, just the collapsible indicator.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11501
Committed: https://git.mahara.org/mahara/mahara/commit/51c4aa8370f7882b654b6ab1660309ffa7abf59f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 51c4aa8370f7882b654b6ab1660309ffa7abf59f
Author: Evonne <email address hidden>
Date: Wed Dec 16 12:11:09 2020 +1300

Bug 1907719: Fix styling issues

1. Profile picture in sidebar is now always within the background colour
even when there is a short name.
2. 'Tags' is not displayed in bold any more so as not to draw too much
attention to it.
3. Removed all pull-right and pull-left classes and put in float-right
or float-left instead (bootstrap legacy).
4. Fixed field outline colour in the configurable theme so that the same
colour is now used everywhere.
5. Reviewed the use of outer-link and inner-link as they were not
accessible. Rule: If it is a single link it can an outer-link so that
the entire item is outlined on click (nicer visually), but if the item
has other links within it then outer-link should not be used.
6. Removed outer-link hover background as some list items had it and
some didn't. Rule: No hover background colour for items.

behatnotneeded

Change-Id: I737841f9bfe825c0a004951bb4b7c7c589ab019d

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11511

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11511
Committed: https://git.mahara.org/mahara/mahara/commit/ec7560dc8b1388d28540d86b6db62f810b89d0a1
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit ec7560dc8b1388d28540d86b6db62f810b89d0a1
Author: Evonne <email address hidden>
Date: Wed Dec 16 12:11:09 2020 +1300

Bug 1907719: Fix styling issues

1. Profile picture in sidebar is now always within the background colour
even when there is a short name.
2. 'Tags' is not displayed in bold any more so as not to draw too much
attention to it.
3. Removed all pull-right and pull-left classes and put in float-right
or float-left instead (bootstrap legacy).
4. Fixed field outline colour in the configurable theme so that the same
colour is now used everywhere.
5. Reviewed the use of outer-link and inner-link as they were not
accessible. Rule: If it is a single link it can an outer-link so that
the entire item is outlined on click (nicer visually), but if the item
has other links within it then outer-link should not be used.
6. Removed outer-link hover background as some list items had it and
some didn't. Rule: No hover background colour for items.

behatnotneeded

Change-Id: I737841f9bfe825c0a004951bb4b7c7c589ab019d
(cherry picked from commit 51c4aa8370f7882b654b6ab1660309ffa7abf59f)

summary: - 20.10 theme bugs
+ Various theme fixes
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.