diagnostics panel can leave automatic crash reporting enabled

[Brian Murray]

* Impact

If one selects "Automatic" in the "Send error reports to Canonical" portion of "Problem Reporting" the file /var/lib/apport/autoreport is created. However, if you later switch to "Never" the file is not removed but the panel continues to show "Never".

* Test case

- change the automatic report option in settings to automatic and then to never, the /var/lib/apport/autoreport file should be removed

* Regression potential

The patch modifies the whoopsie configuration, check that the service status is right for the 3 auto/manual/never options

----------------

ProblemType: Bug
DistroRelease: Ubuntu 20.10
Package: gnome-control-center 1:3.38.1-1ubuntu1
ProcVersionSignature: Ubuntu 5.8.0-23.24-generic 5.8.14
Uname: Linux 5.8.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu50
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
Date: Fri Dec 4 12:38:37 2020
InstallationDate: Installed on 2016-01-22 (1778 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Alpha amd64 (20160117)
SourcePackage: gnome-control-center
UpgradeStatus: No upgrade log present (probably fresh install)

[Brian Murray (brian-murray)]

This debdiff fixes it for Ubuntu 20.04 LTS and patches for other releases should look the same.

[Sebastien Bacher (seb128)]

Thanks Brian, the fix makes sense!

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center - 1:3.38.2-1ubuntu2

---------------
gnome-control-center (1:3.38.2-1ubuntu2) hirsute; urgency=medium

  [ Brian Murray ]
  * 0016-diagnostics-Add-Whoopsie-support.patch: ensure that we always perform
    the call to automatically report crashes so that it will be turned off if
    "never" is chosen. (LP: #1906877)

 -- Sebastien Bacher <email address hidden> Mon, 07 Dec 2020 18:56:07 +0100

[Sebastien Bacher (seb128)]

In fact thing are still not really right after patching since settings still displays 'never' in case where reporting=false and autoreport=true.

Is whoopsie really sending reports in that configuration? If so it does sound like an issue on the service, if reporting is disabled then the autoreport value shouldn't matter? That's also what the current settings behaviour assumes.

[Brian Murray (brian-murray)]

I'm not sure how you would get it in a state where reporting=false and autoreport=true. These are the dbus settings for the 3 possible states in hirsute with the new version of gnome-control-center.

"Never"
WhoopsiePreferences
node /com/ubuntu/WhoopsiePreferences {
  interface com.ubuntu.WhoopsiePreferences {
    properties:
      readonly b ReportCrashes = false;
      readonly b ReportMetrics = true;
      readonly b AutomaticallyReportCrashes = false;
  };
};

"Automatic"
bdmurray@clean-hirsute-amd64:~$ gdbus introspect --system --only-properties --dest com.ubuntu.WhoopsiePreferences --object-path /com/ubuntu/WhoopsiePreferences
node /com/ubuntu/WhoopsiePreferences {
  interface com.ubuntu.WhoopsiePreferences {
    properties:
      readonly b ReportCrashes = true;
      readonly b ReportMetrics = true;
      readonly b AutomaticallyReportCrashes = true;
  };
};

"Manual"
bdmurray@clean-hirsute-amd64:~$ gdbus introspect --system --only-properties --dest com.ubuntu.WhoopsiePreferences --object-path /com/ubuntu/
WhoopsiePreferences
node /com/ubuntu/WhoopsiePreferences {
  interface com.ubuntu.WhoopsiePreferences {
    properties:
      readonly b ReportCrashes = true;
      readonly b ReportMetrics = true;
      readonly b AutomaticallyReportCrashes = false;
  };
};

[Brian Murray (brian-murray)]

Ah actually this could happen if you set "Never" in the control panel but either manually created /var/lib/apport/autoreport or installed the apport-noui package.

Unpacking apport-noui (2.20.11-0ubuntu55) ...
Setting up apport-noui (2.20.11-0ubuntu55) ...
bdmurray@clean-hirsute-amd64:~$ gdbus introspect --system --only-properties --dest com.ubuntu.WhoopsiePreferences --object-path /com/ubuntu/WhoopsiePreferences
node /com/ubuntu/WhoopsiePreferences {
  interface com.ubuntu.WhoopsiePreferences {
    properties:
      readonly b ReportCrashes = false;
      readonly b ReportMetrics = true;
      readonly b AutomaticallyReportCrashes = true;
  };
};

I think that's a different bug with gnome-control-center not reading the current state of things when starting up.

[Brian Murray (brian-murray)]

Hello Brian, or anyone else affected,

Accepted gnome-control-center into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.38.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sebastien Bacher (seb128)]

Using 1:3.38.3-0ubuntu1 to change the reporting from automatic to never correctly delete the autoreport configuration. The status is also correctly reflected in the UI and still correct after a restart

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center - 1:3.38.3-0ubuntu1

---------------
gnome-control-center (1:3.38.3-0ubuntu1) groovy; urgency=medium

  * New stable version (lp: #1911918)
  * debian/patches/gitlab_ucm_mixer_control_select.patch:
    - removed, the change is in the new version
  * debian/patches/0016-diagnostics-Add-Whoopsie-support.patch:
    - correct set and reflect the autoreport configuration (lp: #1906877)

 -- Sebastien Bacher <email address hidden> Fri, 15 Jan 2021 16:09:17 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-control-center has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Robie Basak (racb)]

Hello Brian, or anyone else affected,

Accepted gnome-control-center into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.36.5-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

I installed the version of gnome-control-center from focal-proposed and can confirm that the only setting "Automatic" creates the file /var/lib/apport/autoreport and switching the option to anything but "Automatic" removes the /var/lib/apport/autoreport file.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center - 1:3.36.5-0ubuntu2

---------------
gnome-control-center (1:3.36.5-0ubuntu2) focal; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * git-user-accounts-Use-newly-designed-fingerprint-enroll-dialo.patch:
    Correctly handle errors on fingerprint enroll dialog (LP: #1915174)

  [ Brian Murray ]
  * 0016-diagnostics-Add-Whoopsie-support.patch: ensure that we always perform
    the call to automatically report crashes so that it will be turned off if
    "never" is chosen. (LP: #1906877)

 -- Sebastien Bacher <email address hidden> Tue, 06 Apr 2021 16:01:31 +0200

[Sebastien Bacher (seb128)]

Closing for bionic, the fix isn't important at this point to be SRUed there